Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

> On Jan. 24, 2016, 10:01 p.m., David Faure wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 195 > > > > > > Yes, this definitely looks like it should be fixed in Qt instead (and > > this code

Review Request 126880: Fix QFileDialog::openUrl() for remote files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126880/ --- Review request for KDE Frameworks and David Faure. Bugs: 345253 https

Re: Review Request 126831: WIP: Fix QFileDialog::openUrl() for remote files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126831/ --- (Updated Jan. 24, 2016, 11:23 p.m.) Status -- This change has been d

Re: Review Request 126876: Fix QFileDialog::openUrl() for remote files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review91545 --- src/platformtheme/kdeplatformfiledialoghelper.cpp (line 195)

Review Request 126876: Fix QFileDialog::openUrl() for remote files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/ --- Review request for KDE Frameworks, Alex Richardson and David Faure. Repos

Re: Review Request 126764: Workaround for leading slash returned by QUrl::toDisplayString(QUrl::PreferLocalFile) untill fixed in Qt

> On Jan. 17, 2016, 5:51 p.m., Kevin Funk wrote: > > I have a fix: https://codereview.qt-project.org/#/c/145963/ > > > > Feel free to patch your self-built Qt on Windows for now... :) Thanks :) - Kåre --- This is an automatically gener

Re: Review Request 126764: Workaround for leading slash returned by QUrl::toDisplayString(QUrl::PreferLocalFile) untill fixed in Qt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126764/ --- (Updated Jan. 24, 2016, 8:51 p.m.) Status -- This change has been di

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

> On Ян. 24, 2016, 4:43 след обяд, David Edmundson wrote: > > >Continous usage, read as suspend/resume/use and so on, cause *cool* > > >tooltip animation transition between item to decrease it permormance > > > > Why does QPropertyAnimation decrease in performance after suspend/restore? > > >

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

> On Jan. 24, 2016, 2:43 p.m., David Edmundson wrote: > > >Continous usage, read as suspend/resume/use and so on, cause *cool* > > >tooltip animation transition between item to decrease it permormance > > > > Why does QPropertyAnimation decrease in performance after suspend/restore? > > > > Ot

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/#review91526 --- Ship it! - Yichao Yu On 一月 18, 2016, 11:48 a.m., René J.

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126870/ --- (Updated Ян. 24, 2016, 5:20 след обяд) Review request for KDE Frameworks,

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

> On Ян. 24, 2016, 4:43 след обяд, David Edmundson wrote: > > src/declarativeimports/core/tooltipdialog.cpp, line 184 > > > > > > You now have a a boolean and a potential null pointer both indicating > > the sam

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

> On Ян. 24, 2016, 4:43 след обяд, David Edmundson wrote: > > >Continous usage, read as suspend/resume/use and so on, cause *cool* > > >tooltip animation transition between item to decrease it permormance > > > > Why does QPropertyAnimation decrease in performance after suspend/restore? > > >

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126870/#review91521 --- >Continous usage, read as suspend/resume/use and so on, cause

Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126870/ --- Review request for KDE Frameworks, Plasma and David Edmundson. Bugs: 3543

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On gen. 20, 2016, 12:02 p.m., Lorenzo Porta wrote: > > src/kmainwindow.cpp, lines 213-214 > > > > > > These don't work because a null domain return nothing. You must replace > > Q_NULLPTR with KLocalizedString

Re: Review Request 126868: Update docs for KCrash::Initialize.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126868/ --- (Updated Jan. 24, 2016, 12:32 p.m.) Status -- This change has been m

Re: Review Request 126868: Update docs for KCrash::Initialize.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126868/#review91513 --- Ship it! Ship It! - David Faure On Jan. 24, 2016, 11:01

Review Request 126868: Update docs for KCrash::Initialize.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126868/ --- Review request for KDE Frameworks and David Faure. Repository: kcrash D