----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126868/#review91513 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Jan. 24, 2016, 11:01 a.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126868/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2016, 11:01 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kcrash > > > Description > ------- > > Currently the platform plugin makes no such call so this is the only way to > ensure that the crash handler is always launched. > > As discussed on the mailing list, simply linking to KCrash is not enough. Many > distributions build their packages with --as-needed which causes the link to > be > broken as, without any library usage, it appears to be unused. > > https://mail.kde.org/pipermail/kde-frameworks-devel/2015-September/026973.html > https://mail.kde.org/pipermail/kde-frameworks-devel/2015-November/028630.html > > > Diffs > ----- > > src/kcrash.h e2b59f219edaba8abfb0f5e100d5b6b41223db50 > > Diff: https://git.reviewboard.kde.org/r/126868/diff/ > > > Testing > ------- > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
