> On Jan. 24, 2016, 10:01 p.m., David Faure wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 195 > > <https://git.reviewboard.kde.org/r/126876/diff/1/?file=439596#file439596line195> > > > > Yes, this definitely looks like it should be fixed in Qt instead (and > > this code can be kept with a #ifdef QT_VERSION if you want). > > > > The method is called setDirectory, I expect it to get a directory.
OK, but what whould I put as QT_VERSION? ;) The bug is present in at least Qt 5.5.1. I have not tried with the Qt 5.6 branch. I wonder if it is actually fixable in Qt. How does Qt determine what is a file and what is a directory? What if you name a directory "foo.doc" and you cannot use QFileInfo::isDir() on it. - Kåre ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review91545 ----------------------------------------------------------- On Jan. 24, 2016, 9:19 p.m., Kåre Särs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126876/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2016, 9:19 p.m.) > > > Review request for KDE Frameworks, Alex Richardson and David Faure. > > > Repository: frameworkintegration > > > Description > ------- > > This fix is a bit like Alex Richardson workaround in KIO > (https://git.reviewboard.kde.org/r/126831/), but in frameworkintegration in > stead (I did not see his/Your KIO fix before now...) > > I check the remote url in setDirectory() because setDirectoy() is called from > two places. > > > Diffs > ----- > > src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb > > Diff: https://git.reviewboard.kde.org/r/126876/diff/ > > > Testing > ------- > > Kate now happily opens local and remote folders :) > > > Thanks, > > Kåre Särs > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
