----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126876/#review91545 -----------------------------------------------------------
src/platformtheme/kdeplatformfiledialoghelper.cpp (line 195) <https://git.reviewboard.kde.org/r/126876/#comment62556> Yes, this definitely looks like it should be fixed in Qt instead (and this code can be kept with a #ifdef QT_VERSION if you want). The method is called setDirectory, I expect it to get a directory. - David Faure On Jan. 24, 2016, 9:19 p.m., Kåre Särs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126876/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2016, 9:19 p.m.) > > > Review request for KDE Frameworks, Alex Richardson and David Faure. > > > Repository: frameworkintegration > > > Description > ------- > > This fix is a bit like Alex Richardson workaround in KIO > (https://git.reviewboard.kde.org/r/126831/), but in frameworkintegration in > stead (I did not see his/Your KIO fix before now...) > > I check the remote url in setDirectory() because setDirectoy() is called from > two places. > > > Diffs > ----- > > src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb > > Diff: https://git.reviewboard.kde.org/r/126876/diff/ > > > Testing > ------- > > Kate now happily opens local and remote folders :) > > > Thanks, > > Kåre Särs > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
