> On Ян. 24, 2016, 4:43 след обяд, David Edmundson wrote: > > src/declarativeimports/core/tooltipdialog.cpp, line 184 > > <https://git.reviewboard.kde.org/r/126870/diff/1/?file=436447#file436447line184> > > > > You now have a a boolean and a potential null pointer both indicating > > the same thing. Data duplication is generally bad.
Potentially you're right. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126870/#review91521 ----------------------------------------------------------- On Ян. 24, 2016, 4:08 след обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126870/ > ----------------------------------------------------------- > > (Updated Ян. 24, 2016, 4:08 след обяд) > > > Review request for KDE Frameworks, Plasma and David Edmundson. > > > Bugs: 354353 > http://bugs.kde.org/show_bug.cgi?id=354353 > > > Repository: plasma-framework > > > Description > ------- > > Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip > animation transition between item to decrease it permormance and looks quite > ugly. If add new panel animation is *cool* as is. The perfermonce decrease > can be cause due to swap use, or QPropertyAnimation issue, however we (you > KDE defs and i *like a user*) wants plasmashell and it's components (like > panel) to works *forever* > > > Diffs > ----- > > src/declarativeimports/core/tooltip.cpp a5e223b > src/declarativeimports/core/tooltipdialog.h 2ea8af9 > src/declarativeimports/core/tooltipdialog.cpp 6c3712e > > Diff: https://git.reviewboard.kde.org/r/126870/diff/ > > > Testing > ------- > > Workaround is quite simple: > Animation is refreshed as is, pointer hasn't same lifetime as panel > + Animation is disabled if compositing is not active > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
