Re: Policy for Dependencies

2015-10-12 Thread Martin Graesslin
On Tuesday, October 13, 2015 8:42:43 AM CEST Christoph Cullmann wrote: > Hi, thanks for raising this topic. I think it's very important that we have a general strategy for frameworks and not have thousands of micro-fixes in various frameworks. > 1) "Normal" deployment like we do in on Linux =>

Policy for Dependencies

2015-10-12 Thread Christoph Cullmann
Hi, in my quest to get Kate working on Mac (and Windows), I needed to patch some frameworks to have less required dependencies. e.g. doctools is a hassle on Windows and phonon is a hassle on both win/mac (if you don't require audio, like most applications won't) Now there is a bit of controver

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 10 p.m., Albert Astals Cid wrote: > > CMakeLists.txt, line 65 > > > > > > This should be part of the summary not here were people won't see it > > Christoph Cullmann wrote: > You are right

Re: Review Request 125616: Make doctools + wallet optional

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 10:01 p.m., Albert Astals Cid wrote: > > People should known what they are missing when building without the > > dependencies, please specify so at the summary > > Christoph Cullmann wrote: > Yes, that is true, will update the patch tomorrow. Done - Christoph --

Re: Review Request 125616: Make doctools + wallet optional

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/ --- (Updated Oct. 13, 2015, 6:32 a.m.) Review request for KDE Frameworks and

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 10 p.m., Albert Astals Cid wrote: > > CMakeLists.txt, line 65 > > > > > > This should be part of the summary not here were people won't see it > > Christoph Cullmann wrote: > You are right

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 8:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > > a

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/ --- (Updated Oct. 13, 2015, 6:20 a.m.) Review request for KDE Frameworks and

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Christoph Cullmann
> On Oct. 13, 2015, 2:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. > > Martin Klape

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

2015-10-12 Thread Christoph Cullmann
> On Oct. 13, 2015, 5:26 a.m., David Faure wrote: > > autotests/fallbackconfigresourcestest.cpp, line 3 > > > > > > This copyright line doesn't seem to be fully correct, unless I wrote > > this code during my slee

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

2015-10-12 Thread Christoph Cullmann
> On Oct. 13, 2015, 5:26 a.m., David Faure wrote: > > Is the file test.ini missing from this commit? test.ini is already there, used by an other test. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://g

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

2015-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/#review86775 --- Is the file test.ini missing from this commit? autotests/fal

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/#review86774 --- Ship it! autotests/knewpasswordwidgettest.cpp (line 143)

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Sune Vuorela
> On Oct. 13, 2015, 2:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. > > Martin Klape

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Martin Klapetek
> On Oct. 13, 2015, 4:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. ...and I'm sure

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/#review86771 --- As a maintainer, I would be much much more happy if it actuall

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

2015-10-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 23:43:20 + Build duration: 2 min 23 sec CHANGE SET Revision 942ebd2b5f0beb0dc6ff90f3ef66

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

2015-10-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 23:43:20 + Build duration: 2 min 23 sec CHANGE SET Revision 942ebd2b5f0beb0dc6ff90f3ef66

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 52 - Still Failing!

2015-10-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 23:36:15 + Build duration: 46 sec CHANGE SET Revision 681739dc4b2daf6f967576301dc88fffab

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 51 - Still Failing!

2015-10-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 23:31:05 + Build duration: 49 sec CHANGE SET Revision 62a1f607708705a67e199974d6f5cfd059

Re: Version numbering at download location

2015-10-12 Thread Marko Käning
Hi David, On 10 Oct 2015, at 15:37 , David Faure wrote: > OK, so we're not talking about the organization of the FTP directories, but > about HTML pages. > That's quite different (a single HTML page could point to multiple FTP > directories, for instance). yep. > Does https://www.kde.org/inf

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-12 Thread Ian Wadham
> On Oct. 12, 2015, 8:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > > a

Re: Review Request 125616: Make doctools + wallet optional

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 10:01 p.m., Albert Astals Cid wrote: > > People should known what they are missing when building without the > > dependencies, please specify so at the summary Yes, that is true, will update the patch tomorrow. - Christoph

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 10 p.m., Albert Astals Cid wrote: > > CMakeLists.txt, line 65 > > > > > > This should be part of the summary not here were people won't see it You are right, will fix that tomorrow. Will do th

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 50 - Failure!

2015-10-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 22:25:30 + Build duration: 50 sec CHANGE SET Revision e3b1d023dcf2c10f5b4feb4eb1973bcc0f

Re: Review Request 125262: Parse ServiceType files when reading .desktop files

2015-10-12 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125262/ --- (Updated Oct. 12, 2015, 10:25 p.m.) Status -- This change has been m

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 98 - Still Unstable!

2015-10-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/98/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 21:07:39 + Build duration: 2 min 1 sec CHANGE SET Revision f2ebdc5fd338ef1fc7838c5326a0ea2f35f972

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 94 - Still Unstable!

2015-10-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/94/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 21:07:34 + Build duration: 2 min 8 sec CHANGE SET Revision f2ebdc5fd338ef1fc7838c5326a0ea2

Re: Review Request 125616: Make doctools + wallet optional

2015-10-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/#review86763 --- People should known what they are missing when building withou

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/#review86762 --- CMakeLists.txt (line 65)

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 8:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > > a

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-12 Thread René J . V . Bertin
> On Oct. 12, 2015, 10:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > >

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 8:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > > a

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-12 Thread René J . V . Bertin
> On Oct. 12, 2015, 10:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > >

Review Request 125616: Make doctools + wallet optional

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 125612: Make doctools optional

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125612/ --- (Updated Oct. 12, 2015, 9:07 p.m.) Status -- This change has been ma

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 9:02 p.m., Milian Wolff wrote: > > in principle, I'm cool with that change, but why do you need to ship a > > default file anyways? > > > > KConfig is always used in the form > > > > ...read("value", default) > > > > so the defaults are hardcoded there already. Why shi

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

2015-10-12 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/#review86756 --- in principle, I'm cool with that change, but why do you need t

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/ --- (Updated Oct. 12, 2015, 9:01 p.m.) Status -- This change has been ma

Re: Review Request 125612: Make doctools optional

2015-10-12 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125612/#review86755 --- Ship it! +1 from my side, seems like a nobrainer to me. - Mi

Re: Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/#review86754 --- Ship it! who wants audio notifications anyways? +1 from my si

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 8:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > > a

Re: Review Request 125614: Enable normal rpath handling on Mac

2015-10-12 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125614/#review86752 --- There is an issue with Qt 5.5.0's configure script, currently.

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-10-12 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/ --- (Updated Oct. 12, 2015, 8:22 p.m.) Review request for KDE Frameworks and

Re: Review Request 125612: Make doctools optional

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125612/ --- (Updated Oct. 12, 2015, 8:10 p.m.) Review request for KDE Frameworks, kde

Re: phonon dep in knotifications

2015-10-12 Thread Christoph Cullmann
> On 2015-10-12, Christoph Cullmann wrote: >> Hi, >> >> I would like to make this dependency optional. >> Would that be ok? Is not that much work, but if it is not wanted, don't want >> to >> waste my time. >> E.g. on Win/Mac its a real hassle to build and most applications don't need >> it >> a

Review Request 125615: Make phonon dependency optional

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/ --- Review request for KDE Frameworks and Sune Vuorela. Repository: knotifica

Re: Review Request 125611: Make SharedMimeInfo an optional requirement

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125611/ --- (Updated Oct. 12, 2015, 8:01 p.m.) Status -- This change has been ma

Re: Review Request 125611: Make SharedMimeInfo an optional requirement

2015-10-12 Thread David Faure
> On Oct. 12, 2015, 7:48 p.m., David Faure wrote: > > I think you should install the xml file even if s-m-i isn't found. > > > > Otherwise, if someone installs kcoreaddons before s-m-i, he'll be missing > > the file. > > Christoph Cullmann wrote: > Ok, I will install the xml but skip the c

Re: Review Request 125611: Make SharedMimeInfo an optional requirement

2015-10-12 Thread Christoph Cullmann
> On Oct. 12, 2015, 7:48 p.m., David Faure wrote: > > I think you should install the xml file even if s-m-i isn't found. > > > > Otherwise, if someone installs kcoreaddons before s-m-i, he'll be missing > > the file. Ok, I will install the xml but skip the call to the then not known update ma

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/#review86742 --- Ship it! I have suggestions on how to improve the unit test,

Re: Review Request 125611: Make SharedMimeInfo an optional requirement

2015-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125611/#review86741 --- I think you should install the xml file even if s-m-i isn't fo

Re: phonon dep in knotifications

2015-10-12 Thread Sune Vuorela
On 2015-10-12, Christoph Cullmann wrote: > Hi, > > I would like to make this dependency optional. > Would that be ok? Is not that much work, but if it is not wanted, don't want > to waste my time. > E.g. on Win/Mac its a real hassle to build and most applications don't need > it anyway but > mig

phonon dep in knotifications

2015-10-12 Thread Christoph Cullmann
Hi, I would like to make this dependency optional. Would that be ok? Is not that much work, but if it is not wanted, don't want to waste my time. E.g. on Win/Mac its a real hassle to build and most applications don't need it anyway but might depend on knotifications. Greetings Christoph -- --

Review Request 125614: Enable normal rpath handling on Mac

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125614/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Alex Merry.

Review Request 125612: Make doctools optional

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125612/ --- Review request for KDE Frameworks and kdewin. Repository: kservice Desc

Review Request 125611: Make SharedMimeInfo an optional requirement

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125611/ --- Review request for KDE Frameworks, David Faure and Kåre Särs. Repository:

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-10-12 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/ --- (Updated Oct. 12, 2015, 5:01 p.m.) Review request for KDE Frameworks and

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/#review86728 --- src/knewpasswordwidget.cpp (line 291)

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-10-12 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/ --- (Updated Oct. 12, 2015, 4:13 p.m.) Review request for KDE Frameworks and

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-10-12 Thread Elvis Angelaccio
> On Oct. 11, 2015, 9:16 p.m., David Faure wrote: > > src/knewpasswordwidget.cpp, line 146 > > > > > > (This method is really a candidate for being unittested directly; just > > a thought) This is not a public

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 97 - Unstable!

2015-10-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/97/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 15:40:48 + Build duration: 2 min 19 sec CHANGE SET Revision 3116911fa0d02dc4c5f05923cc6d7bf490a58

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 93 - Still Unstable!

2015-10-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/93/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 15:40:48 + Build duration: 2 min 1 sec CHANGE SET Revision 3116911fa0d02dc4c5f05923cc6d7bf

Re: Review Request 123719: kbuildsycoca: parse all the mimeapps.list files mentionned in the new spec.

2015-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123719/ --- (Updated Oct. 12, 2015, 3:40 p.m.) Status -- This change has been ma

Re: Review Request 123719: kbuildsycoca: parse all the mimeapps.list files mentionned in the new spec.

2015-10-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123719/#review86723 --- Ship it! Ship It! - Albert Astals Cid On set. 19, 2015, 9:

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/ --- (Updated Oct. 12, 2015, 12:55 p.m.) Review request for KDE Frameworks and

Re: Review Request 125532: KTextEdit: fix loading Sonnet default settings, add context menu to switch spell-checking language

2015-10-12 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125532/ --- (Updated Oct. 12, 2015, 12:32 p.m.) Status -- This change has been m

Re: Review Request 125514: Add a web shortcut manager

2015-10-12 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/ --- (Updated oct. 12, 2015, 11:36 matin) Status -- This change has been

Re: Review Request 125514: Add a web shortcut manager

2015-10-12 Thread Laurent Montel
> On oct. 12, 2015, 7:02 matin, David Faure wrote: > > autotests/kurifiltersearchprovideractionstest.cpp, line 51 > > > > > > Well, KIO itself installs a large number of search providers, so this > > unittest can

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 131 - Fixed!

2015-10-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/131/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 10:35:17 + Build duration: 12 min CHANGE SET Revision c7ed3b31a80b856c23740f8065dadecdf3e6ef69 by scri

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 131 - Fixed!

2015-10-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/131/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 10:35:17 + Build duration: 12 min CHANGE SET Revision c7ed3b31a80b856c23740f8065dadecdf3e6ef69 by scri

Re: Review Request 125603: Add function to query standards xml file location

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/ --- (Updated Oct. 12, 2015, 11:15 a.m.) Status -- This change has been m

Re: Review Request 125603: Add function to query standards xml file location

2015-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/#review86704 --- Ship it! src/kxmlguiclient.cpp (line 216)

Re: Review Request 125603: Add function to query standards xml file location

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/ --- (Updated Oct. 12, 2015, 11:08 a.m.) Review request for KDE Frameworks and

Re: Review Request 125603: Add function to query standards xml file location

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/ --- (Updated Oct. 12, 2015, 11:07 a.m.) Review request for KDE Frameworks and

Re: Review Request 125603: Add function to query standards xml file location

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/ --- (Updated Oct. 12, 2015, 11:04 a.m.) Review request for KDE Frameworks and

Re: Review Request 125603: Add function to query standards xml file location

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/ --- (Updated Oct. 12, 2015, 11:03 a.m.) Review request for KDE Frameworks and

Re: Review Request 125603: Add function to query standards xml file location

2015-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/#review86702 --- I would say static, since it doesn't need an instance. - Davi

Review Request 125603: Add function to query standards xml file location

2015-10-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/ --- Review request for KDE Frameworks and David Faure. Repository: kxmlgui

Re: X11 on Windows

2015-10-12 Thread Patrick Spendrin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 12.10.2015 um 10:01 schrieb Jaroslaw Staniek: > On 12 October 2015 at 08:33, Martin Graesslin > wrote: >> Hi frameworks and windows devs, >> >> from the release announcement of the latest frameworks release I >> learned that there were multiple ch

Re: X11 on Windows

2015-10-12 Thread Martin Graesslin
On Monday, October 12, 2015 10:01:42 AM CEST Jaroslaw Staniek wrote: > On 12 October 2015 at 08:33, Martin Graesslin wrote: > > Hi frameworks and windows devs, > > > > from the release announcement of the latest frameworks release I learned > > that there were multiple changes to disable finding

Re: X11 on Windows

2015-10-12 Thread Jaroslaw Staniek
On 12 October 2015 at 08:33, Martin Graesslin wrote: > Hi frameworks and windows devs, > > from the release announcement of the latest frameworks release I learned that > there were multiple changes to disable finding X11 on Windows (e.g. [1]). I > think such changes are wrong and I have spoken ag

Re: Review Request 123719: kbuildsycoca: parse all the mimeapps.list files mentionned in the new spec.

2015-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123719/#review86694 --- ping? - David Faure On Sept. 19, 2015, 9:44 p.m., David Fau

Re: Review Request 125514: Add a web shortcut manager

2015-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86691 --- Ship it! autotests/kurifiltersearchprovideractionstest.cpp (