-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125598/#review86756
-----------------------------------------------------------
in principle, I'm cool with that change, but why do you need to ship a default
file anyways?
KConfig is always used in the form
...read("value", default)
so the defaults are hardcoded there already. Why ship another default config
file in ini format?
src/core/kconfig.cpp (line 720)
<https://git.reviewboard.kde.org/r/125598/#comment59690>
is prepending it really a fallback?
- Milian Wolff
On Oct. 12, 2015, 12:55 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125598/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 12:55 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> Like KXMLGui, KConfig has now a fallback to config files bundled with the
> application in resources.
>
> Like kxmlgui, its in :/kconfig5.
>
> This allows e.g. KTextEditor deployment without any installed files beside
> the library itself and should easy the shipping of default configs for
> non-linux/unix platforms.
>
> Question is if :/kconfig5 is that nice a prefix, at least it is unique and
> matches what we do with kxmlgui5.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 8213bc4
> autotests/fallbackconfigresources.qrc PRE-CREATION
> autotests/fallbackconfigresourcestest.cpp PRE-CREATION
> src/core/kconfig.cpp 7f03869
>
> Diff: https://git.reviewboard.kde.org/r/125598/diff/
>
>
> Testing
> -------
>
> Added an unit test to show that the fallback resource is found and read.
>
>
> Thanks,
>
> Christoph Cullmann
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
