----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/#review86754 -----------------------------------------------------------
Ship it! who wants audio notifications anyways? +1 from my side! - Milian Wolff On Oct. 12, 2015, 8:04 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125615/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 8:04 p.m.) > > > Review request for KDE Frameworks and Sune Vuorela. > > > Repository: knotifications > > > Description > ------- > > Make phonon dependency optional, purely internal change, like it is done for > speech. > > > Diffs > ----- > > CMakeLists.txt 5a4ec83 > src/CMakeLists.txt 2a88b5a > src/knotificationmanager.cpp 1c392b4 > > Diff: https://git.reviewboard.kde.org/r/125615/diff/ > > > Testing > ------- > > Still builds with (and now even without) phonon here. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
