> On Oct. 12, 2015, 7:48 p.m., David Faure wrote: > > I think you should install the xml file even if s-m-i isn't found. > > > > Otherwise, if someone installs kcoreaddons before s-m-i, he'll be missing > > the file. > > Christoph Cullmann wrote: > Ok, I will install the xml but skip the call to the then not known update > macro, is that ok then?
Yes, especially since Qt doesn't need it (it parses the raw xml file when s-m-i is not available). This cmake code is from kdelibs4 times, while with Qt5 s-m-i is indeed optional now. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125611/#review86741 ----------------------------------------------------------- On Oct. 12, 2015, 5:51 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125611/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 5:51 p.m.) > > > Review request for KDE Frameworks, David Faure and Kåre Särs. > > > Repository: kcoreaddons > > > Description > ------- > > Make SharedMimeInfo an optional requirement, useful e.g. on win and mac. > There is nothing like that normally and we can then avoid to install that > just to have it around for the dependency check > > > Diffs > ----- > > src/mimetypes/CMakeLists.txt 207b114 > > Diff: https://git.reviewboard.kde.org/r/125611/diff/ > > > Testing > ------- > > If the info is found, make install did still update the mime stuff. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
