----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86691 -----------------------------------------------------------
Ship it! autotests/kurifiltersearchprovideractionstest.cpp (line 51) <https://git.reviewboard.kde.org/r/125514/#comment59670> Well, KIO itself installs a large number of search providers, so this unittest can rely on them being present. I think this could be a lot more precise (checking qaction names for instance, like I did in konqpopupmenutest, or checking qaction texts for substrings, like knewfilemenutest does). src/widgets/CMakeLists.txt (line 162) <https://git.reviewboard.kde.org/r/125514/#comment59668> trailing whitespace src/widgets/kurifiltersearchprovideractions.cpp (line 76) <https://git.reviewboard.kde.org/r/125514/#comment59669> simplified() already takes care of \n and \r, so this can be simplified (haha) to const QString searchText = d->mSelectedText.simplified(); - David Faure On Oct. 10, 2015, 12:56 p.m., Laurent Montel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125514/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2015, 12:56 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > When we select text we can provide a search from internet. > > > Diffs > ----- > > autotests/CMakeLists.txt 989acd4 > autotests/kurifiltersearchprovideractionstest.h PRE-CREATION > autotests/kurifiltersearchprovideractionstest.cpp PRE-CREATION > src/widgets/CMakeLists.txt 9fd2fc0 > src/widgets/kurifiltersearchprovideractions.h PRE-CREATION > src/widgets/kurifiltersearchprovideractions.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125514/diff/ > > > Testing > ------- > > Tested from long time in kdepim. > I added autotests for it. > > > Thanks, > > Laurent Montel > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
