Re: Review Request 117733: Fully port KXMessages to XCB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117733/ --- (Updated April 25, 2014, 8:58 a.m.) Review request for KDE Frameworks.

Re: Review Request 117733: Fully port KXMessages to XCB

> On April 25, 2014, 12:53 a.m., David Faure wrote: > > src/kxmessages.cpp, line 101 > > > > > > Small issue: this doesn't look sorted by decreasing size. The bools > > should be last, not sure what's the size o

Re: Review Request 117708: move kioslave docs paths for co-installability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/#review56463 --- Ship it! Thanks - Burkhard Lück On April 23, 2014, 3:24 p.

Re: Review Request 117708: move kioslave docs paths for co-installability

> On April 23, 2014, 3:30 p.m., Luigi Toscano wrote: > > I think after this change many documentation links (at least in > > khelpcenter) need to be fixed (I can't check now). > > Kevin Ottens wrote: > That'd need to be confirmed before letting this patch in or not. > > Luigi Toscano wrote

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/#review56458 --- Ship it! OK for me, thanks - Burkhard Lück On April 24, 20

Re: Review Request 117695: change where dynamic replace tabs is performed

> On April 24, 2014, 10:31 p.m., Kevin Ottens wrote: > > Any chance to have some unit tests? Sure, I'll add some shortly. - Sven --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#r

Re: Review Request 117708: move kioslave docs paths for co-installability

> On April 23, 2014, 5:30 p.m., Luigi Toscano wrote: > > I think after this change many documentation links (at least in > > khelpcenter) need to be fixed (I can't check now). > > Kevin Ottens wrote: > That'd need to be confirmed before letting this patch in or not. Right: I checked, and a

Re: Review Request 117733: Fully port KXMessages to XCB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117733/#review56449 --- Ship it! src/kxmessages.h

Re: Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/#review56448 --- Ship it! Ship It! - Kevin Ottens On April 24, 2014, 5:46 a

Re: Review Request 117749: Allow kmimeassociationstest to be run alone

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/#review56447 --- Ship it! Ship It! - David Faure On April 24, 2014, 5:37 p.

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56446 --- Ship it! Ship It! - Kevin Ottens On April 24, 2014, 5:27 a

Re: Review Request 117708: move kioslave docs paths for co-installability

> On April 23, 2014, 3:30 p.m., Luigi Toscano wrote: > > I think after this change many documentation links (at least in > > khelpcenter) need to be fixed (I can't check now). That'd need to be confirmed before letting this patch in or not. - Kevin --

Re: Review Request 117704: Deprecate obsolete KStartupInfo ctor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117704/#review56443 --- Ship it! Ship It! - Kevin Ottens On April 23, 2014, 12:19

Re: Review Request 117706: remove unused kwallet upgrade script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117706/#review56444 --- Ship it! Ship It! - Kevin Ottens On April 23, 2014, 1:37 p

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/#review56441 --- Ship it! Ship It! - Kevin Ottens On April 24, 2014, 10:17

Re: Review Request 117703: Use NETWinInfo instead of custom XLib code in KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117703/#review56442 --- Ship it! Ship It! - Kevin Ottens On April 23, 2014, 11:58

Re: Review Request 117749: Allow kmimeassociationstest to be run alone

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/#review56440 --- Looks fine to me. Let's wait for David though. - Kevin Ottens

Re: Review Request 117695: change where dynamic replace tabs is performed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56439 --- Any chance to have some unit tests? - Kevin Ottens On April

Re: Review Request 117682: Define _DARWIN_C_SOURCE when building on Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117682/#review56438 --- Same here, looks fine to me, but I'd like Harald to have a bit

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/#review56436 --- Ship it! Ship It! - Kevin Ottens On April 21, 2014, 9:49 p

Re: Review Request 117581: Remove ECMDBusAddActivationService module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/#review56435 --- Ship it! Ship It! - Kevin Ottens On April 21, 2014, 9:47 p

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/#review56433 --- Ship it! Ship It! - David Faure On April 21, 2014, 9:49 p.

Re: Review Request 117658: Add a stub for ECMFindModuleHelpers to the find-modules dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117658/#review56434 --- Ship it! Ship It! - Kevin Ottens On April 20, 2014, 3 p.m.

Re: Review Request 117617: New syntax for ecm_install_icons()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117617/#review56432 --- Ship it! Ship It! - Kevin Ottens On April 17, 2014, 7:40 p

Re: Review Request 117602: Remove more UPnP stuff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117602/#review56430 --- Ship it! Ship It! - Kevin Ottens On April 16, 2014, 7:46 p

Re: Review Request 117593: ECMGeneratePriFile: Allow lib and include install dirs to be overridden

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117593/#review56428 --- Ship it! Ship It! - Kevin Ottens On April 16, 2014, 1:35 p

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- (Updated April 24, 2014, 10:17 p.m.) Review request for Documentation, KD

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

> On April 12, 2014, 10:48 a.m., Alex Merry wrote: > > This is my preferred solution, and is hopefully only a temporary one. > > However, I know David Faure doesn't like it, and (I assume) would rather > > have a generic LIBEXEC variable. > > > > My view is that libexec should be used for stu

Re: Review Request 117585: ECMFindModuleHelpers: set traditional variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117585/#review56427 --- Ship it! Ship It! - Kevin Ottens On April 16, 2014, 1:14 p

Re: Review Request 117583: Remove use of ecm_dbus_add_activation_service()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117583/#review56426 --- Ship it! Ship It! - Kevin Ottens On April 16, 2014, 10:25

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/#review56425 --- Ship it! Ship It! - Kevin Ottens On April 14, 2014, 4:04 p

Re: Review Request 117491: Rework FindX11_XCB.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/ --- (Updated April 24, 2014, 10:04 p.m.) Status -- This change has been

Re: Review Request 117491: Rework FindX11_XCB.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review56423 --- Ship it! Ship It! - Kevin Ottens On April 11, 2014, 8:32 p

Re: Review Request 117491: Rework FindX11_XCB.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review56424 --- This review has been submitted with commit a92b1da58ea317a3a6

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/#review56422 --- Ship it! I was hoping in other answers from translators :( T

Re: Android integration in KConfig framework

On Thu, Apr 24, 2014 at 10:55 PM, Aleix Pol wrote: > On Thu, Apr 24, 2014 at 9:11 PM, JAZEIX Johnny wrote: > >> Hi, >> >> I'm currently working on GCompris port (passing from Gtk to Qt5 qml/js) >> and for storing persistent data, i'm using KConfig (from >> https://projects.kde.org/projects/frame

Re: Review Request 117011: Use bin/../share on Windows as a workaround

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- (Updated April 24, 2014, 9:57 p.m.) Status -- This change has been d

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- (Updated April 24, 2014, 9:46 p.m.) Review request for Documentation, KDE

Review Request 117758: Update install-compile.docbook translations to not reference KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano. Repos

Re: Android integration in KConfig framework

On Thu, Apr 24, 2014 at 9:11 PM, JAZEIX Johnny wrote: > Hi, > > I'm currently working on GCompris port (passing from Gtk to Qt5 qml/js) > and for storing persistent data, i'm using KConfig (from > https://projects.kde.org/projects/frameworks/kconfig/repository). > > It works fine on Desktop (test

Android integration in KConfig framework

Hi, I'm currently working on GCompris port (passing from Gtk to Qt5 qml/js) and for storing persistent data, i'm using KConfig (from https://projects.kde.org/projects/frameworks/kconfig/repository). It works fine on Desktop (tested on linux) and with a slight modification (I attached a poten

Re: Review Request 117475: kmimeassociationstest: do not use KDE apps in test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/ --- (Updated April 24, 2014, 6:54 p.m.) Review request for KDE Frameworks and

Re: Review Request 117475: kmimeassociationstest: do not use KDE apps in test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/ --- (Updated April 24, 2014, 6:19 p.m.) Review request for KDE Frameworks and

Review Request 117749: Allow kmimeassociationstest to be run alone

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Re: Review Request 117078: Allow compiling kio on windows

> On April 23, 2014, 10:56 p.m., David Faure wrote: > > src/core/kioglobal_p_win.cpp, line 25 > > > > > > So this won't compile on XP at all? Well, we could dynamically resolve the function, but considering that

Re: Review Request 117080: cleanup KDirModelTest

> On April 24, 2014, 8:44 a.m., David Faure wrote: > > I wonder why this was discarded -- other than the fact that I took too much > > time to get to it. > > It looks good to me. Okay, I'll reopen and fix the issues. - Alexander --- T

Review request: kdeebugdialog5 co-installability

Reviewboard does not like this patch and even my usual goto man for git help agateau can't work out why. So here's a manual review request kdelibs4support: http://starsky.19inch.net/~jr/tmp/DIFF rename kdebugdialog to kdeebugdialog5 internally and move documentation to allow for co-installab

Re: Review Request 117705: co-installability: rename kactivitymanagerd to kactivitymanagerd5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117705/ --- (Updated April 24, 2014, 11:30 a.m.) Status -- This change has been

Re: Re: Re: Writing a Frameworks book at Randa

On Sun, Apr 13, 2014 at 10:38 PM, Martin Gräßlin wrote: > On Friday 11 April 2014 00:23:26 David Narvaez wrote: >> On Thu, Apr 10, 2014 at 5:02 AM, Martin Gräßlin wrote: >> > we might have here a chicken-egg problem. Good API documentation would >> > significantly help for writing the book. That

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

> On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: > > Until now we had no problems with the data installed to bin/../share and > > this setup would make it impossible to have multiple independent kde > > setups on one system. > > Alexander Richardson wrote: > I know. The problem is

Review Request 117733: Fully port KXMessages to XCB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117733/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/#review56349 --- Ship it! Ship It! - Thomas Lübking On April 24, 2014, 5:46