----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/ -----------------------------------------------------------
(Updated April 24, 2014, 6:19 p.m.) Review request for KDE Frameworks and David Faure. Changes ------- Rewrote patch to not use KDE applications at all (see description for rationale). Summary (updated) ----------------- kmimeassociationstest: do not use KDE apps in test Repository: kservice Description (updated) ------- kmimeassociationstest: do not use KDE apps in test Looking for applications with a kde4- prefix will not be useful in the long term, as those applications will disappear as people move away from kdelibs4. However, simply stripping the kde4- prefix also does not work because you can set a mime type assocation for "kwrite.desktop", and if the KF5-based KWrite (which has the desktop ID "kwrite.desktop") is not installed but the kdelibs4-based one (which has the desktop ID "kde4-kwrite.desktop") is installed, the mime type will be associated with kde4-kwrite.desktop, and the test will fail. To avoid this issue, we avoid using KDE applications in the tests. The prefixing stuff is explicitly tested with some fake application desktop files. We still try adding and removing associations for real applications (that may or may not be installed) to test cascading. Diffs (updated) ----- autotests/kmimeassociationstest.cpp d7b3ac29ca7292c0250286b241f20891c988bab6 Diff: https://git.reviewboard.kde.org/r/117475/diff/ Testing ------- Test still passes. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
