----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56439 -----------------------------------------------------------
Any chance to have some unit tests? - Kevin Ottens On April 23, 2014, 11:15 a.m., Sven Brauch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117695/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 11:15 a.m.) > > > Review request for KDE Frameworks and Christoph Cullmann. > > > Repository: ktexteditor > > > Description > ------- > > This makes typeChars handle replacing tabs by spaces, instead of insertText. > The rationale is that insertText is often called programatically, and the > caller should be able to rely on the text he requests to be inserted is > actually inserted, and not changed on-the-fly. Examples for where the > previous solution caused problems are KDevelop (the codegen) and > kte-collaborative. > > I'm not sure what the code I removed was doing (heh). It looks like it is > supposed to advance to the next indent level if the current indent level is > odd, but that still works after removing it. > > The obvious user-visible change here is that tabs in pasted text will no > longer be replaced. But since I always found this behaviour undesirable > anyways, I did not bother to replicate it. I will instead wait for people to > yell at me for removing it. ;) > > > Diffs > ----- > > src/document/katedocument.h 83cc0317e26ef077d5292763d0ba9864103bf454 > src/document/katedocument.cpp 546d3e6aadc57f24c3fa766ce235addc0f02e3c3 > > Diff: https://git.reviewboard.kde.org/r/117695/diff/ > > > Testing > ------- > > Just some quick manual tests, it seems to still work as intended. > > > Thanks, > > Sven Brauch > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
