> On April 25, 2014, 12:53 a.m., David Faure wrote: > > src/kxmessages.cpp, line 101 > > <https://git.reviewboard.kde.org/r/117733/diff/1/?file=268057#file268057line101> > > > > Small issue: this doesn't look sorted by decreasing size. The bools > > should be last, not sure what's the size of the xcb_*_t types though.
most of the types xcb_*_t are just typedefs for uint32_t. E.g. xcb_window_t. The cookie types are an exception, they are a struct having one unsigned int member. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117733/#review56449 ----------------------------------------------------------- On April 24, 2014, 10:02 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117733/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 10:02 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kwindowsystem > > > Description > ------- > > Fully port KXMessages to XCB > > * use xcb to resolve the intern atoms > * use xcb event structure for sending the client message > * add xcb overload for KXMessages::broadcastMessageX > * deprecate XLib variant > * extend test to verify all three variants of sending messages > > > Diffs > ----- > > autotests/kxmessages_unittest.cpp 90900f23961184e6bd35475e2cc43e0caa9099e9 > src/kxmessages.h e6534964e82bddae46a7b09976e9b7c9e3138a2a > src/kxmessages.cpp c76de22f5537e8a265d4dce53ce07e90234caeef > > Diff: https://git.reviewboard.kde.org/r/117733/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
