> On April 23, 2014, 3:30 p.m., Luigi Toscano wrote:
> > I think after this change many documentation links (at least in
> > khelpcenter) need to be fixed (I can't check now).
>
> Kevin Ottens wrote:
> That'd need to be confirmed before letting this patch in or not.
>
> Luigi Toscano wrote:
> Right: I checked, and all doc/kioslave/<foo>/CMakeLists.txt have
> something like:
> kdoctools_create_handbook(index.docbook INSTALL_DESTINATION
> ${HTML_INSTALL_DIR}/en SUBDIR kioslave/ftp)
>
> Similar lines are in other kioslave which will be available in
> kioslaves[-extra].
>
> In addition, I think that also the lines like
> X-DocPath=kioslave/<ioslave>/index.html
> from src/ioslaves/<ioslave>/<ioslaveprotocol1>.protocol
> should be fixed as well (Burkhard?).
>
> There are two "kioslave" references in khelpcenter which could be
> affected too (khelpcenter/plugintraverser.cpp
> khelpcenter/plugins/kioslaves.desktop) but I'm not sure now.
> Similar lines are in other kioslave which will be available in
> kioslaves[-extra]
Yes kio-extras should be changed accordingly + kioslaves in other modules
(kdepim/kdepimlibs/) with frameworks branches as well
> In addition, I think that also the lines like
> X-DocPath=kioslave/<ioslave>/index.html
> from src/ioslaves/<ioslave>/<ioslaveprotocol1>.protocol
> should be fixed as well (Burkhard?).
These are already fixed in this Review
> There are two "kioslave" references in khelpcenter which could be affected
> too (khelpcenter/plugintraverser.cpp
> khelpcenter/plugins/kioslaves.desktop) but I'm not sure now.
As far as I read the code these are not affected, but for the sake of
consistency they should be adapted as well.
We need to adapt l10n-kf5/scripts/autogen.sh to generate proper CMakeLists.txt
for translated docbboks as well,
but that does only make sense, when all docbooks (kcontrol/kioslave/etc) ended
up at their final location -
there are still a lot on my list, see
http://mail.kde.org/pipermail/kde-frameworks-devel/2014-April/014747.html
Otherwise I am fine with this patch
- Burkhard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117708/#review56293
-----------------------------------------------------------
On April 23, 2014, 3:24 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117708/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 3:24 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> move kioslave docs path which currently clashes with equivalents from
> kdelibs4 land.
>
>
> Diffs
> -----
>
> docs/kioslave/data/CMakeLists.txt 64ae620
> docs/kioslave/file/CMakeLists.txt 42385fb
> docs/kioslave/ftp/CMakeLists.txt 935298b
> docs/kioslave/help/CMakeLists.txt cfb29f1
> docs/kioslave/help/documentationnotfound/CMakeLists.txt f2bc0b5
> docs/kioslave/http/CMakeLists.txt 2aae4fb
> docs/kioslave/mailto/CMakeLists.txt b0a405e
> docs/kioslave/telnet/CMakeLists.txt 07b2d33
> docs/kioslave/webdav/CMakeLists.txt eb45ed5
> src/ioslaves/file/file.protocol 07cd4c3
> src/ioslaves/ftp/ftp.protocol 70ddcd0
> src/ioslaves/help/help.protocol 1bb5801
> src/ioslaves/http/http.protocol 2d97cd4
> src/ioslaves/http/https.protocol 62a43ad
> src/ioslaves/http/webdav.protocol c0fbd11
> src/ioslaves/http/webdavs.protocol 7017c24
> src/ioslaves/mailto/kmailservice5.desktop 03838a5
> src/ioslaves/protocols/data.protocol 2a57b2e
> src/ioslaves/telnet/ktelnetservice5.desktop 052a9d3
>
> Diff: https://git.reviewboard.kde.org/r/117708/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
