[GitHub] [kafka] chia7712 commented on a change in pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

chia7712 commented on a change in pull request #9102: URL: https://github.com/apache/kafka/pull/9102#discussion_r464216698 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -228,6 +228,13 @@ public Password getPassword(String key) {

[GitHub] [kafka] highluck commented on a change in pull request #9105: MINOR: closable object Memory leak prevention

highluck commented on a change in pull request #9105: URL: https://github.com/apache/kafka/pull/9105#discussion_r464215307 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -197,8 +197,8 @@ synchronized boolean lock(fina

[GitHub] [kafka] highluck commented on a change in pull request #9105: MINOR: closable object Memory leak prevention

highluck commented on a change in pull request #9105: URL: https://github.com/apache/kafka/pull/9105#discussion_r464215307 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -197,8 +197,8 @@ synchronized boolean lock(fina

[GitHub] [kafka] highluck commented on pull request #9105: MINOR: closable object Memory leak prevention

highluck commented on pull request #9105: URL: https://github.com/apache/kafka/pull/9105#issuecomment-667844194 @abbccdda Please review again thank you :) This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] albert02lowis commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

albert02lowis commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-667850415 Hi @abbccdda sure thing, I have added 2 more commits to this PR and the unit + integration tests also looks good in my local ---

[GitHub] [kafka] highluck commented on a change in pull request #9105: MINOR: closable object Memory leak prevention

highluck commented on a change in pull request #9105: URL: https://github.com/apache/kafka/pull/9105#discussion_r464215307 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -197,8 +197,8 @@ synchronized boolean lock(fina

[GitHub] [kafka] highluck removed a comment on pull request #9105: MINOR: closable object Memory leak prevention

highluck removed a comment on pull request #9105: URL: https://github.com/apache/kafka/pull/9105#issuecomment-667844194 @abbccdda Please review again thank you :) This is an automated message from the Apache Git Servi

[GitHub] [kafka] highluck commented on a change in pull request #9105: MINOR: closable object Memory leak prevention

highluck commented on a change in pull request #9105: URL: https://github.com/apache/kafka/pull/9105#discussion_r464215307 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -197,8 +197,8 @@ synchronized boolean lock(fina

[GitHub] [kafka] highluck closed pull request #9105: MINOR: closable object Memory leak prevention

highluck closed pull request #9105: URL: https://github.com/apache/kafka/pull/9105 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] highluck commented on pull request #9105: MINOR: closable object Memory leak prevention

highluck commented on pull request #9105: URL: https://github.com/apache/kafka/pull/9105#issuecomment-667867206 @abbccdda thanks for review I was mistaken and wrong close issue This is an automated message from

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r464241946 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientRequest.java ## @@ -34,6 +34,8 @@ private final boolean expectResponse; private f

[GitHub] [kafka] rajinisivaram merged pull request #9092: KAFKA-10163; Define `controller_mutation_rate` as a Double instead of a Long

rajinisivaram merged pull request #9092: URL: https://github.com/apache/kafka/pull/9092 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rajinisivaram commented on pull request #9092: KAFKA-10163; Define `controller_mutation_rate` as a Double instead of a Long

rajinisivaram commented on pull request #9092: URL: https://github.com/apache/kafka/pull/9092#issuecomment-667923327 @dajac Thanks for the PR, test failures not related, merging to trunk. This is an automated message from the

[GitHub] [kafka] amitbhoraniya opened a new pull request #9113: Fix trogdor coordinator client

amitbhoraniya opened a new pull request #9113: URL: https://github.com/apache/kafka/pull/9113 Trogdor coordinator client is not able to shutdown remote coordinator, so fixed that issue. ### Committer Checklist (excluded from commit message) - [x] Verify design and implementation

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-668034540 Finally, it is finished! :congratulations: All features and tests are now successfully migrated into log4j2 API and passes clearly! I changed the PR title and preparing

[GitHub] [kafka] kowshik commented on a change in pull request #9110: MINOR: Ensure a reason is logged for every segment deletion

kowshik commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r464012842 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File, * @param segments The log s

[GitHub] [kafka] abbccdda commented on pull request #9096: MINOR: Add comments to constrainedAssign and generalAssign method

abbccdda commented on pull request #9096: URL: https://github.com/apache/kafka/pull/9096#issuecomment-668113921 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] junrao commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

junrao commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r463885952 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -60,11 +60,34 @@ class LogSegment private[log] (val log: FileRecords,

[GitHub] [kafka] hachikuji commented on a change in pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

hachikuji commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r464545190 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,13 +2210,16 @@ class Log(@volatile private var _dir: File, * @param segments The log

[GitHub] [kafka] dajac opened a new pull request #9114: KAFKA-10162; Make the rate based quota behave more like a Token Bucket (KIP-599, Part III)

dajac opened a new pull request #9114: URL: https://github.com/apache/kafka/pull/9114 Based on the discussion in https://github.com/apache/kafka/pull/9072, I have put together an alternative way. This one does the following: * Instead of changing the implementation of the Rate to behave

[GitHub] [kafka] dhruvilshah3 commented on pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

dhruvilshah3 commented on pull request #9110: URL: https://github.com/apache/kafka/pull/9110#issuecomment-668151967 Thanks for the reviews @kowshik, @hachikuji, @ijuma. I have addressed the comments. This is an automated mes

[GitHub] [kafka] dhruvilshah3 edited a comment on pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

dhruvilshah3 edited a comment on pull request #9110: URL: https://github.com/apache/kafka/pull/9110#issuecomment-668151967 Thanks for the reviews @kowshik, @hachikuji, @ijuma. I have addressed the comments. Let me know what you think. --

[GitHub] [kafka] ijuma commented on pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

ijuma commented on pull request #9110: URL: https://github.com/apache/kafka/pull/9110#issuecomment-668162389 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] abbccdda commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r464567004 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientRequest.java ## @@ -34,6 +34,8 @@ private final boolean expectResponse; privat

[GitHub] [kafka] abbccdda commented on pull request #9096: MINOR: Add comments to constrainedAssign and generalAssign method

abbccdda commented on pull request #9096: URL: https://github.com/apache/kafka/pull/9096#issuecomment-668181513 Only flaky test failures. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] abbccdda merged pull request #9096: MINOR: Add comments to constrainedAssign and generalAssign method

abbccdda merged pull request #9096: URL: https://github.com/apache/kafka/pull/9096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] rhauch opened a new pull request #9115: Bump dev version to 2.6.1-SNAPSHOT

rhauch opened a new pull request #9115: URL: https://github.com/apache/kafka/pull/9115 As part of the 2.6.0 release, we need to bump the dev version of the `2.6` branch to 2.6.1. This is an automated message from the Apache

[GitHub] [kafka] ableegoldman commented on pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

ableegoldman commented on pull request #9094: URL: https://github.com/apache/kafka/pull/9094#issuecomment-668252969 cc @guozhangwang for 2nd review & merge This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] mjsax commented on pull request #9024: [DO NOT MERGE (yet)] MINOR: bump Streams integration test log level to DEBUG

mjsax commented on pull request #9024: URL: https://github.com/apache/kafka/pull/9024#issuecomment-668255117 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] guozhangwang commented on pull request #9024: [DO NOT MERGE (yet)] MINOR: bump Streams integration test log level to DEBUG

guozhangwang commented on pull request #9024: URL: https://github.com/apache/kafka/pull/9024#issuecomment-668258427 SG. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r464683179 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -461,6 +463,42 @@ public void flush(

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r464683987 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -38,13 +41,39 @@ */ final class StateM

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r464684660 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -267,80 +266,26 @@ public void handleAssignmen

[GitHub] [kafka] rhauch opened a new pull request #9116: KAFKA-10341: Add 2.6.0 to system tests and streams upgrade tests

rhauch opened a new pull request #9116: URL: https://github.com/apache/kafka/pull/9116 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] rhauch commented on pull request #9116: KAFKA-10341: Add 2.6.0 to system tests and streams upgrade tests

rhauch commented on pull request #9116: URL: https://github.com/apache/kafka/pull/9116#issuecomment-668281025 Just kicked off a build of the Streams system tests (e.g., `TC_PATHS=tests/kafkatest/tests/streams/streams_upgrade_test.py`) using this PR: https://jenkins.confluent.io/job/sys

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r464705276 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2956,6 +2956,22 @@ class KafkaApis(val requestChannel: RequestChannel, } }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r464716040 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,121 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r464717171 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1775,127 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r464697840 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1240,26 +1298,30 @@ class GroupCoordinator(val brokerId: Int, }

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r464718819 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1775,127 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] mjsax commented on a change in pull request #5374: MINOR: update release.py

mjsax commented on a change in pull request #5374: URL: https://github.com/apache/kafka/pull/5374#discussion_r464727207 ## File path: release.py ## @@ -479,16 +479,16 @@ def select_gpg_key(): for root, dirs, files in os.walk(artifacts_dir): assert root.startswith(artifact

[GitHub] [kafka] guozhangwang commented on pull request #8964: KAFKA-9450: Decouple flushing state from commiting

guozhangwang commented on pull request #8964: URL: https://github.com/apache/kafka/pull/8964#issuecomment-668301971 cc @mjsax please take a final look. This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] mjsax commented on pull request #9107: KAFKA-5488: KIP-418 implementation

mjsax commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-668302357 I'll put it into my backlog. But I am the main reviewer for two other KIPs (216 and 466) that I should review first as they got approve earlier and PRs are open for longer already.

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r464728426 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimeWindowedKStreamImpl.java ## @@ -19,7 +19,16 @@ import org.apache.kafka.co

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r464728901 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java ## @@ -275,6 +275,15 @@ */ TimeWindowedCogroupedKStrea

[GitHub] [kafka] Johnny-Malizia commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

Johnny-Malizia commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r464731245 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File, bytesTruncated }

[GitHub] [kafka] junrao commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

junrao commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r464724281 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] mjsax commented on a change in pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

mjsax commented on a change in pull request #9000: URL: https://github.com/apache/kafka/pull/9000#discussion_r464749727 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamUtil.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] abbccdda commented on pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

abbccdda commented on pull request #9060: URL: https://github.com/apache/kafka/pull/9060#issuecomment-668324185 Also, do we have new unit test coverage for the changes? This is an automated message from the Apache Git Service

[GitHub] [kafka] mjsax commented on pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on pull request #9039: URL: https://github.com/apache/kafka/pull/9039#issuecomment-668325203 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #9064: KAFKA-10205: Documentation and handling of non deterministic Topologies

mjsax commented on a change in pull request #9064: URL: https://github.com/apache/kafka/pull/9064#discussion_r464752987 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java ## @@ -50,6 +50,14 @@ /** * {@code StreamsBuilder} provide the high-level

[GitHub] [kafka] mjsax closed pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

mjsax closed pull request #8752: URL: https://github.com/apache/kafka/pull/8752 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

mjsax commented on pull request #8752: URL: https://github.com/apache/kafka/pull/8752#issuecomment-668326105 Closing this PR in favor of #9000 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r464756646 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -274,30 +252,74 @@ private void restoreSta

[GitHub] [kafka] mjsax commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

mjsax commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r464759130 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -71,21 +73,20 @@ private final Stri

[GitHub] [kafka] mjsax commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

mjsax commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r464759130 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -71,21 +73,20 @@ private final Stri

[GitHub] [kafka] mjsax commented on pull request #9047: KAFKA-9274: Remove `retries` for global task

mjsax commented on pull request #9047: URL: https://github.com/apache/kafka/pull/9047#issuecomment-668338125 > btw, it would be good to add test for IOException cases, such as Seems out of scope for this PR. We should rather to a new PR. I created https://issues.apache.org/jira/brows

[GitHub] [kafka] junrao commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

junrao commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r464735038 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File, bytesTruncated } + def s

[GitHub] [kafka] mjsax commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

mjsax commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r464759130 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -71,21 +73,20 @@ private final Stri

[GitHub] [kafka] rhauch opened a new pull request #9117: MINOR: Add 2.6.0 upgrade instructions that were added to kafka-site f…

rhauch opened a new pull request #9117: URL: https://github.com/apache/kafka/pull/9117 …irst rather than to the kafka repo *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to pin

[GitHub] [kafka] rhauch opened a new pull request #9118: MINOR: Restore 2.5.0 upgrade instructions that were added to kafka-site rather than kafka repo

rhauch opened a new pull request #9118: URL: https://github.com/apache/kafka/pull/9118 This should be backported to the `2.6` and `2.5` branches. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI buil

[GitHub] [kafka] rhauch opened a new pull request #9119: MINOR: Add 2.7.0 upgrade instructions that are needed for every release

rhauch opened a new pull request #9119: URL: https://github.com/apache/kafka/pull/9119 This should **not** be backported. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[GitHub] [kafka] mjsax commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

mjsax commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r464774778 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -154,27 +164,34 @@ public InternalTopicManag

[GitHub] [kafka] mjsax commented on pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

mjsax commented on pull request #9060: URL: https://github.com/apache/kafka/pull/9060#issuecomment-668357683 Updated. Call for review @abbccdda > Also, do we have new unit test coverage for the changes? We did not really change much, only switching from `retries` to a "timeout

[GitHub] [kafka] rhauch commented on pull request #9116: KAFKA-10341: Add 2.6.0 to system tests and streams upgrade tests

rhauch commented on pull request #9116: URL: https://github.com/apache/kafka/pull/9116#issuecomment-668359309 Thanks, @mjsax The streams-only system test run (https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4082/) passed. The other was interrupted by a Jenkins rest

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r464791414 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int, }

[GitHub] [kafka] Johnny-Malizia commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

Johnny-Malizia commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r464793424 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File, bytesTruncated }

[GitHub] [kafka] jsancio commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

jsancio commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r46477 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -155,6 +157,10 @@ public AbstractCoordinator

[GitHub] [kafka] apovzner commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

apovzner commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r464807467 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java ## @@ -223,8 +229,14 @@ public void checkQuotas(long timeMs) {

[GitHub] [kafka] apovzner commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

apovzner commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r464810412 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [kafka] apovzner commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

apovzner commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r464811830 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [kafka] apovzner commented on pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

apovzner commented on pull request #9114: URL: https://github.com/apache/kafka/pull/9114#issuecomment-668399674 I also took a quick look and I agree that this implementation is cleaner and definitely easier to understand. Th

[GitHub] [kafka] johnthotekat opened a new pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

johnthotekat opened a new pull request #9120: URL: https://github.com/apache/kafka/pull/9120 *Deprecated the existing getters and added new getters `activeHost()`, `standbyHosts()`, and `partition()` in KeyQueryMetadata.java. *Updated the existing Tests to use the new getters of KeyQ

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r464884697 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3973,25 +3977,38 @@ void handleResponse(AbstractResponse a

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r464886489 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ListOffsetRequest.java ## @@ -47,96 +42,11 @@ public static final int CONSUMER_R

[GitHub] [kafka] dajac commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

dajac commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r464911676 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -892,136 +894,175 @@ class KafkaApis(val requestChannel: RequestChannel, def handleLis

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-668507540 @mjsax , could you review this PR to add tests? Thanks. This is an automated message from the Apache Git Service.

[GitHub] [kafka] showuon opened a new pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl

showuon opened a new pull request #9121: URL: https://github.com/apache/kafka/pull/9121 add 2 tests for IOExceptions cases: 1 for `OffsetCheckpoint` and 1 for `GlobalStateManagerImpl` ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] nresare opened a new pull request #9122: KAFKA-10314: KafkaStorageException on reassignment when offline log d…

nresare opened a new pull request #9122: URL: https://github.com/apache/kafka/pull/9122 …irectories exist Make sure that we set the isNew field in LeaderAndIsrRequest correctly for brokers that gets added to the replica set on reassignment. This is tested by creating a vari

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465029352 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1775,127 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465038411 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465038614 ## File path: core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala ## @@ -131,6 +133,16 @@ class PermissiveControllerMutationQuota(private va

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465040672 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465040813 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java ## @@ -223,8 +229,14 @@ public void checkQuotas(long timeMs) {

[GitHub] [kafka] dajac commented on pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on pull request #9114: URL: https://github.com/apache/kafka/pull/9114#issuecomment-668593472 @junrao @apovzner I have updated the PR to address your comments. I have also refactored the code a bit and updated all the tests of the controller quota manager to work with the To

[GitHub] [kafka] rhauch commented on pull request #9116: KAFKA-10341: Add 2.6.0 to system tests and streams upgrade tests

rhauch commented on pull request #9116: URL: https://github.com/apache/kafka/pull/9116#issuecomment-668606283 Green builds on JDK 11 and 14, and two unrelated failures (known flaky integration tests, not system tests) on JDK 8: ``` Test Result (2 failures / +1) org.apache.kafk

[GitHub] [kafka] rhauch edited a comment on pull request #9116: KAFKA-10341: Add 2.6.0 to system tests and streams upgrade tests

rhauch edited a comment on pull request #9116: URL: https://github.com/apache/kafka/pull/9116#issuecomment-668606283 Green builds on JDK 11 and 14, and two unrelated failures (known flaky integration tests, not system tests) on JDK 8: ``` Test Result (2 failures / +1) org.apac

[GitHub] [kafka] ijuma commented on pull request #9079: KAFKA-10308 fix flaky core/round_trip_fault_test.py

ijuma commented on pull request #9079: URL: https://github.com/apache/kafka/pull/9079#issuecomment-668607739 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] rhauch commented on pull request #9115: Bump dev version to 2.6.1-SNAPSHOT

rhauch commented on pull request #9115: URL: https://github.com/apache/kafka/pull/9115#issuecomment-668608342 Successful build on JDK 11. JDK 8 build timed out, and several test failures on JDK 14. Retest this please.

[GitHub] [kafka] ijuma merged pull request #9079: KAFKA-10308 fix flaky core/round_trip_fault_test.py

ijuma merged pull request #9079: URL: https://github.com/apache/kafka/pull/9079 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465073439 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -132,16 +135,19 @@

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465079294 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImpl.java ## @@ -0,0 +1,234 @@ +/* + * Licensed to the A

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465094963 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void shouldGro

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465097558 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -132,16 +135,19 @@

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465099913 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImpl.java ## @@ -0,0 +1,234 @@ +/* + * Licensed to the A

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465101059 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImpl.java ## @@ -0,0 +1,234 @@ +/* + * Licensed to the A

[GitHub] [kafka] mjsax commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

mjsax commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-668639088 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] badaiaqrandista commented on a change in pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

badaiaqrandista commented on a change in pull request #9099: URL: https://github.com/apache/kafka/pull/9099#discussion_r465105476 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -459,48 +466,32 @@ class DefaultMessageFormatter extends MessageFormatter

[GitHub] [kafka] badaiaqrandista commented on a change in pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

badaiaqrandista commented on a change in pull request #9099: URL: https://github.com/apache/kafka/pull/9099#discussion_r465105897 ## File path: core/src/test/scala/kafka/tools/DefaultMessageFormatterTest.scala ## @@ -0,0 +1,235 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [kafka] mjsax commented on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

mjsax commented on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-668643155 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

<    1   2   3   4   5   6   7   8   9   10   >