junrao commented on a change in pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#discussion_r464735038
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File,
bytesTruncated
}
+ def segmentRecovery(): LogSegment => Int = {
+ (segment: LogSegment) => {
+ recoverSegment(segment, None)
Review comment:
You can see how the recovery point is set in Log.flush(). To fail a
broker, we can probably do kafka.utils.Exit.exit(e.statusCode).
It would be useful if you could preserve the commit history for easier
incremental reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
