nresare opened a new pull request #9122:
URL: https://github.com/apache/kafka/pull/9122


   …irectories exist
   
   Make sure that we set the isNew field in LeaderAndIsrRequest correctly for 
brokers
   that gets added to the replica set on reassignment.
   
   This is tested by creating a variant of 
ControllerIntergationTest.testPartitionReassignment()
   that makes one of the log directories on the target broker offline before 
initiating the
   reassignment. Without the change to the way isNew is set, this fails after a 
timeout. With
   the change, it succeeds.
   
   To facilitate calling causeLogDirFailure() both from 
ControllerIntegrationTest and
   LogDirFailureTest, the method was moved to TestUtils along with the other 
helper
   methods that deals with interacting with KafkaServer instances for test 
cases.
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to