Johnny-Malizia commented on a change in pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#discussion_r464731245
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File,
bytesTruncated
}
+ def segmentRecovery(): LogSegment => Int = {
+ (segment: LogSegment) => {
+ recoverSegment(segment, None)
Review comment:
This sounds reasonable to me, what do I need to do to ensure the
recovery point is reset and the broker is failed?
##########
File path: core/src/main/scala/kafka/log/LazyIndex.scala
##########
@@ -52,6 +52,13 @@ class LazyIndex[T <: AbstractIndex] private (@volatile
private var indexWrapper:
def file: File = indexWrapper.file
+ def isLoaded: Boolean = {
+ indexWrapper match {
+ case indexValue: IndexValue[T] => true
Review comment:
:+1:
##########
File path: core/src/main/scala/kafka/log/LogSegment.scala
##########
@@ -60,11 +60,34 @@ class LogSegment private[log] (val log: FileRecords,
val baseOffset: Long,
val indexIntervalBytes: Int,
val rollJitterMs: Long,
- val time: Time) extends Logging {
+ val time: Time,
+ val segmentRecovery: LogSegment => Int) extends
Logging {
- def offsetIndex: OffsetIndex = lazyOffsetIndex.get
+ def loadIndexWithRecovery[T <: AbstractIndex](lazyIndex: LazyIndex[T]): T = {
Review comment:
:+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
