mjsax commented on a change in pull request #5374:
URL: https://github.com/apache/kafka/pull/5374#discussion_r464727207
##########
File path: release.py
##########
@@ -479,16 +479,16 @@ def select_gpg_key():
for root, dirs, files in os.walk(artifacts_dir):
assert root.startswith(artifacts_dir)
- for file in files:
- local_path = os.path.join(root, file)
- remote_path = os.path.join("public_html", kafka_output_dir,
root[len(artifacts_dir)+1:], file)
- sftp_cmds += "\nput %s %s" % (local_path, remote_path)
-
for dir in dirs:
sftp_mkdir(os.path.join("public_html", kafka_output_dir,
root[len(artifacts_dir)+1:], dir))
-if sftp_cmds:
- cmd("Uploading artifacts in %s to your Apache home directory" % root,
"sftp -b - %s...@home.apache.org" % apache_id, stdin=sftp_cmds)
+ for file in files:
+ local_path = os.path.join(root, file)
+ remote_path = os.path.join("public_html", kafka_output_dir,
root[len(artifacts_dir)+1:], file)
+ sftp_cmds = """
+put %s %s
+""" % (local_path, remote_path)
+ cmd("Uploading artifacts in %s to your Apache home directory" % root,
"sftp -b - %s...@home.apache.org" % apache_id, stdin=sftp_cmds)
Review comment:
It was always slow. This PR only made the script print stuff to stdout
regularly--before this PR, the script was uploading silently for a loooong time
and one could think it froze (even if it was just doing/uploading stuff). This
PR was not to make the upload faster, just to make the script appear alive :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
