vvcephei commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r468872295
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -532,14 +539,14 @@ public final void a
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468872733
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apac
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468873428
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throwable)
vvcephei commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r468873464
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java
##
@@ -54,7 +54,19 @@
private Sensor createSensor
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468874664
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throwable)
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468876395
##
File path:
core/src/test/scala/unit/kafka/admin/UserScramCredentialsCommandTest.scala
##
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foun
ijuma commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-672294145
Are we using `return` inside an anonymous function here?
This is an automated message from the Apache Git Service.
T
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468881832
##
File path:
core/src/test/scala/unit/kafka/server/DescribeUserScramCredentialsRequestTest.scala
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Softw
ijuma commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-672294311
Ah, is `maybeHandleIOException` the issue?
This is an automated message from the Apache Git Service.
To respond to t
ijuma commented on a change in pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#discussion_r468882551
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1501,43 +1501,36 @@ class Log(@volatile private var _dir: File,
case FetchTxnCommitted =
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468882676
##
File path:
core/src/test/scala/unit/kafka/server/AlterUserScramCredentialsRequestTest.scala
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache Software
dajac commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468090360
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/RequestContext.java
##
@@ -74,7 +77,9 @@ public RequestAndSize parseRequest(ByteBuffer b
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468884545
##
File path:
clients/src/main/java/org/apache/kafka/common/errors/ResourceNotFoundException.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Softwa
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r468885795
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/UserScramCredentialUpsertion.java
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Sof
guozhangwang commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r468891122
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,26 +181,42 @@ void openDB(final ProcessorCon
guozhangwang commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r468891122
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,26 +181,42 @@ void openDB(final ProcessorCon
guozhangwang commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672307404
test this
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ijuma commented on a change in pull request #9129:
URL: https://github.com/apache/kafka/pull/9129#discussion_r468895227
##
File path: README.md
##
@@ -199,6 +199,27 @@ You can run spotbugs using:
The spotbugs warnings will be found in `reports/spotbugs/main.html` and
`reports
guozhangwang commented on a change in pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#discussion_r468900386
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##
@@ -539,7 +539,7 @@ class TransactionCoordinator(broke
guozhangwang commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672326346
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
hachikuji opened a new pull request #9166:
URL: https://github.com/apache/kafka/pull/9166
The message generator was missing conversion logic for tagged structures.
This led to casting errors when either `fromStruct` or `toStruct` were invoked.
In the process of fixing this, I also found th
cmccabe commented on pull request #9166:
URL: https://github.com/apache/kafka/pull/9166#issuecomment-672338336
Thanks. This is one of those rare PRs where I really don't have any
comments on how the code could be better.
I do think we should do a round-trip test with the JSON conver
hachikuji commented on pull request #9166:
URL: https://github.com/apache/kafka/pull/9166#issuecomment-672347559
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
hachikuji merged pull request #9164:
URL: https://github.com/apache/kafka/pull/9164
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468832838
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -553,7 +558,11 @@ private KafkaAdminClient(AdminClientConfi
abbccdda commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468939109
##
File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
##
@@ -189,16 +189,18 @@ ClientRequest newClientRequest(String nodeId,
Abstr
abbccdda commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468939109
##
File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
##
@@ -189,16 +189,18 @@ ClientRequest newClientRequest(String nodeId,
Abstr
showuon commented on pull request #9062:
URL: https://github.com/apache/kafka/pull/9062#issuecomment-672397145
@abbccdda , could you please review this PR? Thanks.
This is an automated message from the Apache Git Service.
To
abbccdda commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r468939109
##
File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
##
@@ -189,16 +189,18 @@ ClientRequest newClientRequest(String nodeId,
Abstr
lbradstreet commented on a change in pull request #9147:
URL: https://github.com/apache/kafka/pull/9147#discussion_r468940704
##
File path:
tools/src/main/java/org/apache/kafka/tools/TransactionalMessageCopier.java
##
@@ -284,7 +296,7 @@ public static void main(String[] args)
abbccdda merged pull request #9158:
URL: https://github.com/apache/kafka/pull/9158
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
abbccdda commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r468967992
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##
@@ -528,13 +529,56 @@ public synchronized StreamsBuilder addStateStore(
abbccdda commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672476817
@guozhangwang Seems we have an import control:
```
[ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/clients/src/main/java/org/apache/k
guozhangwang commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672481673
> @guozhangwang Seems we have an import control:
@ableegoldman I see.. then we'd have to move it back.
I do not have further comments anyways, after green builds
guozhangwang merged pull request #8964:
URL: https://github.com/apache/kafka/pull/8964
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r468983667
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -154,15 +153,15 @@ public StreamTask(final Task
aluode99 opened a new pull request #9167:
URL: https://github.com/apache/kafka/pull/9167
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
abbccdda commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672560761
@guozhangwang Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please
chia7712 commented on a change in pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#discussion_r468999490
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1501,43 +1501,36 @@ class Log(@volatile private var _dir: File,
case FetchTxnCommitte
abbccdda commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672584897
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
abbccdda commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672585991
Started system tests:
- https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4120/
- https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4119/
-
abbccdda commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r469028867
##
File path: streams/src/test/java/org/apache/kafka/test/MockApiProcessor.java
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
serjchebotarev commented on pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#issuecomment-672683714
Looks like no issues related to the changes in this PR. @mjsax could you
please suggest what would be the next thing to do on this one?
---
rajinisivaram opened a new pull request #9168:
URL: https://github.com/apache/kafka/pull/9168
We are forcing runtime scala-library dependency to be the one used by Kafka
in
https://github.com/apache/kafka/commit/3fdf1523a369e9e2f03e215f39c0ed987b2a16c5,
but we still seem to include the ve
cadonna commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r469095757
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,26 +181,42 @@ void openDB(final ProcessorContext
chia7712 commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-672737657
I profiled one of our use case to trace the ```NonLocalReturnException```.
```Log#read``` and ```Log#fetchOffsetByTimestamp``` produces most of
```NonLocalReturnException``` so I
jeqo commented on a change in pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#discussion_r469225368
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBRangeIterator.java
##
@@ -29,32 +29,41 @@
// comparator to be pluggab
showuon commented on a change in pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#discussion_r467713932
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -363,6 +363,7 @@ private boolean sendRecords() {
ijuma commented on a change in pull request #9168:
URL: https://github.com/apache/kafka/pull/9168#discussion_r469256355
##
File path: build.gradle
##
@@ -716,7 +716,9 @@ project(':core') {
dependencies {
compile project(':clients')
compile libs.jacksonDatabind
-
ijuma commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-672882880
@chia7712 what are the other cases where we do this in `Log`?
This is an automated message from the Apache Git Servi
bbejeck commented on pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#issuecomment-672884942
Ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
chia7712 commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-672891234
> what are the other cases where we do this in Log?
The use case I mentioned is a heavy IO-load task of my (team) application. I
didn't trace other potential hot methods fo
chia7712 opened a new pull request #9169:
URL: https://github.com/apache/kafka/pull/9169
There is already a scheduler using default thread prefix so the others
should define different thread name. Otherwise, it is hard to distinguish them
by jvm profiler.
### Committer Checklist (ex
ijuma commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-672907940
Yeah, I would fix all the cases in this file at once if possible.
This is an automated message from the Apache Git S
ijuma commented on a change in pull request #7222:
URL: https://github.com/apache/kafka/pull/7222#discussion_r469307691
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
##
@@ -639,26 +643,34 @@ public synchronized OffsetRes
vvcephei commented on pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#issuecomment-672912500
Ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jeqo commented on a change in pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#discussion_r469314938
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractKeyValueStoreTest.java
##
@@ -422,6 +503,21 @@ public void
shouldNotThro
jeqo commented on a change in pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#discussion_r469315300
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/CachingKeyValueStoreTest.java
##
@@ -294,13 +305,27 @@ public void shouldIterateO
jeqo commented on a change in pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#discussion_r469315828
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/CachingKeyValueStoreTest.java
##
@@ -339,12 +366,24 @@ public void
shouldThrowIf
rajinisivaram commented on pull request #9168:
URL: https://github.com/apache/kafka/pull/9168#issuecomment-672922930
@ijuma I have updated the PR using `configurations.all` that you suggested.
Thank you!
This is an automated
vvcephei commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r469327500
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorder.java
##
@@ -187,37 +206,39 @@ public void reco
hachikuji merged pull request #9166:
URL: https://github.com/apache/kafka/pull/9166
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-672957838
> Yeah, I would fix all the cases in this file at once if possible.
sure
This is an automated message from
abbccdda commented on pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#issuecomment-672958592
All 3 pass, with minor exception due to ssh channel
This is an automated message from the Apache Git Service.
To
abbccdda merged pull request #8549:
URL: https://github.com/apache/kafka/pull/8549
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
vvcephei commented on pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#issuecomment-672975608
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei commented on pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#issuecomment-672975857
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
vvcephei commented on pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#issuecomment-672975770
Ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vvcephei commented on pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#issuecomment-672977276
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei commented on pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#issuecomment-672977429
Well, I guess I'll just run them locally.
This is an automated message from the Apache Git Service.
To respond to
guozhangwang commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r469388654
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,26 +181,42 @@ void openDB(final ProcessorCon
guozhangwang commented on pull request #9170:
URL: https://github.com/apache/kafka/pull/9170#issuecomment-672992402
Successful system tests:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4121/
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/41
guozhangwang opened a new pull request #9170:
URL: https://github.com/apache/kafka/pull/9170
In order to do this, I also removed the optimization such that once enforced
checkpoint is set to true, we always checkpoint unless the state stores are not
initialized at all (i.e. the snapshot is
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r469410480
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throw
guozhangwang commented on pull request #9170:
URL: https://github.com/apache/kafka/pull/9170#issuecomment-67281
cc @ableegoldman @abbccdda for reviews
This is an automated message from the Apache Git Service.
To respond t
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r469421523
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throw
cadonna commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r469422110
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,26 +181,42 @@ void openDB(final ProcessorContext
ableegoldman commented on pull request #9171:
URL: https://github.com/apache/kafka/pull/9171#issuecomment-673010059
cc @vvcephei @guozhangwang
This is an automated message from the Apache Git Service.
To respond to the messa
ableegoldman opened a new pull request #9171:
URL: https://github.com/apache/kafka/pull/9171
So we don't have to bug the committers to kick off tests 😄
This is an automated message from the Apache Git Service.
To respond to
guozhangwang merged pull request #9171:
URL: https://github.com/apache/kafka/pull/9171
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
hachikuji commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r469388095
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -748,7 +755,7 @@ class Partition(val topicPartition: TopicPartition,
leaderLogI
ableegoldman commented on a change in pull request #9170:
URL: https://github.com/apache/kafka/pull/9170#discussion_r469450345
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##
@@ -1609,12 +1609,11 @@ public void shouldRetu
ableegoldman commented on pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#issuecomment-673036155
@serjchebotarev he's out of office this week, just fyi.
This is an automated message from the Apache Git Ser
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r469457068
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throw
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r469460462
##
File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala
##
@@ -0,0 +1,132 @@
+package kafka.server
+
+import java.util
+import java.util.
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r469467881
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1210,28 +1218,20 @@ class Partition(val topicPartition: TopicPartition,
}
}
serjchebotarev commented on pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#issuecomment-673049249
@ableegoldman alright, thanks.
This is an automated message from the Apache Git Service.
To respond to the
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r469471723
##
File path:
clients/src/main/java/org/apache/kafka/common/utils/GeometricProgression.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Fo
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r469472239
##
File path:
clients/src/main/java/org/apache/kafka/common/utils/GeometricProgression.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Fo
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r469473196
##
File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java
##
@@ -74,22 +76,28 @@
private final ClusterResourceListeners clusterResour
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468736687
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -721,6 +730,11 @@ protected Node curNode() {
r
d8tltanc commented on a change in pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#discussion_r468736687
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -721,6 +730,11 @@ protected Node curNode() {
r
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r469476195
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throw
kkonstantine opened a new pull request #9172:
URL: https://github.com/apache/kafka/pull/9172
Addition of configs for custom topic creation with KIP-158 created a
regression when transformation configs are also included in the configuration
of a source connector.
To experience the i
kkonstantine commented on pull request #9172:
URL: https://github.com/apache/kafka/pull/9172#issuecomment-673065882
I'll be adding a few more tests.
This is an automated message from the Apache Git Service.
To respond to the
kkonstantine commented on pull request #9172:
URL: https://github.com/apache/kafka/pull/9172#issuecomment-673067506
cc @rhauch @wicknicks
This is an automated message from the Apache Git Service.
To respond to the message, p
ableegoldman opened a new pull request #9173:
URL: https://github.com/apache/kafka/pull/9173
We launched a Streams application reading from a single 3000-partition topic
and saw continuous rebalancing. Digging into the logs, every time the leader
sent a SyncGroup request it would discover
abbccdda commented on a change in pull request #9170:
URL: https://github.com/apache/kafka/pull/9170#discussion_r469509680
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -193,13 +193,17 @@ private void closeAndRevive(fin
abbccdda commented on pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#issuecomment-673088220
@d8tltanc Thanks for the great work! I could resume reviewing this PR
sometime next week, do you mind rebasing it?
--
vvcephei commented on pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#issuecomment-673090023
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
1001 - 1100 of 51557 matches
Mail list logo
