guozhangwang commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r468891122
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##########
@@ -181,26 +181,42 @@ void openDB(final ProcessorContext context) {
throw new ProcessorStateException(fatal);
}
- // Setup metrics before the database is opened, otherwise the metrics
are not updated
+ // Setup statistics before the database is opened, otherwise the
statistics are not updated
// with the measurements from Rocks DB
- maybeSetUpMetricsRecorder(configs);
+ maybeSetUpStatistics(configs);
openRocksDB(dbOptions, columnFamilyOptions);
open = true;
+
+ addValueProvidersToMetricsRecorder();
}
- private void maybeSetUpMetricsRecorder(final Map<String, Object> configs) {
- if (userSpecifiedOptions.statistics() == null &&
+ private void maybeSetUpStatistics(final Map<String, Object> configs) {
+ if (userSpecifiedOptions.statistics() != null) {
Review comment:
I was thinking that, if we know `maybeSetUpStatistics` is only called
once in lifetime of the store then here we could check that
`userSpecifiedOptions.statistics() == null` and otherwise throw illegal-state
exception. And then in `addValueProvidersToMetricsRecorder` we check that
``userSpecifiedOptions.statistics() != null` and otherwise throw illegal-state
exception. This is to make the call-trace assumptions more specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
