ableegoldman commented on a change in pull request #9170:
URL: https://github.com/apache/kafka/pull/9170#discussion_r469450345
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##########
@@ -1609,12 +1609,11 @@ public void shouldReturnStateManagerChangelogOffsets() {
}
@Test
- public void shouldCheckpointWithCreatedStateOnClose() {
+ public void shouldNotCheckpointOnCloseCreated() {
Review comment:
Why did this test change?
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##########
@@ -1629,16 +1628,18 @@ public void shouldCheckpointWithCreatedStateOnClose() {
assertFalse(source1.initialized);
assertFalse(source1.closed);
+ EasyMock.verify(stateManager, recordCollector);
+
final double expectedCloseTaskMetric = 1.0;
verifyCloseTaskMetric(expectedCloseTaskMetric, streamsMetrics,
metricName);
}
@Test
- public void shouldNotCheckpointOnCloseRestoringIfNoProgress() {
+ public void shouldCheckpointOnCloseRestoringIfNoProgress() {
Review comment:
Same with this one, why did it change? Or was the test just wrong to
begin with..?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
