guozhangwang commented on a change in pull request #8549:
URL: https://github.com/apache/kafka/pull/8549#discussion_r468900386
##########
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##########
@@ -539,7 +539,7 @@ class TransactionCoordinator(brokerId: Int,
s"${txnIdAndPidEpoch.transactionalId} due to timeout")
case error@(Errors.INVALID_PRODUCER_ID_MAPPING |
- Errors.INVALID_PRODUCER_EPOCH |
Review comment:
My confusion was that for new broker <-> new client communication, could
we still return `INVALID_PRODUCER_EPOCH` as the error code? From KIP-588 my
understanding is that, txn-coordinator -> producer would not return
`INVALID_PRODUCER_EPOCH` anymore for all txn-related requests, and only broker
-> producer ProduceResponse would return `INVALID_PRODUCER_EPOCH`. Now I get
that you are maintaining the javadoc / handling for compatibility. So we are
good :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
