abbccdda commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r468939109
########## File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java ########## @@ -189,16 +189,18 @@ ClientRequest newClientRequest(String nodeId, AbstractRequest.Builder<?> request * cancelling the request. The request may get cancelled sooner if the socket disconnects * for any reason including if another pending request to the same node timed out first. * @param callback the callback to invoke when we get a response + * @param initialPrincipalName the initial client principal name, when building a forward request + * @param initialClientId the initial client id, when building a forward request */ ClientRequest newClientRequest(String nodeId, AbstractRequest.Builder<?> requestBuilder, long createdTimeMs, boolean expectResponse, int requestTimeoutMs, + String initialPrincipalName, Review comment: I'm not sure it's meaningful to add an overload function just for the sake of minimizing code changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org