mjsax merged PR #19667:
URL: https://github.com/apache/kafka/pull/19667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
TaiJuWu commented on code in PR #19658:
URL: https://github.com/apache/kafka/pull/19658#discussion_r2082277116
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1048,14 +1053,18 @@ private void maybeHandleElectionLoss(NomineeState
state, long currentTimeM
jolshan commented on code in PR #19656:
URL: https://github.com/apache/kafka/pull/19656#discussion_r2082645597
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1674,7 +1675,7 @@ boolean isEndTxn() {
public void handleR
FrankYang0529 commented on code in PR #19635:
URL: https://github.com/apache/kafka/pull/19635#discussion_r2082842800
##
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala:
##
@@ -923,8 +925,56 @@ class AuthorizerIntegrationTest extends
AbstractAuthorizerI
FrankYang0529 commented on code in PR #19635:
URL: https://github.com/apache/kafka/pull/19635#discussion_r2082842171
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -411,10 +411,9 @@ class KafkaApis(val requestChannel: RequestChannel,
}
val topicPa
FrankYang0529 commented on PR #18216:
URL: https://github.com/apache/kafka/pull/18216#issuecomment-2868393424
Hi @chia7712, could you help me review this when you have time? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
junrao commented on code in PR #19635:
URL: https://github.com/apache/kafka/pull/19635#discussion_r2082629710
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -411,10 +411,9 @@ class KafkaApis(val requestChannel: RequestChannel,
}
val topicPartition
cmccabe commented on PR #19655:
URL: https://github.com/apache/kafka/pull/19655#issuecomment-2868119153
I see one test failure that I think is a flake:
```
FAILED ❌ AuthorizerIntegrationTest >
"testShareGroupDescribeWithGroupDescribeAndTopicDescribeAcl(String).quorum=kip932"
```
-
github-actions[bot] commented on PR #19621:
URL: https://github.com/apache/kafka/pull/19621#issuecomment-2868291597
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
xijiu commented on code in PR #19650:
URL: https://github.com/apache/kafka/pull/19650#discussion_r2081038035
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/StaticBrokerConfigTest.java:
##
@@ -108,4 +119,80 @@ public void
testTopicConfigsGetImp
github-actions[bot] commented on PR #18589:
URL: https://github.com/apache/kafka/pull/18589#issuecomment-2868291795
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19553:
URL: https://github.com/apache/kafka/pull/19553#issuecomment-2868291632
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
[
https://issues.apache.org/jira/browse/KAFKA-19257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anatolii Popov updated KAFKA-19257:
---
Description: The root issue for [KIP-1181: Metadata Rack Awareness for
Diskless Topics
|htt
Chirag Wadhwa created KAFKA-19258:
-
Summary: release acquired records for members whose share session
is evicted due to connection drop
Key: KAFKA-19258
URL: https://issues.apache.org/jira/browse/KAFKA-19258
FrankYang0529 commented on code in PR #19493:
URL: https://github.com/apache/kafka/pull/19493#discussion_r2081704851
##
clients/src/main/resources/common/message/ListConfigResourcesResponse.json:
##
@@ -16,18 +16,22 @@
{
"apiKey": 74,
"type": "response",
- "name": "ListC
Anatolii Popov created KAFKA-19257:
--
Summary: Metadata Rack Awareness for Diskless Topics
Key: KAFKA-19257
URL: https://issues.apache.org/jira/browse/KAFKA-19257
Project: Kafka
Issue Type: I
dajac commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2081683481
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/UtilsTest.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
TaiJuWu commented on code in PR #19664:
URL: https://github.com/apache/kafka/pull/19664#discussion_r2081575420
##
clients/src/main/resources/common/message/GetReplicaLogInfoResponse.json:
##
@@ -0,0 +1,39 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-19258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal updated KAFKA-19258:
--
Summary: Release acquired records for members whose share session is
evicted due to connection
kirktrue commented on code in PR #19622:
URL: https://github.com/apache/kafka/pull/19622#discussion_r2081983328
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/DefaultJwtRetriever.java:
##
@@ -36,32 +39,27 @@
import static
org.apache.kaf
kirktrue commented on code in PR #19622:
URL: https://github.com/apache/kafka/pull/19622#discussion_r2081985108
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerLoginCallbackHandler.java:
##
@@ -179,28 +180,34 @@ public class OAuthBearerLoginCallb
dajac commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2081899976
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/UtilsTest.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
kirktrue commented on code in PR #19622:
URL: https://github.com/apache/kafka/pull/19622#discussion_r2081986003
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerLoginCallbackHandler.java:
##
@@ -177,57 +178,41 @@ public class OAuthBearerLoginCallb
dajac commented on PR #19631:
URL: https://github.com/apache/kafka/pull/19631#issuecomment-2867059819
> > Do we skip events because we somehow commit offsets of unprocessed
records due to the race condition?
>
> Hi @dajac, this is precisely the side effect of this race condition.
junrao commented on code in PR #19661:
URL: https://github.com/apache/kafka/pull/19661#discussion_r2082362002
##
clients/src/main/java/org/apache/kafka/common/record/FileRecords.java:
##
@@ -54,34 +54,62 @@ public class FileRecords extends AbstractRecords implements
Closeable {
ahuang98 commented on code in PR #19655:
URL: https://github.com/apache/kafka/pull/19655#discussion_r2082367943
##
clients/src/main/java/org/apache/kafka/common/requests/IncrementalAlterConfigsRequest.java:
##
@@ -106,4 +107,35 @@ public AbstractResponse getErrorResponse(final i
ahuang98 commented on code in PR #19655:
URL: https://github.com/apache/kafka/pull/19655#discussion_r2082371275
##
clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCredentialsRequest.java:
##
@@ -81,4 +81,23 @@ public AbstractResponse getErrorResponse(int thr
ahuang98 commented on code in PR #19655:
URL: https://github.com/apache/kafka/pull/19655#discussion_r2082371275
##
clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCredentialsRequest.java:
##
@@ -81,4 +81,23 @@ public AbstractResponse getErrorResponse(int thr
ahuang98 commented on code in PR #19655:
URL: https://github.com/apache/kafka/pull/19655#discussion_r2082371275
##
clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCredentialsRequest.java:
##
@@ -81,4 +81,23 @@ public AbstractResponse getErrorResponse(int thr
TaiJuWu commented on code in PR #19662:
URL: https://github.com/apache/kafka/pull/19662#discussion_r2081756596
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionLogTest.scala:
##
@@ -114,14 +115,14 @@ class TransactionLogTest {
@Test
def testSerializeT
TaiJuWu commented on code in PR #19662:
URL: https://github.com/apache/kafka/pull/19662#discussion_r2081756280
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMetadataTest.scala:
##
@@ -29,7 +29,6 @@ import org.junit.jupiter.params.ParameterizedTest
import
ahuang98 commented on code in PR #19658:
URL: https://github.com/apache/kafka/pull/19658#discussion_r2082083752
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1048,14 +1053,18 @@ private void maybeHandleElectionLoss(NomineeState
state, long currentTime
jsancio commented on code in PR #19661:
URL: https://github.com/apache/kafka/pull/19661#discussion_r2082432457
##
clients/src/main/java/org/apache/kafka/common/record/FileRecords.java:
##
@@ -54,34 +54,62 @@ public class FileRecords extends AbstractRecords implements
Closeable
jsancio commented on code in PR #19661:
URL: https://github.com/apache/kafka/pull/19661#discussion_r2082432011
##
clients/src/main/java/org/apache/kafka/common/record/FileRecords.java:
##
@@ -54,34 +54,62 @@ public class FileRecords extends AbstractRecords implements
Closeable
[
https://issues.apache.org/jira/browse/KAFKA-17302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950592#comment-17950592
]
Azhar Ahmed commented on KAFKA-17302:
-
Hi Abhijeet,
Are you waiting for [PR1|https:
[
https://issues.apache.org/jira/browse/KAFKA-17302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950592#comment-17950592
]
Azhar Ahmed edited comment on KAFKA-17302 at 5/9/25 7:45 PM:
-
jsancio commented on code in PR #19661:
URL: https://github.com/apache/kafka/pull/19661#discussion_r2082446480
##
clients/src/main/java/org/apache/kafka/common/record/RecordBatchIterator.java:
##
@@ -41,7 +41,7 @@ protected T makeNext() {
} catch (EOFException e) {
Lianet Magrans created KAFKA-19259:
--
Summary: Async consumer fetch intermittent delays on console
consumer
Key: KAFKA-19259
URL: https://issues.apache.org/jira/browse/KAFKA-19259
Project: Kafka
cmccabe commented on code in PR #19586:
URL: https://github.com/apache/kafka/pull/19586#discussion_r2082446845
##
metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java:
##
@@ -148,6 +159,41 @@ public Long value() {
}));
}
+pu
Yunyung commented on code in PR #19658:
URL: https://github.com/apache/kafka/pull/19658#discussion_r2082456060
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##
@@ -4569,6 +4574,55 @@ public void testObserverFetchWithNoLocalId(boolean
withKip853Rpc) throw
jlprat commented on PR #19665:
URL: https://github.com/apache/kafka/pull/19665#issuecomment-2866210695
Merging as this doesn't need the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
jlprat merged PR #19665:
URL: https://github.com/apache/kafka/pull/19665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
dajac commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2081623145
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -324,4 +336,106 @@ static void throwIfRegularExpressionIsInvalid(
dajac commented on code in PR #19611:
URL: https://github.com/apache/kafka/pull/19611#discussion_r2081913011
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java:
##
@@ -19,41 +19,58 @@
import org.apache.kafka.common.Uui
squah-confluent closed pull request #19495: KAFKA-19164: Keep track of groups
when deleting transactional offsets
URL: https://github.com/apache/kafka/pull/19495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
squah-confluent commented on PR #19496:
URL: https://github.com/apache/kafka/pull/19496#issuecomment-2866902744
This PR needs revisiting once #19497 has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kevin-wu24 opened a new pull request, #19668:
URL: https://github.com/apache/kafka/pull/19668
Previously, `RequestManager` only allowed for one "in-flight" request at a
time across all KRaft RPC types. This PR allows `RequestManager` to handle one
"in-flight" request per type.
We ma
dajac commented on PR #19631:
URL: https://github.com/apache/kafka/pull/19631#issuecomment-2866251443
@chickenchickenlove Thanks for the patch and sorry for the delay. I have not
had the time to really dive into it yet. Would it be possible to extend the
description to better explain what t
showuon commented on PR #19665:
URL: https://github.com/apache/kafka/pull/19665#issuecomment-2866211441
Thanks Josep! Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
ejba commented on PR #19631:
URL: https://github.com/apache/kafka/pull/19631#issuecomment-2865281996
Thank you @chickenchickenlove for solving this issue.
@m1a2st @dajac Is it acceptable to merge this PR? 🙇
Unfortunately, this happens weekly, forcing teams to hunt down ignored
re
apoorvmittal10 opened a new pull request, #19666:
URL: https://github.com/apache/kafka/pull/19666
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
squah-confluent commented on PR #19495:
URL: https://github.com/apache/kafka/pull/19495#issuecomment-2866899747
Closing this since #19497 fixes the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jsancio commented on code in PR #19661:
URL: https://github.com/apache/kafka/pull/19661#discussion_r2082110647
##
clients/src/main/java/org/apache/kafka/common/record/FileRecords.java:
##
@@ -121,10 +122,14 @@ public void readInto(ByteBuffer buffer, int position)
throws IOExcep
jsancio commented on code in PR #19658:
URL: https://github.com/apache/kafka/pull/19658#discussion_r2082461965
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1048,14 +1053,18 @@ private void maybeHandleElectionLoss(NomineeState
state, long currentTimeM
cmccabe commented on PR #19655:
URL: https://github.com/apache/kafka/pull/19655#issuecomment-2867818949
lgtm, but there is a checkstyle error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ahuang98 commented on code in PR #19658:
URL: https://github.com/apache/kafka/pull/19658#discussion_r2082481731
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##
@@ -4569,6 +4574,55 @@ public void testObserverFetchWithNoLocalId(boolean
withKip853Rpc) thro
artemlivshits commented on code in PR #19539:
URL: https://github.com/apache/kafka/pull/19539#discussion_r2082499313
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -330,6 +334,17 @@ public synchronized void beginTransaction()
jsancio commented on code in PR #19644:
URL: https://github.com/apache/kafka/pull/19644#discussion_r2082505437
##
tests/kafkatest/utils/util.py:
##
@@ -168,7 +168,7 @@ def validate_delivery(acked, consumed,
idempotence_enabled=False, check_lost_dat
success = False
chia7712 merged PR #19663:
URL: https://github.com/apache/kafka/pull/19663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-19259:
---
Fix Version/s: 4.1.0
> Async consumer fetch intermittent delays on console consumer
> --
ahuang98 commented on code in PR #19658:
URL: https://github.com/apache/kafka/pull/19658#discussion_r208255
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##
@@ -4569,6 +4574,55 @@ public void testObserverFetchWithNoLocalId(boolean
withKip853Rpc) thro
stanislavkozlovski commented on PR #19336:
URL: https://github.com/apache/kafka/pull/19336#issuecomment-2866279343
should be good to merge @satishd @kamalcph @showuon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
dajac commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2081650493
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java:
##
@@ -324,4 +336,106 @@ static void throwIfRegularExpressionIsInvalid(
stanislavkozlovski commented on code in PR #19336:
URL: https://github.com/apache/kafka/pull/19336#discussion_r2081524370
##
docs/ops.html:
##
@@ -4026,13 +4026,14 @@ Broker
Configurations
-By default, Kafka server will not enable tiered storage feature.
remote.log.storage.s
dajac commented on code in PR #19497:
URL: https://github.com/apache/kafka/pull/19497#discussion_r2081526702
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -802,11 +946,18 @@ public OffsetFetchResponseData.OffsetFetchRespo
ejba commented on PR #19631:
URL: https://github.com/apache/kafka/pull/19631#issuecomment-2866288788
> Do we skip events because we somehow commit offsets of unprocessed records
due to the race condition?
Hi @dajac, this is precisely the side effect of this race condition.
--
This
[
https://issues.apache.org/jira/browse/KAFKA-19257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anatolii Popov reassigned KAFKA-19257:
--
Assignee: Anatolii Popov
> Metadata Rack Awareness for Diskless Topics
>
injae-kim commented on code in PR #19631:
URL: https://github.com/apache/kafka/pull/19631#discussion_r2081357892
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1304,23 +1304,25 @@ RequestFuture sendOffsetCommitRequest(final
[
https://issues.apache.org/jira/browse/KAFKA-19181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chirag Wadhwa resolved KAFKA-19181.
---
Resolution: Fixed
The system tests have been resolved
> Investigate system test failures
>
[
https://issues.apache.org/jira/browse/KAFKA-19258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal reassigned KAFKA-19258:
-
Assignee: Apoorv Mittal (was: Chirag Wadhwa)
> Release acquired records for members wh
FrankYang0529 commented on code in PR #19662:
URL: https://github.com/apache/kafka/pull/19662#discussion_r2081730543
##
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##
@@ -76,7 +76,7 @@ object TransactionCoordinator {
}
private def init
FrankYang0529 commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2081721119
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/UtilsTest.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
ejba commented on PR #19631:
URL: https://github.com/apache/kafka/pull/19631#issuecomment-2867148410
I believe this comment from @chickenchickenlove describes in detail a bad
sequence of events between the main thread and the consumer thread.
https://github.com/spring-projects/spring
mjsax opened a new pull request, #19667:
URL: https://github.com/apache/kafka/pull/19667
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
ahuang98 commented on code in PR #19658:
URL: https://github.com/apache/kafka/pull/19658#discussion_r2082035897
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##
@@ -4569,6 +4574,55 @@ public void testObserverFetchWithNoLocalId(boolean
withKip853Rpc) thro
squah-confluent commented on code in PR #19497:
URL: https://github.com/apache/kafka/pull/19497#discussion_r2082025292
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -736,6 +871,11 @@ public OffsetFetchResponseData.OffsetF
cmccabe commented on code in PR #19586:
URL: https://github.com/apache/kafka/pull/19586#discussion_r2082051224
##
metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java:
##
@@ -63,6 +74,8 @@ public final class ControllerMetadataMetrics implemen
[
https://issues.apache.org/jira/browse/KAFKA-19229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shivsundar R resolved KAFKA-19229.
--
Fix Version/s: 4.1.0
Resolution: Fixed
> fix flaky testShareGroupDescribeWithGroupDescr
github-actions[bot] closed pull request #16664: KAFKA-16373: KIP-1028:
Addressing Docker Official Images PR Comments for JVM, Native and Docker
Official Images
URL: https://github.com/apache/kafka/pull/16664
--
This is an automated message from the Apache Git Service.
To respond to the messa
jsancio commented on code in PR #19661:
URL: https://github.com/apache/kafka/pull/19661#discussion_r2082111369
##
clients/src/main/java/org/apache/kafka/common/record/FileRecords.java:
##
@@ -121,10 +122,14 @@ public void readInto(ByteBuffer buffer, int position)
throws IOExcep
github-actions[bot] commented on PR #16664:
URL: https://github.com/apache/kafka/pull/16664#issuecomment-2868303911
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
mjsax opened a new pull request, #19669:
URL: https://github.com/apache/kafka/pull/19669
- Moving off deprecated methods
- Fixing argument order for assertEquals(...)
- Few other minor cleanups
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
mjsax commented on code in PR #19669:
URL: https://github.com/apache/kafka/pull/19669#discussion_r2082807236
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -3425,6 +3441,7 @@ public void testAssignorNameConflict(GroupProtocol
groupProto
mjsax commented on code in PR #19669:
URL: https://github.com/apache/kafka/pull/19669#discussion_r2082807269
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -3445,6 +3463,7 @@ public void testBeginningOffsetsTimeout(GroupProtocol
groupPr
chickenchickenlove commented on PR #19631:
URL: https://github.com/apache/kafka/pull/19631#issuecomment-2868322361
@dajac
Sorry to make you confused.
Let me define problem clearly.
TL;DR:
- The race condition I mentioned earlier can trigger an unexpected
`CommitFailedExcep
junrao commented on code in PR #19661:
URL: https://github.com/apache/kafka/pull/19661#discussion_r2082571937
##
clients/src/main/java/org/apache/kafka/common/record/FileRecords.java:
##
@@ -54,33 +54,55 @@ public class FileRecords extends AbstractRecords implements
Closeable {
mjsax commented on code in PR #19669:
URL: https://github.com/apache/kafka/pull/19669#discussion_r2082807506
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -1647,7 +1648,7 @@ private Properties requiredConsumerConfigAndGro
rreddy-22 commented on code in PR #19539:
URL: https://github.com/apache/kafka/pull/19539#discussion_r2082577909
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -330,6 +334,17 @@ public synchronized void beginTransaction() {
rreddy-22 commented on code in PR #19539:
URL: https://github.com/apache/kafka/pull/19539#discussion_r2082582053
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1453,7 +1481,15 @@ public void handleResponse(AbstractResponse re
josefk31 commented on code in PR #19644:
URL: https://github.com/apache/kafka/pull/19644#discussion_r2082585404
##
tests/kafkatest/tests/core/reassign_partitions_test.py:
##
@@ -164,6 +167,14 @@ def test_reassign_partitions(self, bounce_brokers,
reassign_from_offset_zero, me
rreddy-22 commented on code in PR #19539:
URL: https://github.com/apache/kafka/pull/19539#discussion_r2082575771
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -760,6 +765,48 @@ public void sendOffsetsToTransaction(Map offs
}
}
jlprat opened a new pull request, #19665:
URL: https://github.com/apache/kafka/pull/19665
During PR https://github.com/apache/kafka/pull/19484 only the dependency was
updated but not the `LICENSE-binary` file. This fixes this misalignment.
--
This is an automated message from the Apac
[
https://issues.apache.org/jira/browse/KAFKA-13555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950476#comment-17950476
]
Bruno Cadonna commented on KAFKA-13555:
---
[~lorcanj] Thank you for your work on thi
cadonna commented on PR #19275:
URL: https://github.com/apache/kafka/pull/19275#issuecomment-2865928108
> Hi @cadonna Not yet, I am having some university exams and assignments to
complete, so could not focus on this for the past few weeks. But I'll make sure
this is ready by the end of thi
AndrewJSchofield merged PR #19647:
URL: https://github.com/apache/kafka/pull/19647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
apoorvmittal10 commented on code in PR #19661:
URL: https://github.com/apache/kafka/pull/19661#discussion_r2081188468
##
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java:
##
@@ -1170,7 +1169,7 @@ public void testSliceEmptyRecords() {
*/
@Par
Yunyung commented on code in PR #19658:
URL: https://github.com/apache/kafka/pull/19658#discussion_r2081198851
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##
@@ -4569,6 +4574,55 @@ public void testObserverFetchWithNoLocalId(boolean
withKip853Rpc) throw
AndrewJSchofield merged PR #19508:
URL: https://github.com/apache/kafka/pull/19508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
98 matches
Mail list logo