jsancio commented on code in PR #19644:
URL: https://github.com/apache/kafka/pull/19644#discussion_r2082505437
##########
tests/kafkatest/utils/util.py:
##########
@@ -168,7 +168,7 @@ def validate_delivery(acked, consumed,
idempotence_enabled=False, check_lost_dat
success = False
# Are there duplicates?
- if len(set(consumed)) != len(consumed):
+ if verify_duplicate_data and len(set(consumed)) != len(consumed):
Review Comment:
What do you think about moving this check to the `if idempotence_enabled`
line so that we don't fail the test but still print the duplicate record
message to the log?
##########
tests/kafkatest/tests/core/reassign_partitions_test.py:
##########
@@ -164,6 +167,14 @@ def test_reassign_partitions(self, bounce_brokers,
reassign_from_offset_zero, me
self.kafka, self.topic,
throughput=self.producer_throughput,
enable_idempotence=True,
Review Comment:
Did you consider just disabling the idempotent producer? This way we don't
need to change the other files: produce_consume_validate.py and util.py. I am
suggesting this because it minimized the changes that need to get reverted when
KAFKA-18905 if fixed.
I also think that disabling the idempotent producer should allow you to not
have to override the retries in the line below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
