cmccabe commented on code in PR #19586: URL: https://github.com/apache/kafka/pull/19586#discussion_r2082051224
########## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java: ########## @@ -63,6 +74,8 @@ public final class ControllerMetadataMetrics implements AutoCloseable { private final Optional<MetricsRegistry> registry; private final AtomicInteger fencedBrokerCount = new AtomicInteger(0); private final AtomicInteger activeBrokerCount = new AtomicInteger(0); + private final AtomicInteger controllerShutdownBrokerCount = new AtomicInteger(0); + private final Map<Integer, AtomicInteger> brokerRegistrationStates = new ConcurrentHashMap<>(); Review Comment: we need to remove these entries when a broker is removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org