TaiJuWu commented on code in PR #19662:
URL: https://github.com/apache/kafka/pull/19662#discussion_r2081756280
##########
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMetadataTest.scala:
##########
@@ -29,7 +29,6 @@ import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.ValueSource
import java.util.Optional
-
Review Comment:
Could you revert this change?
##########
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionLogTest.scala:
##########
@@ -114,14 +115,14 @@ class TransactionLogTest {
@Test
def testSerializeTransactionLogValueToHighestNonFlexibleVersion(): Unit = {
- val txnTransitMetadata = TxnTransitMetadata(1, 1, 1, 1, 1, 1000,
TransactionState.COMPLETE_COMMIT, mutable.Set.empty, 500, 500, TV_0)
+ val txnTransitMetadata = new TxnTransitMetadata(1, 1, 1, 1, 1, 1000,
TransactionState.COMPLETE_COMMIT, Collections.emptySet(), 500, 500, TV_0)
Review Comment:
Could you use `Set.of()` instead of `Collections.emptySet()`
##########
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionLogTest.scala:
##########
@@ -114,14 +115,14 @@ class TransactionLogTest {
@Test
def testSerializeTransactionLogValueToHighestNonFlexibleVersion(): Unit = {
- val txnTransitMetadata = TxnTransitMetadata(1, 1, 1, 1, 1, 1000,
TransactionState.COMPLETE_COMMIT, mutable.Set.empty, 500, 500, TV_0)
+ val txnTransitMetadata = new TxnTransitMetadata(1, 1, 1, 1, 1, 1000,
TransactionState.COMPLETE_COMMIT, Collections.emptySet(), 500, 500, TV_0)
val txnLogValueBuffer =
ByteBuffer.wrap(TransactionLog.valueToBytes(txnTransitMetadata, TV_0))
assertEquals(0, txnLogValueBuffer.getShort)
}
@Test
def testSerializeTransactionLogValueToFlexibleVersion(): Unit = {
- val txnTransitMetadata = TxnTransitMetadata(1, 1, 1, 1, 1, 1000,
TransactionState.COMPLETE_COMMIT, mutable.Set.empty, 500, 500, TV_2)
+ val txnTransitMetadata = new TxnTransitMetadata(1, 1, 1, 1, 1, 1000,
TransactionState.COMPLETE_COMMIT, Collections.emptySet(), 500, 500, TV_2)
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
