mjsax commented on code in PR #19669:
URL: https://github.com/apache/kafka/pull/19669#discussion_r2082807236
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -3425,6 +3441,7 @@ public void testAssignorNameConflict(GroupProtocol
groupProtocol) {
() -> newConsumer(configs, new StringDeserializer(), new
StringDeserializer()));
}
+ @SuppressWarnings("resource")
Review Comment:
Using try-with-resource makes the test fail, as calling `close()` runs into
an `InterruptedException`
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -3435,6 +3452,7 @@ public void testOffsetsForTimesTimeout(GroupProtocol
groupProtocol) {
);
}
+ @SuppressWarnings("resource")
Review Comment:
As above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
