Re: [PR] KAFKA-19135 Migrate initial IQ support for KIP-1071 from feature branch to trunk [kafka]

2025-04-29 Thread via GitHub
bbejeck merged PR #19588: URL: https://github.com/apache/kafka/pull/19588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-19135) Add IQ Support - move from feature branch

2025-04-29 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-19135. - Resolution: Fixed > Add IQ Support - move from feature branch >

Re: [PR] KAFKA-19135 Migrate initial IQ support for KIP-1071 from feature branch to trunk [kafka]

2025-04-29 Thread via GitHub
bbejeck commented on PR #19588: URL: https://github.com/apache/kafka/pull/19588#issuecomment-2840499322 Merged #19588 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] MINOR; Log message for unexpected buffer allocation [kafka]

2025-04-29 Thread via GitHub
FrankYang0529 commented on code in PR #19596: URL: https://github.com/apache/kafka/pull/19596#discussion_r2067638473 ## raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java: ## @@ -159,23 +160,26 @@ public static Path markForDelete(Path logDir, OffsetAndEpoch snapshotId)

[jira] [Commented] (KAFKA-18066) Misleading/mismatched StreamThread id in logging

2025-04-29 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948338#comment-17948338 ] Matthias J. Sax commented on KAFKA-18066: - Thanks for the ping [~bloku] – I did

Re: [PR] KAFKA-19139 Plugin#wrapInstance should use LinkedHashMap instead of Map [kafka]

2025-04-29 Thread via GitHub
frankvicky merged PR #19519: URL: https://github.com/apache/kafka/pull/19519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[jira] [Created] (KAFKA-19215) Handle share partition fetch lock cleanly in DelayedShareFetch to avoid a member incorrectly releasing a share partition's fetch lock

2025-04-29 Thread Abhinav Dixit (Jira)
Abhinav Dixit created KAFKA-19215: - Summary: Handle share partition fetch lock cleanly in DelayedShareFetch to avoid a member incorrectly releasing a share partition's fetch lock Key: KAFKA-19215 URL: https://iss

Re: [PR] KAFKA-18760: Deprecate Optional and return String from public Endpoint#listener [kafka]

2025-04-29 Thread via GitHub
frankvicky merged PR #19191: URL: https://github.com/apache/kafka/pull/19191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] KAFKA-19173: Add `Feature` for "streams" group [kafka]

2025-04-29 Thread via GitHub
mjsax merged PR #19509: URL: https://github.com/apache/kafka/pull/19509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-19173) Add `Feature` for streams groups

2025-04-29 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-19173. - Fix Version/s: 4.1.0 Resolution: Fixed > Add `Feature` for streams groups > -

Re: [PR] KAFKA-19073: add transactional ID pattern filter to ListTransactions [kafka]

2025-04-29 Thread via GitHub
jolshan commented on code in PR #19355: URL: https://github.com/apache/kafka/pull/19355#discussion_r2067601848 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2472,7 +2472,17 @@ class KafkaApis(val requestChannel: RequestChannel, val filteredProducerIds = listT

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-29 Thread via GitHub
mjsax commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2067569227 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig { /** r

[jira] [Commented] (KAFKA-19209) "index.interval.bytes" config doc should also mention time index

2025-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948321#comment-17948321 ] ASF GitHub Bot commented on KAFKA-19209: shmily7829 commented on code in PR #686

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-29 Thread via GitHub
Yunyung commented on PR #19595: URL: https://github.com/apache/kafka/pull/19595#issuecomment-2840596590 Thanks for the PR. I left just one minor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-29 Thread via GitHub
Yunyung commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2067714092 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -100,7 +100,7 @@ public class ProducerConfig extends AbstractConfig {

Re: [PR] KAFKA-19073: add transactional ID pattern filter to ListTransactions [kafka]

2025-04-29 Thread via GitHub
CalvinConfluent commented on code in PR #19355: URL: https://github.com/apache/kafka/pull/19355#discussion_r2067560540 ## clients/src/main/resources/common/message/ListTransactionsRequest.json: ## @@ -30,6 +32,9 @@ }, { "name": "DurationFilter", "type": "int64", "versi

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

2025-04-29 Thread via GitHub
mjsax merged PR #19446: URL: https://github.com/apache/kafka/pull/19446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

2025-04-29 Thread via GitHub
mjsax commented on PR #19446: URL: https://github.com/apache/kafka/pull/19446#issuecomment-2840451662 Thanks for the PR. Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

2025-04-29 Thread via GitHub
wernerdv commented on PR #19446: URL: https://github.com/apache/kafka/pull/19446#issuecomment-2840827675 @mjsax @frankvicky @FrankYang0529 Thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-19008 Remove scala version from artifacts [kafka]

2025-04-29 Thread via GitHub
github-actions[bot] commented on PR #19241: URL: https://github.com/apache/kafka/pull/19241#issuecomment-2840702811 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19140 ConnectAssignor#performAssignment parameter can be replace to ConnectProtocolCompatibility [kafka]

2025-04-29 Thread via GitHub
github-actions[bot] commented on PR #19476: URL: https://github.com/apache/kafka/pull/19476#issuecomment-2840702695 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP] JWT bearer grant type support [kafka]

2025-04-29 Thread via GitHub
github-actions[bot] commented on PR #18912: URL: https://github.com/apache/kafka/pull/18912#issuecomment-2840702907 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [KAFKA-15579] Create GetReplicaLogInfo* handlers [kafka]

2025-04-29 Thread via GitHub
github-actions[bot] commented on PR #18670: URL: https://github.com/apache/kafka/pull/18670#issuecomment-2840722141 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-29 Thread via GitHub
jolshan commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2840337435 @junrao build is green now! I noticed you didn't hit the approve button on GH, so I will wait to merge just to double check. -- This is an automated message from the Apache Git Service.

[jira] [Created] (KAFKA-19214) Clean up use of Optionals in RequestManagers.entries()

2025-04-29 Thread Kirk True (Jira)
Kirk True created KAFKA-19214: - Summary: Clean up use of Optionals in RequestManagers.entries() Key: KAFKA-19214 URL: https://issues.apache.org/jira/browse/KAFKA-19214 Project: Kafka Issue Type:

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-29 Thread via GitHub
jolshan merged PR #15968: URL: https://github.com/apache/kafka/pull/15968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-16758) Extend Consumer#close with option to leave the group or not

2025-04-29 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948302#comment-17948302 ] Matthias J. Sax commented on KAFKA-16758: - [~frankvicky] Anything missing to com

Re: [PR] MINOR: improve JavaDocs for consumer CloseOptions [kafka]

2025-04-29 Thread via GitHub
mjsax merged PR #19546: URL: https://github.com/apache/kafka/pull/19546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-19042: [7/N] Move PlaintextConsumerPollTest to client-integration-tests module [kafka]

2025-04-29 Thread via GitHub
m1a2st commented on code in PR #19582: URL: https://github.com/apache/kafka/pull/19582#discussion_r2067941355 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerPollTest.java: ## @@ -0,0 +1,686 @@ +/* + * Licensed to the Apache

[jira] [Resolved] (KAFKA-18288) Add support kafka-streams-groups.sh --describe

2025-04-29 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi resolved KAFKA-18288. -- Resolution: Fixed > Add support kafka-streams-groups.sh --describe > -

Re: [PR] KAFKA-19205: inconsistent result of beginningOffsets/endoffset between classic and async consumer with 0 timeout [kafka]

2025-04-29 Thread via GitHub
xijiu commented on code in PR #19578: URL: https://github.com/apache/kafka/pull/19578#discussion_r2067723338 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ListOffsetsEvent.java: ## @@ -47,13 +46,12 @@ public ListOffsetsEvent(Map timestampToSearch,

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-29 Thread via GitHub
mjsax commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2067567268 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig { /** r

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-29 Thread via GitHub
mjsax commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2067568336 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig { /** r

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-29 Thread via GitHub
mjsax commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2067568767 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -274,11 +274,12 @@ public class ProducerConfig extends AbstractConfig { /** r

[jira] [Resolved] (KAFKA-16758) Extend Consumer#close with option to leave the group or not

2025-04-29 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi resolved KAFKA-16758. - Resolution: Fixed > Extend Consumer#close with option to leave the group or not > --

[jira] [Commented] (KAFKA-16758) Extend Consumer#close with option to leave the group or not

2025-04-29 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948331#comment-17948331 ] TengYao Chi commented on KAFKA-16758: - I forgot to resolve this one 😅 Thanks for th

Re: [PR] MINOR: Cleanup build.gradle unused import and update the deprecated `archivePath` [kafka]

2025-04-29 Thread via GitHub
m1a2st commented on PR #18537: URL: https://github.com/apache/kafka/pull/18537#issuecomment-2838112188 Thanks for @apoorvmittal10 reminder, update the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-16894: Define feature to enable share groups [kafka]

2025-04-29 Thread via GitHub
AndrewJSchofield commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2065960167 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -112,7 +112,22 @@ public enum MetadataVersion { // // Ena

Re: [PR] KAFKA-19042: [7/N] Move PlaintextConsumerPollTest to client-integration-tests module [kafka]

2025-04-29 Thread via GitHub
frankvicky commented on code in PR #19582: URL: https://github.com/apache/kafka/pull/19582#discussion_r2065922081 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apac

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-29 Thread via GitHub
chia7712 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066249125 ## gradle/dependencies.gradle: ## @@ -147,6 +148,7 @@ libs += [ caffeine: "com.github.ben-manes.caffeine:caffeine:$versions.caffeine", classgraph: "io.github.cla

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-29 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066325978 ## gradle/dependencies.gradle: ## @@ -147,6 +148,7 @@ libs += [ caffeine: "com.github.ben-manes.caffeine:caffeine:$versions.caffeine", classgraph: "io.githu

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-29 Thread via GitHub
chia7712 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066288123 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -209,4 +221,90 @@ void validateOffsetFetch( default boolean shouldExpire()

Re: [PR] KAFKA-19135 Migrate initial IQ support for KIP-1071 from feature branch to trunk [kafka]

2025-04-29 Thread via GitHub
bbejeck commented on code in PR #19588: URL: https://github.com/apache/kafka/pull/19588#discussion_r2066340472 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2093,6 +2095,25 @@ private List createStreamsGroupHeartb

Re: [PR] MINOR: Cleanup build.gradle unused import and update the deprecated `archivePath` [kafka]

2025-04-29 Thread via GitHub
apoorvmittal10 merged PR #18537: URL: https://github.com/apache/kafka/pull/18537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-29 Thread via GitHub
chia7712 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066122048 ## gradle/dependencies.gradle: ## @@ -147,6 +148,7 @@ libs += [ caffeine: "com.github.ben-manes.caffeine:caffeine:$versions.caffeine", classgraph: "io.github.cla

[jira] [Updated] (KAFKA-19174) Gradle version upgrade 8 -->> 9

2025-04-29 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19174: --- Description: *_Note:_* at the moment Gradle 9 is available as a milestone version on

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-29 Thread via GitHub
chia7712 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066374101 ## gradle/dependencies.gradle: ## @@ -147,6 +148,7 @@ libs += [ caffeine: "com.github.ben-manes.caffeine:caffeine:$versions.caffeine", classgraph: "io.github.cla

Re: [PR] KAFKA-19181-2: Increased offsets.commit.timeout.ms value as a temporary solution for the system test test_broker_failure failure [kafka]

2025-04-29 Thread via GitHub
AndrewJSchofield merged PR #19593: URL: https://github.com/apache/kafka/pull/19593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19135 Migrate initial IQ support for KIP-1071 from feature branch to trunk [kafka]

2025-04-29 Thread via GitHub
bbejeck commented on code in PR #19588: URL: https://github.com/apache/kafka/pull/19588#discussion_r2066388626 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/EndpointToPartitionsManager.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apach

Re: [PR] KAFKA-17541:[1/2] Improve handling of delivery count [kafka]

2025-04-29 Thread via GitHub
AndrewJSchofield commented on code in PR #19430: URL: https://github.com/apache/kafka/pull/19430#discussion_r2066391545 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2000,6 +1998,29 @@ public void testShareCon

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-29 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066410256 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -209,4 +221,90 @@ void validateOffsetFetch( default boolean shouldExp

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-29 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066016813 ## gradle/dependencies.gradle: ## @@ -147,6 +148,7 @@ libs += [ caffeine: "com.github.ben-manes.caffeine:caffeine:$versions.caffeine", classgraph: "io.githu

[jira] [Assigned] (KAFKA-19201) Handle deletion of a topic which has initialised share-group state

2025-04-29 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan reassigned KAFKA-19201: --- Assignee: Sushant Mahajan (was: Sushant Mahajan) > Handle deletion of a topic whic

[jira] [Commented] (KAFKA-19201) Handle deletion of a topic which has initialised share-group state

2025-04-29 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948143#comment-17948143 ] Sushant Mahajan commented on KAFKA-19201: - https://github.com/apache/kafka/pull/

[PR] KAFKA-19181-2: Increased offsets.commit.timeout.ms value as a temporary solution for the system test test_broker_failure failure [kafka]

2025-04-29 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19593: URL: https://github.com/apache/kafka/pull/19593 Upon investigations for the failure of the system test test_broker_failure, it was found there were situations where the writing of records to the consumer_offsets topic was taking longer than

[jira] [Assigned] (KAFKA-19204) Timeouts in coordinator runtime operations can break share group initialization and deletion

2025-04-29 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan reassigned KAFKA-19204: --- Assignee: Sushant Mahajan (was: Sushant Mahajan) > Timeouts in coordinator runtime

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_smoke_test.py [kafka]

2025-04-29 Thread via GitHub
lucasbru merged PR #19560: URL: https://github.com/apache/kafka/pull/19560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (1/n) [kafka]

2025-04-29 Thread via GitHub
sjhajharia commented on PR #19380: URL: https://github.com/apache/kafka/pull/19380#issuecomment-2838920475 Hey @chia7712 Gentle reminder on the above PR. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-29 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066476357 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -209,4 +221,90 @@ void validateOffsetFetch( default boolean shouldExp

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-29 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066485713 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -209,4 +221,90 @@ void validateOffsetFetch( default boolean shouldExp

[jira] [Updated] (KAFKA-19020) Handle strict max fetch records in share fetch

2025-04-29 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-19020: -- Fix Version/s: 4.2.0 > Handle strict max fetch records in share fetch > --

Re: [PR] MINOR: Update apacheds to 2.0.0.AM27 [kafka]

2025-04-29 Thread via GitHub
tinaselenge commented on PR #19565: URL: https://github.com/apache/kafka/pull/19565#issuecomment-2838292051 Thanks @showuon. I had a look and apacheds-protocol-kerberos seems to be the only apacheds library that doesn't have 2.0.0.AM27 release. It has 2.0.0.AM26 (from 2020) so we could set

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-29 Thread via GitHub
dajac commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066160108 ## gradle/dependencies.gradle: ## @@ -147,6 +148,7 @@ libs += [ caffeine: "com.github.ben-manes.caffeine:caffeine:$versions.caffeine", classgraph: "io.github.classg

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-29 Thread via GitHub
dajac commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066162858 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -209,4 +221,90 @@ void validateOffsetFetch( default boolean shouldExpire() {

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-04-29 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066166230 ## gradle/dependencies.gradle: ## @@ -147,6 +148,7 @@ libs += [ caffeine: "com.github.ben-manes.caffeine:caffeine:$versions.caffeine", classgraph: "io.githu

Re: [PR] MINOR: support ipv6 in ducker-ak [kafka]

2025-04-29 Thread via GitHub
Yunyung commented on code in PR #19537: URL: https://github.com/apache/kafka/pull/19537#discussion_r2065833690 ## tests/docker/ducker-ak: ## @@ -412,14 +421,23 @@ attempting to start new ones." exec 3<> "${ducker_dir}/build/node_hosts" for n in $(seq -f %02g 1 ${num_no

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

2025-04-29 Thread via GitHub
wernerdv commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2065737402 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/CopartitionedTopicsEnforcerTest.java: ## @@ -124,8 +124,8 @@ public void shouldThrowAnExceptionI

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

2025-04-29 Thread via GitHub
wernerdv commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2065760741 ## streams/src/test/java/org/apache/kafka/streams/tests/StreamsNamedRepartitionTest.java: ## @@ -55,7 +55,7 @@ public static void main(final String[] args) throws Exce

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

2025-04-29 Thread via GitHub
wernerdv commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2065760741 ## streams/src/test/java/org/apache/kafka/streams/tests/StreamsNamedRepartitionTest.java: ## @@ -55,7 +55,7 @@ public static void main(final String[] args) throws Exce

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

2025-04-29 Thread via GitHub
wernerdv commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2065737402 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/CopartitionedTopicsEnforcerTest.java: ## @@ -124,8 +124,8 @@ public void shouldThrowAnExceptionI

Re: [PR] KAFKA-16718-4/n: ShareGroupCommand changes for DeleteShareGroupOffsets admin call [kafka]

2025-04-29 Thread via GitHub
AndrewJSchofield commented on code in PR #19587: URL: https://github.com/apache/kafka/pull/19587#discussion_r2065782916 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ShareGroupCommandTest.java: ## @@ -612,6 +615,189 @@ public void testGroupStatesFromString() {

Re: [PR] MINOR: Small cleanups in streams tests [kafka]

2025-04-29 Thread via GitHub
wernerdv commented on code in PR #19446: URL: https://github.com/apache/kafka/pull/19446#discussion_r2065795964 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java: ## @@ -509,24 +507,30 @@ public void shouldReturnSameMetricI

Re: [PR] KAFKA-15283:[1/N] Client support for OffsetCommit with topic ID [kafka]

2025-04-29 Thread via GitHub
DL1231 commented on PR #19577: URL: https://github.com/apache/kafka/pull/19577#issuecomment-2837951424 @dajac, PTAL when you get a chance, thanks in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-19170 Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module [kafka]

2025-04-29 Thread via GitHub
chia7712 commented on code in PR #19528: URL: https://github.com/apache/kafka/pull/19528#discussion_r2065838682 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java: ## @@ -0,0 +1,188 @@ +/* + * Licensed to the A

Re: [PR] KAFKA-19082: [2/4] Add preparedTxnState class to Kafka Producer (KIP-939) [kafka]

2025-04-29 Thread via GitHub
jolshan merged PR #19470: URL: https://github.com/apache/kafka/pull/19470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-29 Thread via GitHub
jolshan commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2839862971 I triggered the rerun 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-19073: add transactional ID pattern filter to ListTransactions [kafka]

2025-04-29 Thread via GitHub
chia7712 commented on code in PR #19355: URL: https://github.com/apache/kafka/pull/19355#discussion_r2066833385 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListTransactionsHandler.java: ## @@ -75,6 +75,9 @@ public ListTransactionsRequest.Builder buildBatche

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_broker_bounce_test.py [kafka]

2025-04-29 Thread via GitHub
bbejeck commented on PR #19584: URL: https://github.com/apache/kafka/pull/19584#issuecomment-283935 @lucasbru can you add the link to passing system test in this PR for history? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-29 Thread via GitHub
mjsax commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2067041079 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -88,8 +88,9 @@ public class CommonClientConfigs { "If provided, the backoff per

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-29 Thread via GitHub
mjsax commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2067043149 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -88,8 +88,9 @@ public class CommonClientConfigs { "If provided, the backoff per

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-29 Thread via GitHub
mjsax commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2067051594 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -276,6 +276,7 @@ public class ProducerConfig extends AbstractConfig { public st

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-29 Thread via GitHub
mjsax commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2067052847 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -88,8 +88,9 @@ public class CommonClientConfigs { "If provided, the backoff per

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-29 Thread via GitHub
lianetm commented on code in PR #19595: URL: https://github.com/apache/kafka/pull/19595#discussion_r2067065924 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -276,6 +276,7 @@ public class ProducerConfig extends AbstractConfig { public

[jira] [Commented] (KAFKA-19209) "index.interval.bytes" config doc should also mention time index

2025-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948224#comment-17948224 ] ASF GitHub Bot commented on KAFKA-19209: shmily7829 opened a new pull request, #

Re: [PR] KAFKA-16894: Define feature to enable share groups [kafka]

2025-04-29 Thread via GitHub
AndrewJSchofield commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2066998073 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -112,7 +112,22 @@ public enum MetadataVersion { // // Ena

[jira] [Updated] (KAFKA-19182) Move SchedulerTest to server module

2025-04-29 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uladzislau Blok updated KAFKA-19182: Description: # Rewrite SchedulerTest with java # Move it to server-common module was:

[jira] [Updated] (KAFKA-19182) Move SchedulerTest to server module

2025-04-29 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uladzislau Blok updated KAFKA-19182: Description: # Rewrite SchedulerTest with java # Move it to server module         wa

Re: [PR] KAFKA-19212: Fix ElectionWasClean bug when partition reassignment completes [kafka]

2025-04-29 Thread via GitHub
ahuang98 commented on code in PR #19590: URL: https://github.com/apache/kafka/pull/19590#discussion_r2066930477 ## metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java: ## @@ -165,8 +165,20 @@ public PartitionRegistration build() { public final int le

Re: [PR] KAFKA-16894: Define feature to enable share groups [kafka]

2025-04-29 Thread via GitHub
jolshan commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2066993014 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -112,7 +112,22 @@ public enum MetadataVersion { // // Enables ELR

[jira] [Commented] (KAFKA-19209) "index.interval.bytes" config doc should also mention time index

2025-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948239#comment-17948239 ] ASF GitHub Bot commented on KAFKA-19209: brandboat commented on code in PR #686:

[PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-04-29 Thread via GitHub
lianetm opened a new pull request, #19595: URL: https://github.com/apache/kafka/pull/19595 Improve docs for retries config, mainly to clarify the expected behaviour on retries=0 Also remove unused funcs and fix typo. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-19135 Migrate initial IQ support for KIP-1071 from feature branch to trunk [kafka]

2025-04-29 Thread via GitHub
bbejeck commented on code in PR #19588: URL: https://github.com/apache/kafka/pull/19588#discussion_r2066388626 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/EndpointToPartitionsManager.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apach

Re: [PR] KAFKA-19205: inconsistent result of beginningOffsets/endoffset between classic and async consumer with 0 timeout [kafka]

2025-04-29 Thread via GitHub
chia7712 commented on code in PR #19578: URL: https://github.com/apache/kafka/pull/19578#discussion_r206008 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ListOffsetsEvent.java: ## @@ -47,13 +46,12 @@ public ListOffsetsEvent(Map timestampToSearc

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-29 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2066715622 ## clients/src/test/java/org/apache/kafka/common/requests/ProduceRequestTest.java: ## @@ -102,13 +103,36 @@ public void testBuildWithCurrentMessageFormat() { P

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-29 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2066715280 ## clients/src/test/java/org/apache/kafka/common/requests/ProduceRequestTest.java: ## @@ -54,7 +55,7 @@ public void shouldBeFlaggedAsTransactionalWhenTransactionalReco

[jira] [Updated] (KAFKA-19213) Kafka java client ignores default properties

2025-04-29 Thread Pas Filip (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pas Filip updated KAFKA-19213: -- Description: Using Kafka Java client, when creating a kafka consumer/producer using a properties obje

[jira] [Updated] (KAFKA-19213) Kafka java client ignores default properties

2025-04-29 Thread Pas Filip (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pas Filip updated KAFKA-19213: -- Affects Version/s: 4.0.0 3.0.0 2.0.0 > Kafka java client

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_broker_bounce_test.py [kafka]

2025-04-29 Thread via GitHub
lucasbru merged PR #19584: URL: https://github.com/apache/kafka/pull/19584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19073: add transactional ID pattern filter to ListTransactions [kafka]

2025-04-29 Thread via GitHub
CalvinConfluent commented on code in PR #19355: URL: https://github.com/apache/kafka/pull/19355#discussion_r2066907375 ## clients/src/main/java/org/apache/kafka/common/requests/ListTransactionsRequest.java: ## @@ -38,6 +38,10 @@ public ListTransactionsRequest build(short version

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_broker_bounce_test.py [kafka]

2025-04-29 Thread via GitHub
lucasbru commented on PR #19584: URL: https://github.com/apache/kafka/pull/19584#issuecomment-2839477549 @bbejeck I suppose only the results can be accessed http://ducktape-open-source-results.confluent.io.s3-website-us-west-2.amazonaws.com/confluent-open-source-kafka-branch-builder-system-t

  1   2   >