dajac commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2066162858
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##########
@@ -209,4 +221,90 @@ void validateOffsetFetch(
default boolean shouldExpire() {
return true;
}
+
+ /**
+ * The magic byte used to identify the version of topic hash function.
+ */
+ byte TOPIC_HASH_MAGIC_BYTE = 0x00;
+ XXHash64 LZ4_HASH_INSTANCE = XXHashFactory.fastestInstance().hash64();
Review Comment:
Would it be possible to put those and the new methods to a separate class?
Having them in `Group` is weird because it won't be used by all the group types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
