lianetm commented on code in PR #19595:
URL: https://github.com/apache/kafka/pull/19595#discussion_r2067065924
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -276,6 +276,7 @@ public class ProducerConfig extends AbstractConfig {
public static final String RETRIES_CONFIG =
CommonClientConfigs.RETRIES_CONFIG;
private static final String RETRIES_DOC = "Setting a value greater than
zero will cause the client to resend any record whose send fails with a
potentially transient error."
+ " Note that this retry is no different than if the client resent
the record upon receiving the error."
+ + " Setting a value of zero will make that transient errors won't
be retried, and will be propagated to the application to be handled."
Review Comment:
yeah, let's get there. The delivery timeout config has several applications
really, but related to retry, the point is that it's a time boundary for
retries. So its relevant when using retries > 0 I expect (technically it
applies to both, but if we have retries=0 means no retry, so the time boundary
for retries is pointless)
Makes sense? let me group the sentence better with this in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
