chia7712 commented on code in PR #19578:
URL: https://github.com/apache/kafka/pull/19578#discussion_r2066666008
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ListOffsetsEvent.java:
##########
@@ -47,13 +46,12 @@ public ListOffsetsEvent(Map<TopicPartition, Long>
timestampToSearch,
/**
* Build result representing that no offsets were found as part of the
current event.
*
- * @return Map containing all the partitions the event was trying to get
offsets for, and
- * null {@link OffsetAndTimestamp} as value
+ * @return empty map
*/
public <T> Map<TopicPartition, T> emptyResults() {
- Map<TopicPartition, T> result = new HashMap<>();
- timestampsToSearch.keySet().forEach(tp -> result.put(tp, null));
- return result;
+ // It is used to align with classic consumer. When the timeout == 0,
the classic consumer will return an empty map.
+ // Therefore, the AsyncKafkaConsumer needs to be consistent with it.
+ return Map.of();
Review Comment:
Maybe we can inline this method. Additionally, we should return `HashMap` as
classic consumer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
