dajac commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2066160108
########## gradle/dependencies.gradle: ########## @@ -147,6 +148,7 @@ libs += [ caffeine: "com.github.ben-manes.caffeine:caffeine:$versions.caffeine", classgraph: "io.github.classgraph:classgraph:$versions.classgraph", commonsValidator: "commons-validator:commons-validator:$versions.commonsValidator", + guava: "com.google.guava:guava:$versions.guava", Review Comment: > IIRC, the lz4-java is not maintained anymore, so not sure whether the code maintaining is a risk. > > > I also wonder what is the impact of putting all the data to a byte array before hashing it. Do you have thoughts on this? > > I suggest that `EventProcessorThread` can leverage `GrowableBufferSupplier` to reuse buffer as much as possible. Additionally, `Group#computeTopicHashin` should use `ByteBufferOutputStream` to generate the bytes array, as `ByteBufferOutputStream#buffer#array` can avoid extra array copy like `ByteArrayOutputStream#toByteArray` I agree with using a BufferSupplier in order to reuse buffers. However, EventProcessorThread may be too low level to hold it. Having it in Shard may be enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
