[jira] [Assigned] (KAFKA-19068) Eliminate the duplicate type check in creating ControlRecord

2025-04-01 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Guo reassigned KAFKA-19068: Assignee: Nick Guo (was: Chia-Ping Tsai) > Eliminate the duplicate type check in creating Contro

[jira] [Created] (KAFKA-19070) Adding task number to the user provided client id (via consumer.override.client.id) to ensure each consumer has a unique client ID to avoid metric registration conflicts

2025-04-01 Thread Pritam Kumar (Jira)
Pritam Kumar created KAFKA-19070: Summary: Adding task number to the user provided client id (via consumer.override.client.id) to ensure each consumer has a unique client ID to avoid metric registration conflicts. Key: KAFKA-1907

[jira] [Assigned] (KAFKA-19069) DumpLogSegments does not dump the LEADER_CHANGE record

2025-04-01 Thread Cheng Yi Chang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Yi Chang reassigned KAFKA-19069: -- Assignee: Cheng Yi Chang (was: Chia-Ping Tsai) > DumpLogSegments does not dump the L

Re: [PR] KAFKA-19070:: Adding task number to user provided client id to ensure each consumer has a unique client ID to avoid metric registration conflicts. [kafka]

2025-04-01 Thread via GitHub
kumarpritam863 commented on PR #19341: URL: https://github.com/apache/kafka/pull/19341#issuecomment-2769651220 @C0urante can you please review this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Created] (KAFKA-19069) DumpLogSegments does not dump the LEADER_CHANGE record

2025-04-01 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19069: -- Summary: DumpLogSegments does not dump the LEADER_CHANGE record Key: KAFKA-19069 URL: https://issues.apache.org/jira/browse/KAFKA-19069 Project: Kafka Is

[jira] [Updated] (KAFKA-19070) Adding task number to the user provided client id (via consumer.override.client.id) to ensure each consumer has a unique client ID to avoid metric registration conflicts

2025-04-01 Thread Pritam Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritam Kumar updated KAFKA-19070: - Fix Version/s: 4.1.0 (was: 4.0.1) > Adding task number to the user provid

[jira] [Assigned] (KAFKA-18193) Kafka Streams `CloseOptions` should not have a public constructor

2025-04-01 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18193: --- Assignee: 黃竣陽 (was: TengYao Chi) > Kafka Streams `CloseOptions` should not have a public c

[PR] KAFKA-19070:: Adding task number to user provided client id to ensure each consumer has a unique client ID to avoid metric registration conflicts. [kafka]

2025-04-01 Thread via GitHub
kumarpritam863 opened a new pull request, #19341: URL: https://github.com/apache/kafka/pull/19341 **What** This PR updates the behavior of client.id assignment when a user provides a custom value via override configs in Kafka Connect. **Why** Currently, if a user overrides the c

Re: [PR] MINOR: Make coordinator runtime inner classes static [kafka]

2025-04-01 Thread via GitHub
dajac merged PR #19332: URL: https://github.com/apache/kafka/pull/19332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Cleanup test-common-runtime module [kafka]

2025-04-01 Thread via GitHub
chia7712 commented on code in PR #19305: URL: https://github.com/apache/kafka/pull/19305#discussion_r2023051736 ## test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/junit/ClusterTestExtensions.java: ## @@ -194,14 +194,11 @@ private TestTemplateInvocation

[jira] [Assigned] (KAFKA-19065) Cleanup canUseTopicIds

2025-04-01 Thread xuanzhang gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuanzhang gong reassigned KAFKA-19065: -- Assignee: xuanzhang gong (was: Chia-Ping Tsai) > Cleanup canUseTopicIds > --

[jira] [Assigned] (KAFKA-17694) Migrate SaslClientsWithInvalidCredentialsTest to new test infra

2025-04-01 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-17694: - Assignee: PoAn Yang (was: Ming-Yen Chung) > Migrate SaslClientsWithInvalidCredentialsTest to n

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-01 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2022439069 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2504,205 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-01 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2022439069 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2504,205 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] MINOR: Remove dead code `maybeWarnIfOversizedRecords` [kafka]

2025-04-01 Thread via GitHub
chia7712 commented on code in PR #19316: URL: https://github.com/apache/kafka/pull/19316#discussion_r2022446672 ## core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala: ## @@ -203,7 +203,7 @@ class RemoteLeaderEndPoint(logPrefix: String, None } else { v

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

2025-04-01 Thread via GitHub
edoardocomar commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2768825030 in short, my thinking is that `@ClusterTestThreadLeakIgnore` is no more "API" than `@ClusterTest` is -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-01 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2022231678 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,241 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] MINOR: Remove dead code `maybeWarnIfOversizedRecords` [kafka]

2025-04-01 Thread via GitHub
ijuma merged PR #19316: URL: https://github.com/apache/kafka/pull/19316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Created] (KAFKA-19066) JDK 24 support

2025-04-01 Thread Jira
Lovro Pandžić created KAFKA-19066: - Summary: JDK 24 support Key: KAFKA-19066 URL: https://issues.apache.org/jira/browse/KAFKA-19066 Project: Kafka Issue Type: Bug Reporter: Lovro

[jira] [Created] (KAFKA-19067) AsyncKafkaConsumer may return stale fetch result after seek operation

2025-04-01 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-19067: - Summary: AsyncKafkaConsumer may return stale fetch result after seek operation Key: KAFKA-19067 URL: https://issues.apache.org/jira/browse/KAFKA-19067 Project: Kafka

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-04-01 Thread via GitHub
stanislavkozlovski commented on code in PR #19336: URL: https://github.com/apache/kafka/pull/19336#discussion_r2022633565 ## docs/ops.html: ## @@ -4026,13 +4026,14 @@ Broker Configurations -By default, Kafka server will not enable tiered storage feature. remote.log.storage.s

[jira] [Assigned] (KAFKA-12715) ACL authentication, Host field support IP network segment

2025-04-01 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-12715: - Assignee: Jaideep Cuttamanchi (was: loboxu) > ACL authentication, Host field support IP networ

Re: [PR] KAFKA-19062: Port changes from KAFKA-18645 to share-consumers [kafka]

2025-04-01 Thread via GitHub
AndrewJSchofield commented on code in PR #19335: URL: https://github.com/apache/kafka/pull/19335#discussion_r2022348467 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -250,6 +251,7 @@ private enum AcknowledgementMode {

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-04-01 Thread via GitHub
frankvicky commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2022531429 ## clients/src/main/java/org/apache/kafka/common/requests/ShareFetchResponse.java: ## @@ -156,6 +163,23 @@ public static int recordsSize(ShareFetchResponseData.Part

[jira] [Commented] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-04-01 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940044#comment-17940044 ] Jialun Peng commented on KAFKA-19048: - Hello [~junrao] , [~cmccabe_impala_fa3f]   Y

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-04-01 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2022176927 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java: ## @@ -2905,4 +2729,48 @@ public void add(BackgroundEvent

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-01 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2022231678 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,241 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

[PR] Port changes from KAFKA-18645 to share-consumers [kafka]

2025-04-01 Thread via GitHub
ShivsundarR opened a new pull request, #19335: URL: https://github.com/apache/kafka/pull/19335 https://issues.apache.org/jira/browse/KAFKA-19062 After https://github.com/apache/kafka/commit/66363160c5e4460d9be27afa21c103a56f7428bc , we handle the close timeout in `AsyncKafkaConsumer`

[PR] MINOR: Accept Throwables in DeferredEventQueue.failAll [kafka]

2025-04-01 Thread via GitHub
squah-confluent opened a new pull request, #19337: URL: https://github.com/apache/kafka/pull/19337 DeferredEvents take a Throwable and not an Exception. For consistency, DeferredEventQueue.failAll should also accept a Throwable. -- This is an automated message from the Apache Git Se

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-01 Thread via GitHub
apoorvmittal10 commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2022495006 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2504,205 @@ private long startOffsetDuringInitialization(long partitionDataStartOff

Re: [PR] KAFKA-19018,KAFKA-19063: Implement maxRecords and acquisition lock timeout in share fetch request and response resp. [kafka]

2025-04-01 Thread via GitHub
AndrewJSchofield commented on code in PR #19334: URL: https://github.com/apache/kafka/pull/19334#discussion_r2022358524 ## clients/src/main/resources/common/message/ShareFetchResponse.json: ## @@ -39,6 +39,8 @@ "about": "The top-level response error code." }, { "name

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-04-01 Thread via GitHub
AndrewJSchofield merged PR #19295: URL: https://github.com/apache/kafka/pull/19295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: Remove dead code `maybeWarnIfOversizedRecords` [kafka]

2025-04-01 Thread via GitHub
ijuma commented on code in PR #19316: URL: https://github.com/apache/kafka/pull/19316#discussion_r2022835628 ## core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala: ## @@ -203,7 +203,7 @@ class RemoteLeaderEndPoint(logPrefix: String, None } else { val

Re: [PR] KAFKA-19004:Move DelayedDeleteRecords to server-common module [kafka]

2025-04-01 Thread via GitHub
gongxuanzhang commented on code in PR #19226: URL: https://github.com/apache/kafka/pull/19226#discussion_r2022688061 ## server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedDeleteRecords.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] KAFKA-18796-2: Corrected the check for acquisition lock timeout in Sh… [kafka]

2025-04-01 Thread via GitHub
AndrewJSchofield merged PR #19338: URL: https://github.com/apache/kafka/pull/19338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: Remove dead code `maybeWarnIfOversizedRecords` [kafka]

2025-04-01 Thread via GitHub
ijuma commented on code in PR #19316: URL: https://github.com/apache/kafka/pull/19316#discussion_r2022835628 ## core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala: ## @@ -203,7 +203,7 @@ class RemoteLeaderEndPoint(logPrefix: String, None } else { val

Re: [PR] MINOR: Remove dead code `maybeWarnIfOversizedRecords` [kafka]

2025-04-01 Thread via GitHub
ijuma commented on code in PR #19316: URL: https://github.com/apache/kafka/pull/19316#discussion_r2022845619 ## core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala: ## @@ -203,7 +203,7 @@ class RemoteLeaderEndPoint(logPrefix: String, None } else { val

[jira] [Created] (KAFKA-19065) Cleanup canUseTopicIds

2025-04-01 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19065: -- Summary: Cleanup canUseTopicIds Key: KAFKA-19065 URL: https://issues.apache.org/jira/browse/KAFKA-19065 Project: Kafka Issue Type: Improvement

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-04-01 Thread via GitHub
kamalcph commented on code in PR #19336: URL: https://github.com/apache/kafka/pull/19336#discussion_r2022646920 ## docs/ops.html: ## @@ -4169,6 +4170,7 @@ Deleting tiered storage enabled topics is required before disabling tiered storage at the broker level Review Comment:

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-04-01 Thread via GitHub
kamalcph commented on code in PR #19336: URL: https://github.com/apache/kafka/pull/19336#discussion_r2022640703 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -220,7 +223,9 @@ public class ConsumerConfig extends AbstractConfig {

Re: [PR] KAFKA-19018,KAFKA-19063: Implement maxRecords and acquisition lock timeout in share fetch request and response resp. [kafka]

2025-04-01 Thread via GitHub
AndrewJSchofield merged PR #19334: URL: https://github.com/apache/kafka/pull/19334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-04-01 Thread via GitHub
stanislavkozlovski commented on PR #19336: URL: https://github.com/apache/kafka/pull/19336#issuecomment-2768982520 I was never able to find the GA release notes :( The docs are so buried. Added the info to the limitations. Additionally, I: 1. edited the KIP to mention its GA

[jira] [Resolved] (KAFKA-19018) Send acquisition time in Share Fetch Response

2025-04-01 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19018. -- Resolution: Fixed > Send acquisition time in Share Fetch Response > --

[jira] [Resolved] (KAFKA-19063) Send MaxRecords in share fetch request

2025-04-01 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19063. -- Fix Version/s: 4.1.0 Resolution: Fixed > Send MaxRecords in share fetch request

[jira] [Updated] (KAFKA-19016) Update retention behaviour of share groups to retain them forever

2025-04-01 Thread Chirag Wadhwa (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chirag Wadhwa updated KAFKA-19016: -- Summary: Update retention behaviour of share groups to retain them forever (was: Validate ret

[jira] [Resolved] (KAFKA-18940) Fix uncleanLeaderElection metric due to ELR election

2025-04-01 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-18940. Resolution: Fixed > Fix uncleanLeaderElection metric due to ELR election > ---

Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

2025-04-01 Thread via GitHub
fvaleri commented on PR #19198: URL: https://github.com/apache/kafka/pull/19198#issuecomment-2769783277 Closing as not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-19070:: Adding task number to user provided client id to ensure each consumer has a unique client ID to avoid metric registration conflicts. [kafka]

2025-04-01 Thread via GitHub
kumarpritam863 commented on PR #19341: URL: https://github.com/apache/kafka/pull/19341#issuecomment-2769783876 @dajac can you please review this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] MINOR: Clean up comments in RecordVersion [kafka]

2025-04-01 Thread via GitHub
apalan60 opened a new pull request, #19342: URL: https://github.com/apache/kafka/pull/19342 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[jira] [Commented] (KAFKA-15667) preCheck the invalid configuration for tiered storage replication factor

2025-04-01 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939946#comment-17939946 ] Luke Chen commented on KAFKA-15667: --- Sounds good. Let's close it! > preCheck the inva

[jira] [Resolved] (KAFKA-15667) preCheck the invalid configuration for tiered storage replication factor

2025-04-01 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-15667. --- Resolution: Invalid > preCheck the invalid configuration for tiered storage replication factor > ---

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-04-01 Thread via GitHub
stanislavkozlovski commented on code in PR #19336: URL: https://github.com/apache/kafka/pull/19336#discussion_r2022633565 ## docs/ops.html: ## @@ -4026,13 +4026,14 @@ Broker Configurations -By default, Kafka server will not enable tiered storage feature. remote.log.storage.s

Re: [PR] KAFKA-15931: Cancel RemoteLogReader gracefully [kafka]

2025-04-01 Thread via GitHub
junrao merged PR #19150: URL: https://github.com/apache/kafka/pull/19150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-15931: Cancel RemoteLogReader gracefully [kafka]

2025-04-01 Thread via GitHub
junrao commented on PR #19150: URL: https://github.com/apache/kafka/pull/19150#issuecomment-2770691900 @jeqo : Thanks for the reply. Merging this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [WIP] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-04-01 Thread via GitHub
apalan60 commented on code in PR #19327: URL: https://github.com/apache/kafka/pull/19327#discussion_r2023572891 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -3900,86 +3653,6 @@ private Set nodesRequested(List reque

[jira] [Updated] (KAFKA-18718) Unclean recovery configs

2025-04-01 Thread Jonah Hooper (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonah Hooper updated KAFKA-18718: - Description: Add controller configuration for unclean recovery. These will be exposed to the use

Re: [PR] [WIP] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-04-01 Thread via GitHub
apalan60 commented on code in PR #19327: URL: https://github.com/apache/kafka/pull/19327#discussion_r2023533282 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -220,14 +220,6 @@ public static int recordsSize(FetchResponseData.PartitionData pa

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

2025-04-01 Thread via GitHub
gharris1727 commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2770350587 > in short, my thinking is that `@ClusterTestThreadLeakIgnore` is no more "API" than `@ClusterTest` is I agree, the two are very similar: neither should be promoted as public AP

[PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-01 Thread via GitHub
azhar2407 opened a new pull request, #19345: URL: https://github.com/apache/kafka/pull/19345 As of 3.9, Kafka allows disabling remote storage on a topic after it was enabled. It allows subsequent enabling and disabling too. However the documentation says otherwise and needs to be corr

Re: [PR] KAFKA-16616: refactor mergeWith and updatePartitionLeadership [kafka]

2025-04-01 Thread via GitHub
lorcanj commented on PR #19199: URL: https://github.com/apache/kafka/pull/19199#issuecomment-2770394927 Hi @kirktrue, I believe the test was failing due a falky test which some people had noticed was causing the test to outright fail too, [KAFKA-15900](https://issues.apache.org/jira/browse/

[jira] [Resolved] (KAFKA-17053) Restructure build.gradle to configure publishing last

2025-04-01 Thread Haozhong Ma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haozhong Ma resolved KAFKA-17053. - Assignee: (was: Haozhong Ma) Resolution: Won't Fix [GradleUp/shadow#945|https://github

Re: [PR] KAFKA-16894: Define feature to enable share groups [kafka]

2025-04-01 Thread via GitHub
junrao commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2023177127 ## server-common/src/main/java/org/apache/kafka/server/common/ShareVersion.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-01 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2023209778 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3239,7 +3239,7 @@ class KafkaApis(val requestChannel: RequestChannel, shareFetchRequest.max

[jira] [Updated] (KAFKA-19070) Adding task number to the user provided client id (via consumer.override.client.id) to ensure each consumer has a unique client ID to avoid metric registration conflicts

2025-04-01 Thread Pritam Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritam Kumar updated KAFKA-19070: - Labels: improvement (was: ) > Adding task number to the user provided client id (via > consume

Re: [PR] KAFKA-16894: Define feature to enable share groups [kafka]

2025-04-01 Thread via GitHub
AndrewJSchofield commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2023287495 ## server-common/src/main/java/org/apache/kafka/server/common/ShareVersion.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] KAFKA-19064: Handle exceptions from deferred events in coordinator [kafka]

2025-04-01 Thread via GitHub
squah-confluent commented on code in PR #19333: URL: https://github.com/apache/kafka/pull/19333#discussion_r2023370790 ## coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeTest.java: ## @@ -649,42 +649,37 @@ public void testScheduleU

Re: [PR] KAFKA-19064: Handle exceptions from deferred events in coordinator [kafka]

2025-04-01 Thread via GitHub
squah-confluent commented on code in PR #19333: URL: https://github.com/apache/kafka/pull/19333#discussion_r2023370790 ## coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeTest.java: ## @@ -649,42 +649,37 @@ public void testScheduleU

Re: [PR] [WIP] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-04-01 Thread via GitHub
apalan60 commented on PR #19327: URL: https://github.com/apache/kafka/pull/19327#issuecomment-2770474563 > ijuma @ijuma Thanks for the review. I believe I misunderstood the scope of the deletion. I'm currently working on restoring the tests that were mistakenly removed, and

Re: [PR] KAFKA-18816: Add KIP-877 support to KafkaPrincipalBuilder [kafka]

2025-04-01 Thread via GitHub
Yunyung commented on code in PR #18935: URL: https://github.com/apache/kafka/pull/18935#discussion_r2023713551 ## clients/src/test/java/org/apache/kafka/common/network/ChannelBuildersTest.java: ## @@ -34,16 +37,42 @@ import static org.junit.jupiter.api.Assertions.assertInstance

Re: [PR] KAFKA-18816: Add KIP-877 support to KafkaPrincipalBuilder [kafka]

2025-04-01 Thread via GitHub
Yunyung commented on code in PR #18935: URL: https://github.com/apache/kafka/pull/18935#discussion_r2023713551 ## clients/src/test/java/org/apache/kafka/common/network/ChannelBuildersTest.java: ## @@ -34,16 +37,42 @@ import static org.junit.jupiter.api.Assertions.assertInstance

[jira] [Updated] (KAFKA-19067) AsyncKafkaConsumer may return stale fetch result after seek operation

2025-04-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19067: -- Component/s: clients > AsyncKafkaConsumer may return stale fetch result after seek operation > ---

[jira] [Updated] (KAFKA-17089) Incorrect JWT parsing in OAuthBearerUnsecuredJws

2025-04-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17089: -- Component/s: security > Incorrect JWT parsing in OAuthBearerUnsecuredJws > ---

[jira] [Assigned] (KAFKA-17089) Incorrect JWT parsing in OAuthBearerUnsecuredJws

2025-04-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-17089: - Assignee: Kirk True > Incorrect JWT parsing in OAuthBearerUnsecuredJws > --

[jira] [Updated] (KAFKA-17089) Incorrect JWT parsing in OAuthBearerUnsecuredJws

2025-04-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17089: -- Labels: OAuth (was: ) > Incorrect JWT parsing in OAuthBearerUnsecuredJws > --

[jira] [Commented] (KAFKA-19067) AsyncKafkaConsumer may return stale fetch result after seek operation

2025-04-01 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940196#comment-17940196 ] PoAn Yang commented on KAFKA-19067: --- [~lianetm] I found the issue when I tried to enab

[jira] [Resolved] (KAFKA-19062) ShareConsumer should align handling of close timeout with async consumer.

2025-04-01 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19062. -- Fix Version/s: 4.1.0 Resolution: Fixed > ShareConsumer should align handling of

Re: [PR] KAFKA-19004:Move DelayedDeleteRecords to server-common module [kafka]

2025-04-01 Thread via GitHub
gongxuanzhang commented on PR #19226: URL: https://github.com/apache/kafka/pull/19226#issuecomment-2771132888 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-19042 Move ProducerCompressionTest, ProducerFailureHandlingTest, and ProducerIdExpirationTest to client-integration-tests module [kafka]

2025-04-01 Thread via GitHub
gongxuanzhang commented on PR #19319: URL: https://github.com/apache/kafka/pull/19319#issuecomment-2771144849 @FrankYang0529 @chia7712 PTAL I don't think the failed test has anything to do with this PR test case: GssapiAuthenticationTest#testServerAuthenticationFailure -- This

[jira] [Comment Edited] (KAFKA-19067) AsyncKafkaConsumer may return stale fetch result after seek operation

2025-04-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940189#comment-17940189 ] Kirk True edited comment on KAFKA-19067 at 4/1/25 11:31 PM:

Re: [PR] KAFKA-17078: Add SecurityManagerCompatibility shim (#16522) [kafka]

2025-04-01 Thread via GitHub
gharris1727 commented on PR #19221: URL: https://github.com/apache/kafka/pull/19221#issuecomment-2770951005 @jvissers This change applies to more than just the authenticators, it also applies to Connect and the Tiered Storage feature. If you addressed this only for authenticators, those fea

Re: [PR] MINOR: Remove unused `ApiKeys.minRequiredInterBrokerMagic` [kafka]

2025-04-01 Thread via GitHub
apalan60 commented on code in PR #19325: URL: https://github.com/apache/kafka/pull/19325#discussion_r2023979065 ## clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java: ## @@ -67,11 +66,11 @@ public enum ApiKeys { DELETE_RECORDS(ApiMessageType.DELETE_RECORDS)

[jira] [Created] (KAFKA-19073) Add Transactional ID prefix filter to ListTransactions API

2025-04-01 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-19073: -- Summary: Add Transactional ID prefix filter to ListTransactions API Key: KAFKA-19073 URL: https://issues.apache.org/jira/browse/KAFKA-19073 Project: Kafka Issue

Re: [PR] KAFKA-15931: Cancel RemoteLogReader gracefully [kafka]

2025-04-01 Thread via GitHub
junrao commented on PR #19331: URL: https://github.com/apache/kafka/pull/19331#issuecomment-2770893528 @jeqo : Thanks for triaging the test failure. Merging the PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Updated] (KAFKA-15931) Cached transaction index gets closed if tiered storage read is interrupted

2025-04-01 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-15931: Fix Version/s: 3.9.1 4.0.1 > Cached transaction index gets closed if tiered storage rea

Re: [PR] KAFKA-15931: Cancel RemoteLogReader gracefully [kafka]

2025-04-01 Thread via GitHub
junrao merged PR #19331: URL: https://github.com/apache/kafka/pull/19331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-19072: Add system test for ELR [kafka]

2025-04-01 Thread via GitHub
jolshan merged PR #19344: URL: https://github.com/apache/kafka/pull/19344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-19067) AsyncKafkaConsumer may return stale fetch result after seek operation

2025-04-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940189#comment-17940189 ] Kirk True commented on KAFKA-19067: --- I noticed that [some of the seek methods in Subsc

Re: [PR] KAFKA-15931: Cancel RemoteLogReader gracefully [kafka]

2025-04-01 Thread via GitHub
jeqo commented on PR #19331: URL: https://github.com/apache/kafka/pull/19331#issuecomment-2770831246 @junrao No. All flaky tests that when run locally are passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-18816: Add KIP-877 support to KafkaPrincipalBuilder [kafka]

2025-04-01 Thread via GitHub
Yunyung commented on code in PR #18935: URL: https://github.com/apache/kafka/pull/18935#discussion_r2023713551 ## clients/src/test/java/org/apache/kafka/common/network/ChannelBuildersTest.java: ## @@ -34,16 +37,42 @@ import static org.junit.jupiter.api.Assertions.assertInstance

[jira] [Commented] (KAFKA-7952) Consider to switch to in-memory stores in test whenever possible

2025-04-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940228#comment-17940228 ] Matthias J. Sax commented on KAFKA-7952: [~ableegoldman] [~bbejeck] – I still thi

Re: [PR] KAFKA-19058 Running the streams/streams-scala module tests produces a streams-scala.log [kafka]

2025-04-01 Thread via GitHub
mjsax commented on code in PR #19324: URL: https://github.com/apache/kafka/pull/19324#discussion_r2023994005 ## streams/streams-scala/src/test/resources/log4j2.yaml: ## @@ -22,19 +22,11 @@ Configuration: Appenders: Console: name: A1 Review Comment: nit: can we

Re: [PR] KAFKA-18067: Add a flag to disable producer reset during active task creator shutting down [kafka]

2025-04-01 Thread via GitHub
mjsax commented on code in PR #19269: URL: https://github.com/apache/kafka/pull/19269#discussion_r2024005800 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java: ## @@ -119,7 +119,8 @@ private Producer producer() { } public vo

Re: [PR] KAFKA-19016: Updated the retention behaviour of share groups to retain them forever [kafka]

2025-04-01 Thread via GitHub
AndrewJSchofield commented on code in PR #19343: URL: https://github.com/apache/kafka/pull/19343#discussion_r2023172343 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -200,4 +200,11 @@ void validateOffsetFetch( * Requests a metadata

Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

2025-04-01 Thread via GitHub
fvaleri closed pull request #19198: MINOR: Fix upgrade finalization flag URL: https://github.com/apache/kafka/pull/19198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] KAFKA-18794: Disable flaky tests pending investigation [kafka]

2025-04-01 Thread via GitHub
AndrewJSchofield opened a new pull request, #19340: URL: https://github.com/apache/kafka/pull/19340 KafkaShareConsumerTest is proving very flaky. The behaviour of MockClient does not appear to match the expectations of the test. This PR disables the flaky tests to reduce build noise. When a

[jira] [Updated] (KAFKA-18714) Unclean Recovery: Balanced strategy

2025-04-01 Thread Jonah Hooper (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonah Hooper updated KAFKA-18714: - Labels: Phase-3 (was: ) > Unclean Recovery: Balanced strategy > ---

[jira] [Updated] (KAFKA-18717) Unclean Recovery: thread-pool

2025-04-01 Thread Jonah Hooper (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonah Hooper updated KAFKA-18717: - Labels: Phase-2 (was: ) > Unclean Recovery: thread-pool > - > >

[PR] KAFKA-19016: Updated the retention behaviour of share groups to retain them forever [kafka]

2025-04-01 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19343: URL: https://github.com/apache/kafka/pull/19343 This PR makes the required changes for retaining a share group forever post creation. A new field `shouldExpire` is added to all types implementing the interface `Group`. It returns false only

[jira] [Updated] (KAFKA-18720) System Tests for Unclean Recovery

2025-04-01 Thread Jonah Hooper (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonah Hooper updated KAFKA-18720: - Labels: Phase-2 (was: ) > System Tests for Unclean Recovery > -

Re: [PR] KAFKA-18892: KIP-877 Add support for ClientQuotaCallback [kafka]

2025-04-01 Thread via GitHub
mimaison commented on code in PR #19068: URL: https://github.com/apache/kafka/pull/19068#discussion_r2023198108 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/server/quota/CustomQuotaCallbackTest.java: ## @@ -69,10 +70,42 @@ public void testCustomQuotaCallba

  1   2   >