ijuma commented on code in PR #19316:
URL: https://github.com/apache/kafka/pull/19316#discussion_r2022845619


##########
core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala:
##########
@@ -203,7 +203,7 @@ class RemoteLeaderEndPoint(logPrefix: String,
       None
     } else {
       val metadataVersion = metadataVersionSupplier()
-      val version: Short = if (metadataVersion.fetchRequestVersion >= 13 && 
!fetchData.canUseTopicIds) {
+      val version: Short = if (!fetchData.canUseTopicIds) {

Review Comment:
   As part of that ticket, we should also remove the `getOrElse` below and 
change `PartitionFetchState.topicId` not to be Optional, etc.
   
   > fetchState.topicId.getOrElse(Uuid.ZERO_UUID),



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to