gharris1727 commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2770350587
> in short, my thinking is that `@ClusterTestThreadLeakIgnore` is no more "API" than `@ClusterTest` is I agree, the two are very similar: neither should be promoted as public API currently, and *should* only be used for internal purposes. They both *can* be used by plugin developers to test their plugins, but this would be in defiance of our public API statements. If you're looking for a direct reason for why ClusterTest is merged and why ClusterTestThreadLeakIgnore isn't, it's because there are no upstream benefits of the leak annotation while the SKIPPED_THREAD_PREFIX variable exists. If it isn't providing value to the upstream project and isn't public API, it's a maintenance burden and could possibly get deleted. > but what is the alternative ? I appreciate as a plugin developer that depending on internal APIs can be very convenient. And I acknowledge that there are many different projects depending on our internal APIs right now. But as a maintainer, i believe we need to defend our internal APIs or risk being unable to change things later. And in this situation, I think having a serious discussion about having a public testing API is the healthiest way forward. A compromise between the current approach and the public API approach would be to have this annotation provide upstream value. Find an annotation that benefits Kafka and you can use it for free, the same as `@ClusterTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
