mimaison commented on code in PR #19068:
URL: https://github.com/apache/kafka/pull/19068#discussion_r2023198108
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/server/quota/CustomQuotaCallbackTest.java:
##########
@@ -69,10 +70,42 @@ public void testCustomQuotaCallbackWithControllerServer()
throws InterruptedExce
&&
CustomQuotaCallback.COUNTERS.values().stream().allMatch(counter ->
counter.get() > 0),
"The CustomQuotaCallback not triggered in all controllers.
"
);
-
+
+ }
+ }
+
+
+ @ClusterTest(
Review Comment:
I wonder if it's worth having a test in combined mode to ensure that the
quota callbacks can be instantiated by both controllers and brokers at the same
time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
