AndrewJSchofield commented on code in PR #19334:
URL: https://github.com/apache/kafka/pull/19334#discussion_r2022358524
##########
clients/src/main/resources/common/message/ShareFetchResponse.json:
##########
@@ -39,6 +39,8 @@
"about": "The top-level response error code." },
{ "name": "ErrorMessage", "type": "string", "versions": "0+",
"nullableVersions": "0+", "default": "null",
"about": "The top-level error message, or null if there was no error." },
+ { "name": "AcquisitionLockTimeout", "type": "int64", "versions": "0+",
Review Comment:
Please can you add `Ms` to the field name? In RPCs, the convention for
timeouts is always to have `Ms` on the end, such as `RebalanceTimeoutMs`. Also,
they are always `int32`, which is probably appropriate here too.
##########
clients/src/main/resources/common/message/ShareFetchRequest.json:
##########
@@ -36,7 +36,9 @@
{ "name": "MinBytes", "type": "int32", "versions": "0+",
"about": "The minimum bytes to accumulate in the response." },
{ "name": "MaxBytes", "type": "int32", "versions": "0+", "default":
"0x7fffffff",
- "about": "The maximum bytes to fetch. See KIP-74 for cases where this
limit may not be honored." },
+ "about": "The maximum bytes to fetch. See KIP-74 for cases where this
limit may not be honored." },
+ { "name": "MaxRecords", "type": "int32", "versions": "0+",
+ "about": "The maximum number of records to fetch. This is a soft limit
and records can exceed upto the end of fetch log batch." },
Review Comment:
I suggest for the second sentence "This limit can be exceeded for alignment
of batch boundaries".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
