Re: [PR] KAFKA-18733: Implemented fetch ratio and partition acquire time metrics (3/N) [kafka]

2025-02-20 Thread via GitHub
apoorvmittal10 commented on code in PR #18959: URL: https://github.com/apache/kafka/pull/18959#discussion_r1964547564 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -62,9 +63,13 @@ public class DelayedShareFetch extends DelayedOperation { private fin

[PR] MINOR: Don't allow cloning a ProducerStateEntry with a different producer id [kafka]

2025-02-20 Thread via GitHub
BewareMyPower opened a new pull request, #18990: URL: https://github.com/apache/kafka/pull/18990 The `ProducerStateEntry` has been refactored several times and now `ProducerAppendInfo#updatedEntry` is created by calling the `withProducerIdAndBatchMetadata` on `currentEntry`. However, this m

Re: [PR] MINOR: cleanup SinkNode generics [kafka]

2025-02-20 Thread via GitHub
mjsax merged PR #18975: URL: https://github.com/apache/kafka/pull/18975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman opened a new pull request, #18988: URL: https://github.com/apache/kafka/pull/18988 In 3.1 we deprecated the eager rebalancing protocol and marked it for removal in a later release. We aim to officially drop support and remove the protocol from Streams in 4.0. Note that we are o

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-20 Thread via GitHub
VedarthConfluent commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1964921578 ## docker/jvm/Dockerfile: ## @@ -22,20 +22,24 @@ USER root # Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-20 Thread via GitHub
chia7712 commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1965027255 ## core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala: ## @@ -110,7 +110,9 @@ object KafkaDockerWrapper extends Logging { case Some(str) => str ca

[jira] [Updated] (KAFKA-18839) Drop support for eager rebalancing in Streams

2025-02-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18839: Priority: Blocker (was: Major) > Drop support for eager rebalancing in Streams >

Re: [PR] MINOR: cleanup SinkNode generics [kafka]

2025-02-20 Thread via GitHub
AndrewJSchofield commented on code in PR #18975: URL: https://github.com/apache/kafka/pull/18975#discussion_r1963105162 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/SinkNodeTest.java: ## @@ -48,8 +48,8 @@ public class SinkNodeTest { new Stat

[jira] [Assigned] (KAFKA-18033) ShareConsumerTest is flaky

2025-02-20 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-18033: Assignee: Shivsundar R (was: kangning.li) Assigning this ticket because we are r

[PR] KAFKA-18836 Make ConsumerGroupMetadata an interface [kafka]

2025-02-20 Thread via GitHub
pszymczyk opened a new pull request, #18977: URL: https://github.com/apache/kafka/pull/18977 Implementation for [KAFKA-18836](https://issues.apache.org/jira/browse/KAFKA-18836) improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Resolved] (KAFKA-18829) Can't use explicit ack when poll returns an empty batch

2025-02-20 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R resolved KAFKA-18829. -- Resolution: Fixed > Can't use explicit ack when poll returns an empty batch >

[jira] [Updated] (KAFKA-18829) Can't use explicit ack when poll returns an empty batch

2025-02-20 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-18829: --- Fix Version/s: 4.1.0 > Can't use explicit ack when poll returns an empty batch > ---

Re: [PR] KAFKA-18828: Update share group metrics per new init and call mechanism. [kafka]

2025-02-20 Thread via GitHub
AndrewJSchofield merged PR #18962: URL: https://github.com/apache/kafka/pull/18962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Commented] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-20 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928726#comment-17928726 ] Paweł Szymczyk commented on KAFKA-18836: Hi [~graceu] , I am an author of the fe

Re: [PR] KAFKA-18836 Make ConsumerGroupMetadata an interface [kafka]

2025-02-20 Thread via GitHub
pszymczyk commented on PR #18977: URL: https://github.com/apache/kafka/pull/18977#issuecomment-2671097657 Hi @frankvicky Sure I will provide a KIP this week, just need to read all the manuals and follow procedures as it is my first contribution into Kafka project. -- This is an autom

[jira] [Commented] (KAFKA-18796) Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure

2025-02-20 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928757#comment-17928757 ] Abhinav Dixit commented on KAFKA-18796: --- I ran the test for 500 times using the co

[jira] [Resolved] (KAFKA-18796) Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure

2025-02-20 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit resolved KAFKA-18796. --- Resolution: Not A Problem > Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupSta

Re: [PR] KAFKA-15900, KAFKA-18310: fix flaky test testOutdatedCoordinatorAssignment and AbstractCoordinatorTest [kafka]

2025-02-20 Thread via GitHub
FrankYang0529 commented on PR #18945: URL: https://github.com/apache/kafka/pull/18945#issuecomment-2671163736 Hi @lianetm, I update the PR to use `MockHeartbeatThread`. Could you review it when you have time? Thank you. -- This is an automated message from the Apache Git Service. To respo

[jira] [Updated] (KAFKA-18796) Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure

2025-02-20 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit updated KAFKA-18796: -- Summary: Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure (was: Fix

Re: [PR] KAFKA-18733: Implemented fetch ratio and partition acquire time metrics (3/N) [kafka]

2025-02-20 Thread via GitHub
AndrewJSchofield commented on PR #18959: URL: https://github.com/apache/kafka/pull/18959#issuecomment-2671119279 Failed test `EagerConsumerCoordinatorTest > testOutdatedCoordinatorAssignment` is a known flaky test which is failing about 30% of the time at the moment. -- This is an automa

[jira] [Assigned] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-20 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ukpa Uchechi reassigned KAFKA-18836: Assignee: (was: Ukpa Uchechi) > Make ConsumerGroupMetadata an interface > ---

[jira] [Commented] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-20 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928734#comment-17928734 ] Ukpa Uchechi commented on KAFKA-18836: -- [~pawelszymczyk] sure > Make ConsumerGroup

Re: [PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-20 Thread via GitHub
dajac commented on code in PR #18974: URL: https://github.com/apache/kafka/pull/18974#discussion_r1963276056 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2592,11 +2601,23 @@ class KafkaApis(val requestChannel: RequestChannel, response.groups.addAll(re

Re: [PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-20 Thread via GitHub
dajac commented on PR #18974: URL: https://github.com/apache/kafka/pull/18974#issuecomment-2671149298 @dongnuo123 There are failed tests which look related to the change. Could you please check and fix them? -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Resolved] (KAFKA-18740) Remove BootstrapDirectory#ibp

2025-02-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18740. Fix Version/s: (was: 4.1.0) Resolution: Duplicate fixed by https://github.com/a

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-20 Thread via GitHub
jsancio commented on PR #18852: URL: https://github.com/apache/kafka/pull/18852#issuecomment-2672984627 > @jsancio : The following failed tests seem related to this PR? > > ``` > FAILED ❌ AbstractFetcherThreadTest > testRetryAfterUnknownLeaderEpochInLatestOffsetFetch() > FAILED

Re: [PR] KAFKA-18733: Implemented fetch ratio and partition acquire time metrics (3/N) [kafka]

2025-02-20 Thread via GitHub
apoorvmittal10 commented on code in PR #18959: URL: https://github.com/apache/kafka/pull/18959#discussion_r1964540273 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -79,16 +84,29 @@ public DelayedShareFetch( ShareFetch shareFetch,

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-20 Thread via GitHub
chia7712 commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1964656576 ## core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala: ## @@ -110,7 +110,9 @@ object KafkaDockerWrapper extends Logging { case Some(str) => str ca

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964656500 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java: ## @@ -108,106 +111,19 @@ public RebalanceProtocol rebalanceP

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964656765 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java: ## @@ -108,106 +111,19 @@ public RebalanceProtocol rebalanceP

[jira] [Comment Edited] (KAFKA-13769) KTable FK join can miss records if an upstream non-key-changing operation changes key serializer

2025-02-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680858#comment-17680858 ] Matthias J. Sax edited comment on KAFKA-13769 at 2/21/25 2:35 AM:

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-20 Thread via GitHub
chia7712 commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1964980767 ## core/src/test/scala/unit/kafka/docker/KafkaDockerWrapperTest.scala: ## @@ -133,7 +133,7 @@ class KafkaDockerWrapperTest { val configsPath = Paths.get("/path/to

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-20 Thread via GitHub
chia7712 commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1964527266 ## docker/jvm/Dockerfile: ## @@ -22,20 +22,24 @@ USER root # Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments ARG kaf

Re: [PR] KAFKA-18733: Implemented fetch ratio and partition acquire time metrics (3/N) [kafka]

2025-02-20 Thread via GitHub
apoorvmittal10 commented on code in PR #18959: URL: https://github.com/apache/kafka/pull/18959#discussion_r1964534212 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -120,16 +141,28 @@ public void onComplete() { try { LinkedHashMap to

[jira] [Updated] (KAFKA-18839) Drop support for eager rebalancing in Streams

2025-02-20 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-18839: --- Description: In 3.1 we deprecated the EAGER protocol in Kafka Streams (see K

Re: [PR] KAFKA-4763; Handle disk failure for JBOD (KIP-112) [kafka]

2025-02-20 Thread via GitHub
afshin-deriv commented on code in PR #2929: URL: https://github.com/apache/kafka/pull/2929#discussion_r1964704064 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -864,7 +864,8 @@ private PartitionRecords parseCompletedFetch(CompletedFetch

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964705263 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code upgrade

Re: [PR] KAFKA-4763; Handle disk failure for JBOD (KIP-112) [kafka]

2025-02-20 Thread via GitHub
afshin-deriv commented on code in PR #2929: URL: https://github.com/apache/kafka/pull/2929#discussion_r1964704064 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -864,7 +864,8 @@ private PartitionRecords parseCompletedFetch(CompletedFetch

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964708632 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java: ## @@ -108,106 +110,20 @@ public RebalanceProtocol rebalanceP

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964711072 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java: ## @@ -54,30 +54,25 @@ public void configsShouldRejectZer

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964709058 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java: ## @@ -108,106 +110,20 @@ public RebalanceProtocol reb

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964711785 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java: ## @@ -54,30 +54,25 @@ public void configsShouldRe

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964709874 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java: ## @@ -54,30 +54,25 @@ public void configsShouldRejectZer

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-20 Thread via GitHub
frankvicky commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1964654037 ## core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala: ## @@ -110,7 +110,9 @@ object KafkaDockerWrapper extends Logging { case Some(str) => str

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964712710 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java: ## @@ -54,30 +54,25 @@ public void configsShouldRejectZer

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964714406 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java: ## @@ -54,30 +54,25 @@ public void configsShouldRe

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-20 Thread via GitHub
frankvicky commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1964926818 ## docker/jvm/Dockerfile: ## @@ -22,20 +22,24 @@ USER root # Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments ARG k

Re: [PR] KAFKA-18795: Remove `Records#downConvert` [kafka]

2025-02-20 Thread via GitHub
chia7712 commented on PR #18897: URL: https://github.com/apache/kafka/pull/18897#issuecomment-2673559455 @xijiu could you please rebase code to trigger QA again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-20 Thread via GitHub
VedarthConfluent commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1964944174 ## docker/jvm/Dockerfile: ## @@ -22,20 +22,24 @@ USER root # Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-20 Thread via GitHub
VedarthConfluent commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1964955176 ## core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala: ## @@ -110,7 +110,9 @@ object KafkaDockerWrapper extends Logging { case Some(str) => str

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-20 Thread via GitHub
VedarthConfluent commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1964958944 ## core/src/test/scala/unit/kafka/docker/KafkaDockerWrapperTest.scala: ## @@ -133,7 +133,7 @@ class KafkaDockerWrapperTest { val configsPath = Paths.get("

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964718367 ## tests/kafkatest/tests/streams/streams_application_upgrade_test.py: ## @@ -23,19 +23,18 @@ from kafkatest.version import LATEST_2_2, LATEST_2_3, LATEST_2_4, LATEST_2_5

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964718367 ## tests/kafkatest/tests/streams/streams_application_upgrade_test.py: ## @@ -23,19 +23,18 @@ from kafkatest.version import LATEST_2_2, LATEST_2_3, LATEST_2_4, LATEST_2_5

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964721171 ## tests/kafkatest/tests/streams/streams_cooperative_rebalance_upgrade_test.py: ## @@ -43,7 +43,10 @@ class StreamsCooperativeRebalanceUpgradeTest(Test): second_boun

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964718367 ## tests/kafkatest/tests/streams/streams_application_upgrade_test.py: ## @@ -23,19 +23,18 @@ from kafkatest.version import LATEST_2_2, LATEST_2_3, LATEST_2_4, LATEST_2_5

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on PR #18988: URL: https://github.com/apache/kafka/pull/18988#issuecomment-2673268004 \cc @dajac for visibility -- we want to get this into `4.0` release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-18754: Allow `PlainSaslServer` to pass client info through the negotiated properties. [kafka]

2025-02-20 Thread via GitHub
github-actions[bot] commented on PR #18828: URL: https://github.com/apache/kafka/pull/18828#issuecomment-2673270196 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964730450 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java: ## @@ -54,30 +54,25 @@ public void configsShouldRejectZer

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964730450 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java: ## @@ -54,30 +54,25 @@ public void configsShouldRejectZer

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964739710 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java: ## @@ -108,106 +110,20 @@ public RebalanceProtocol rebalanceP

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964741210 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java: ## @@ -54,30 +54,25 @@ public void configsShouldRejectZer

[jira] [Created] (KAFKA-18840) Add system test for 2-rolling-bounce bridge release upgrade path in Streams

2025-02-20 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-18840: -- Summary: Add system test for 2-rolling-bounce bridge release upgrade path in Streams Key: KAFKA-18840 URL: https://issues.apache.org/jira/browse/KAFKA-18840

[jira] [Commented] (KAFKA-18840) Add system test for 2-rolling-bounce bridge release upgrade path in Streams

2025-02-20 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929023#comment-17929023 ] A. Sophie Blee-Goldman commented on KAFKA-18840: Related to [https://git

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964810607 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code upgrade

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964810607 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code upgrade

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964830589 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -33,8 +33,7 @@ str(LATEST_3_3), str(LATEST_3_4), str(LATEST_3_5), str(

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-20 Thread via GitHub
junrao commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1964597100 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientFetchTest.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964782789 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java: ## @@ -54,30 +54,25 @@ public void configsShouldRe

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964829107 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964741210 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfigurationTest.java: ## @@ -54,30 +54,25 @@ public void configsShouldRejectZer

Re: [PR] KAFKA-18839: Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964759422 ## tests/kafkatest/tests/streams/streams_cooperative_rebalance_upgrade_test.py: ## @@ -43,7 +43,10 @@ class StreamsCooperativeRebalanceUpgradeTest(Test): second_boun

Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-20 Thread via GitHub
dongnuo123 closed pull request #18974: KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe URL: https://github.com/apache/kafka/pull/18974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-20 Thread via GitHub
dongnuo123 commented on code in PR #18989: URL: https://github.com/apache/kafka/pull/18989#discussion_r1964646708 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2519,19 +2519,28 @@ class KafkaApis(val requestChannel: RequestChannel, def handleConsumerGroupHeart

Re: [PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-20 Thread via GitHub
dongnuo123 commented on PR #18974: URL: https://github.com/apache/kafka/pull/18974#issuecomment-2673183011 Reopened a new PR at https://github.com/apache/kafka/pull/18989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964649521 ## tests/kafkatest/tests/streams/streams_application_upgrade_test.py: ## @@ -23,19 +23,18 @@ from kafkatest.version import LATEST_2_2, LATEST_2_3, LATEST_2_4, LAT

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964651322 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code upgrade

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964642690 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964648165 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code

[PR] KAFKA-18813: [1/N] ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-20 Thread via GitHub
dongnuo123 opened a new pull request, #18989: URL: https://github.com/apache/kafka/pull/18989 This patch filters out the topic describe unauthorized topics from the ConsumerGroupHeartbeat and ConsumerGroupDescribe response. ### Committer Checklist (excluded from commit message) - [

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964648789 ## tests/kafkatest/tests/streams/streams_cooperative_rebalance_upgrade_test.py: ## @@ -43,7 +43,10 @@ class StreamsCooperativeRebalanceUpgradeTest(Test): seco

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964651322 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code upgrade

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964652942 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -216,11 +217,13 @@ public interface UserTaskAssignmentListener

[jira] [Updated] (KAFKA-8575) Finish removing EAGER protocol in Streams by cleaning up task assignment & management

2025-02-20 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-8575: -- Summary: Finish removing EAGER protocol in Streams by cleaning up task assignme

[jira] [Created] (KAFKA-18839) Drop support for eager rebalancing in Streams

2025-02-20 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-18839: -- Summary: Drop support for eager rebalancing in Streams Key: KAFKA-18839 URL: https://issues.apache.org/jira/browse/KAFKA-18839 Project: Kafka

[PR] Specify ArrayDeque init size to NUM_BATCHES_TO_RETAIN in ProducerStateEntry [kafka]

2025-02-20 Thread via GitHub
dao-jun opened a new pull request, #18991: URL: https://github.com/apache/kafka/pull/18991 The default init size of `ArrayDeque` is 16+1, but we only need `NUM_BATCHES_TO_RETAIN(default 5)`. Specify `ArrayDeque` init size to `NUM_BATCHES_TO_RETAIN` to optimize memory usage ### Co

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-20 Thread via GitHub
frankvicky commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1965014560 ## docker/jvm/Dockerfile: ## @@ -22,20 +22,24 @@ USER root # Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments ARG k

Re: [PR] KAFKA-18733: Implemented fetch ratio and partition acquire time metrics (3/N) [kafka]

2025-02-20 Thread via GitHub
apoorvmittal10 commented on PR #18959: URL: https://github.com/apache/kafka/pull/18959#issuecomment-2671360248 Re-triggered build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] KAFKA-17351: Update tests and acquire API to allow discard batches from compacted topics (1/N) [kafka]

2025-02-20 Thread via GitHub
apoorvmittal10 opened a new pull request, #18978: URL: https://github.com/apache/kafka/pull/18978 The PR does following: 1. Adds `fetchOffset` to `acquire` API in SharePartition. 2. Adds a ShareFetchPartitionData class efficiently handle the propagation of fetchOffset information.

[jira] [Resolved] (KAFKA-16475) Create unit test for TopicImageNode

2025-02-20 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-16475. - Resolution: Fixed > Create unit test for TopicImageNode > --- > >

Re: [PR] KAFKA-18733: Implemented fetch ratio and partition acquire time metrics (3/N) [kafka]

2025-02-20 Thread via GitHub
AndrewJSchofield commented on code in PR #18959: URL: https://github.com/apache/kafka/pull/18959#discussion_r1963334197 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -79,16 +84,29 @@ public DelayedShareFetch( ShareFetch shareFetch,

[jira] [Commented] (KAFKA-18836) Make ConsumerGroupMetadata an interface

2025-02-20 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928798#comment-17928798 ] Paweł Szymczyk commented on KAFKA-18836: I am waiting for Confluence account app

[PR] KAFKA-18614, KAFKA-18613: Add streams group request plumbing [kafka]

2025-02-20 Thread via GitHub
lucasbru opened a new pull request, #18979: URL: https://github.com/apache/kafka/pull/18979 This change implements the basic RPC handling StreamsGroupHeartbeat and StreamsGroupDescribe. This includes: - Adding an option to enable streams groups on the broker - Passing describe and he

Re: [PR] KAFKA-18831: Migrating to log4j2 introduce behavior changes of adjusting level dynamically [kafka]

2025-02-20 Thread via GitHub
frankvicky commented on code in PR #18969: URL: https://github.com/apache/kafka/pull/18969#discussion_r1963591806 ## core/src/main/scala/kafka/utils/LoggingController.scala: ## @@ -112,24 +112,30 @@ private class Log4jCoreController extends LoggingControllerDelegate { val

Re: [PR] KAFKA-18813: ConsumerGroupHeartbeat API and ConsumerGroupDescribe API must check topic describe [kafka]

2025-02-20 Thread via GitHub
dajac commented on PR #18974: URL: https://github.com/apache/kafka/pull/18974#issuecomment-2671553142 @dongnuo123 Could you also please update the javadoc in the Admin client? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Comment Edited] (KAFKA-18796) Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure

2025-02-20 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928757#comment-17928757 ] Abhinav Dixit edited comment on KAFKA-18796 at 2/20/25 12:44 PM: -

Re: [PR] KAFKA-18629: Delete share group state RPC group coordinator impl. [3/N] [kafka]

2025-02-20 Thread via GitHub
smjn commented on code in PR #18848: URL: https://github.com/apache/kafka/pull/18848#discussion_r1963643829 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -6855,6 +6861,45 @@ public void createGroupTombstoneRecords(

[jira] [Reopened] (KAFKA-18796) Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure

2025-02-20 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit reopened KAFKA-18796: --- > Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure > --

[jira] [Commented] (KAFKA-18796) Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure

2025-02-20 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928811#comment-17928811 ] Abhinav Dixit commented on KAFKA-18796: --- Reopened Jira as adviced by [~apoorvmitta

[jira] [Comment Edited] (KAFKA-18796) Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure

2025-02-20 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928811#comment-17928811 ] Abhinav Dixit edited comment on KAFKA-18796 at 2/20/25 2:19 PM: --

Re: [PR] KAFKA-18617 Allow use of ClusterInstance inside BeforeEach [kafka]

2025-02-20 Thread via GitHub
mumrah commented on PR #18662: URL: https://github.com/apache/kafka/pull/18662#issuecomment-2671648519 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

  1   2   >