chia7712 commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1964527266
########## docker/jvm/Dockerfile: ########## @@ -22,20 +22,24 @@ USER root # Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments ARG kafka_url +ARG skip_signing=false Review Comment: > Although our docker official images script will also need to be updated to support this new arg. I don't request that in my previous comment ( https://github.com/apache/kafka/pull/18844#issuecomment-2665917480), because it may corrupt the image we will publish. Maybe we can leave this "skip" only in the testing. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
