mjsax commented on code in PR #18988:
URL: https://github.com/apache/kafka/pull/18988#discussion_r1964705263
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig {
/** {@code upgrade.from} */
@SuppressWarnings("WeakerAccess")
public static final String UPGRADE_FROM_CONFIG = "upgrade.from";
- private static final String UPGRADE_FROM_DOC = "Allows upgrading in a
backward compatible way. " +
- "This is needed when upgrading from [0.10.0, 1.1] to 2.0+, or when
upgrading from [2.0, 2.3] to 2.4+. " +
- "When upgrading from 3.3 to a newer version it is not required to
specify this config. Default is `null`. " +
- "Accepted values are \"" + UPGRADE_FROM_0100 + "\", \"" +
UPGRADE_FROM_0101 + "\", \"" +
- UPGRADE_FROM_0102 + "\", \"" + UPGRADE_FROM_0110 + "\", \"" +
UPGRADE_FROM_10 + "\", \"" +
- UPGRADE_FROM_11 + "\", \"" + UPGRADE_FROM_20 + "\", \"" +
UPGRADE_FROM_21 + "\", \"" +
- UPGRADE_FROM_22 + "\", \"" + UPGRADE_FROM_23 + "\", \"" +
UPGRADE_FROM_24 + "\", \"" +
+ private static final String UPGRADE_FROM_DOC = "Allows live upgrading (and
downgrading) in a backward compatible way. Default is `null`. " +
+ "Please refer to the Kafka Streams upgrade guide for instructions on
how and when to use this config. " +
+ "Note that when upgrading from 3.5 to a newer version it is never
required to specify this config, " +
+ "while upgrading live directly to 4.0 from 2.3 or below is no longer
supported even with this config. " +
Review Comment:
```suggestion
"while upgrading live directly to 4.0+ from 2.3 or below is no
longer supported even with this config. " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
