frankvicky commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1964926818
########## docker/jvm/Dockerfile: ########## @@ -22,20 +22,24 @@ USER root # Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments ARG kafka_url +ARG skip_signing=false Review Comment: Hi @VedarthConfluent > DOI doesn't support docker files with args, so we need to replace them with fixed values, just like done with kafka_url Is this situation only in the native image? The JVM image doesn't seem to need this workaround. ########## docker/jvm/Dockerfile: ########## @@ -22,20 +22,24 @@ USER root # Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments ARG kafka_url +ARG skip_signing=false Review Comment: Hi @VedarthConfluent > DOI doesn't support docker files with args, so we need to replace them with fixed values, just like done with kafka_url Is this situation only in the native image? The JVM image doesn't seem to need this workaround. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
