BewareMyPower opened a new pull request, #18990: URL: https://github.com/apache/kafka/pull/18990
The `ProducerStateEntry` has been refactored several times and now `ProducerAppendInfo#updatedEntry` is created by calling the `withProducerIdAndBatchMetadata` on `currentEntry`. However, this method is confusing because the 1st parameter is the producer id, which means this method could be used to create `updatedEntry` with a different producer id with `currentEntry`. However, this case should never happen. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org