Re: [PR] KAFKA-17421: Add IT for ConsumerRecord#leaderEpoch [kafka]

2024-12-28 Thread via GitHub
chia7712 commented on code in PR #18254: URL: https://github.com/apache/kafka/pull/18254#discussion_r1898879221 ## core/src/test/java/kafka/clients/consumer/ConsumerIntegrationTest.java: ## @@ -185,4 +194,72 @@ public void onPartitionsAssigned(Collection partitions) {

[PR] KAFKA-18354 Use log4j2 APIs to refactor LogCaptureAppender [kafka]

2024-12-28 Thread via GitHub
m1a2st opened a new pull request, #18338: URL: https://github.com/apache/kafka/pull/18338 as title ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including u

[jira] [Updated] (KAFKA-18355) Stream thread blocks indefinitely for acquiring state directory lock

2024-12-28 Thread Ravi Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gupta updated KAFKA-18355: --- Description: We are running Kafka streams based application in production and have noticed couple o

[jira] [Created] (KAFKA-18355) Stream thread blocks indefinitely for acquiring state directory lock

2024-12-28 Thread Ravi Gupta (Jira)
Ravi Gupta created KAFKA-18355: -- Summary: Stream thread blocks indefinitely for acquiring state directory lock Key: KAFKA-18355 URL: https://issues.apache.org/jira/browse/KAFKA-18355 Project: Kafka

[jira] [Updated] (KAFKA-18355) Stream thread blocks indefinitely for acquiring state directory lock

2024-12-28 Thread Ravi Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gupta updated KAFKA-18355: --- Description: We are running Kafka streams based application in production and have noticed couple o

[jira] [Updated] (KAFKA-18355) Stream thread blocks indefinitely for acquiring state directory lock

2024-12-28 Thread Ravi Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gupta updated KAFKA-18355: --- Description: We are running Kafka streams based application in production and have noticed couple o

Re: [PR] KAFKA-18277: fix e2e network_degrade_test [kafka]

2024-12-28 Thread via GitHub
TaiJuWu commented on PR #18247: URL: https://github.com/apache/kafka/pull/18247#issuecomment-2564298635 After check, this failure is related to linux version but there are some issue about vagrant and I just workaround it please refer https://github.com/apache/kafka/pull/18247/commits/ef571

[jira] [Updated] (KAFKA-18355) Stream thread blocks indefinitely for acquiring state directory lock

2024-12-28 Thread Ravi Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gupta updated KAFKA-18355: --- Description: We are running Kafka streams based application in production and have noticed couple o

[jira] [Updated] (KAFKA-18355) Stream thread blocks indefinitely for acquiring state directory lock

2024-12-28 Thread Ravi Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Gupta updated KAFKA-18355: --- Description: We are running Kafka streams based application in production and have noticed couple o

Re: [PR] KAFKA-18339: Remove raw unversioned direct SASL protocol (KIP-896) [kafka]

2024-12-28 Thread via GitHub
chia7712 commented on code in PR #18295: URL: https://github.com/apache/kafka/pull/18295#discussion_r1898872993 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -1107,8 +1107,10 @@ private[kafka] class Processor( val header = RequestHeader.parse(buffer) i

Re: [PR] MINOR: remove unused previousPartition from RoundRobinPartitioner.java [kafka]

2024-12-28 Thread via GitHub
chia7712 merged PR #18331: URL: https://github.com/apache/kafka/pull/18331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Update Consumer and Producer JavaDocs for committing offsets [kafka]

2024-12-28 Thread via GitHub
AndrewJSchofield commented on code in PR #18336: URL: https://github.com/apache/kafka/pull/18336#discussion_r1898872562 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -70,8 +70,12 @@ * Offsets and Consumer Position * Kafka maintains a nu

[jira] [Resolved] (KAFKA-18317) Remove zookeeper.connect from RemoteLogManagerTest

2024-12-28 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18317. Fix Version/s: 4.0.0 Resolution: Fixed trunk: https://github.com/apache/kafka/comm

Re: [PR] KAFKA-18135: ShareConsumer HB UnsupportedVersion msg mixed with Consumer HB [kafka]

2024-12-28 Thread via GitHub
AndrewJSchofield merged PR #18101: URL: https://github.com/apache/kafka/pull/18101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-18135) ShareConsumer HB UnsupportedVersion msg mixed with Consumer HB

2024-12-28 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-18135. -- Fix Version/s: 4.1.0 Resolution: Fixed > ShareConsumer HB UnsupportedVersion ms

[jira] [Created] (KAFKA-18357) Support to dynamically configure the log level for JUL and logback

2024-12-28 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18357: -- Summary: Support to dynamically configure the log level for JUL and logback Key: KAFKA-18357 URL: https://issues.apache.org/jira/browse/KAFKA-18357 Project: Kafka

Re: [PR] KAFKA-18243 Loggers breaks the use of root logger after migrating to log4j2 [kafka]

2024-12-28 Thread via GitHub
frankvicky commented on code in PR #18185: URL: https://github.com/apache/kafka/pull/18185#discussion_r1898917932 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java: ## @@ -103,18 +105,16 @@ public synchronized LoggerLevel level(String logger) {

[jira] [Commented] (KAFKA-18135) ShareConsumer HB UnsupportedVersion msg mixed with Consumer HB

2024-12-28 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908618#comment-17908618 ] Andrew Schofield commented on KAFKA-18135: -- I have decided not to cherry-pick t

Re: [PR] KAFKA-18317: Remove zookeeper.connect from RemoteLogManagerTest [kafka]

2024-12-28 Thread via GitHub
chia7712 merged PR #18283: URL: https://github.com/apache/kafka/pull/18283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18243 Loggers breaks the use of root logger after migrating to log4j2 [kafka]

2024-12-28 Thread via GitHub
frankvicky commented on code in PR #18185: URL: https://github.com/apache/kafka/pull/18185#discussion_r1898915938 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/LoggersTest.java: ## @@ -20,248 +20,168 @@ import org.apache.kafka.common.utils.Time; import org.

Re: [PR] KAFKA-18356 Explicitly setting up instrumentation for inline mocking (Java 21+) [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18339: URL: https://github.com/apache/kafka/pull/18339#discussion_r1898947668 ## build.gradle: ## @@ -1026,6 +1037,12 @@ project(':share') { archivesName = "kafka-share" } + configurations { +mockitoAgent { + transitive = false

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1898947965 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -232,16 +199,14 @@ class SocketServer( } info("Enabling request processing.") -controlPlane

Re: [PR] KAFKA-13093: Log compaction should write new segments with record version v2 (KIP-724) [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18321: URL: https://github.com/apache/kafka/pull/18321#discussion_r1898947254 ## core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala: ## @@ -2580,6 +2580,23 @@ class UnifiedLogTest { assertEquals(None, log.leaderEpochCache.flatMap(_.latest

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1898948164 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -665,16 +663,9 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) def saslMechanis

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1898948313 ## docs/upgrade.html: ## @@ -19,6 +19,13 @@

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1898948528 ## docs/upgrade.html: ## @@ -19,6 +19,13 @@

Re: [PR] KAFKA-18356 Explicitly setting up instrumentation for inline mocking (Java 21+) [kafka]

2024-12-28 Thread via GitHub
m1a2st commented on code in PR #18339: URL: https://github.com/apache/kafka/pull/18339#discussion_r1898948897 ## build.gradle: ## @@ -1026,6 +1037,12 @@ project(':share') { archivesName = "kafka-share" } + configurations { +mockitoAgent { + transitive = false

Re: [PR] KAFKA-18339: Remove raw unversioned direct SASL protocol (KIP-896) [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18295: URL: https://github.com/apache/kafka/pull/18295#discussion_r1898948973 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -1107,8 +1107,10 @@ private[kafka] class Processor( val header = RequestHeader.parse(buffer) if (

Re: [PR] KAFKA-18339: Remove raw unversioned direct SASL protocol (KIP-896) [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18295: URL: https://github.com/apache/kafka/pull/18295#discussion_r1898949056 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -1107,8 +1107,10 @@ private[kafka] class Processor( val header = RequestHeader.parse(buffer) if (

Re: [PR] KAFKA-18339: Remove raw unversioned direct SASL protocol (KIP-896) [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18295: URL: https://github.com/apache/kafka/pull/18295#discussion_r1898949237 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -1107,8 +1107,10 @@ private[kafka] class Processor( val header = RequestHeader.parse(buffer) if (

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

2024-12-28 Thread via GitHub
fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2564397291 @mjsax, can I format the code? Some blocks are not indented correctly. I understand it might pollute the diff in code changes, so if I may, I would do it as a final commit. -- This is

Re: [PR] KAFKA-18272: Deprecated protocol api usage should be logged at info level (3.9) [kafka]

2024-12-28 Thread via GitHub
ijuma commented on PR #18333: URL: https://github.com/apache/kafka/pull/18333#issuecomment-2564382983 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] KAFKA-18272: Deprecated protocol api usage should be logged at info level (3.9) [kafka]

2024-12-28 Thread via GitHub
ijuma merged PR #18333: URL: https://github.com/apache/kafka/pull/18333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #17373: URL: https://github.com/apache/kafka/pull/17373#discussion_r1898950768 ## build.gradle: ## @@ -1099,15 +1103,17 @@ project(':core') { implementation libs.dropwizardMetrics exclude module: 'slf4j-log4j12' exclude module:

Re: [PR] KAFKA-18356 Explicitly setting up instrumentation for inline mocking (Java 21+) [kafka]

2024-12-28 Thread via GitHub
m1a2st commented on code in PR #18339: URL: https://github.com/apache/kafka/pull/18339#discussion_r1898951286 ## build.gradle: ## @@ -1026,6 +1037,12 @@ project(':share') { archivesName = "kafka-share" } + configurations { +mockitoAgent { + transitive = false

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #17373: URL: https://github.com/apache/kafka/pull/17373#discussion_r1898950768 ## build.gradle: ## @@ -1099,15 +1103,17 @@ project(':core') { implementation libs.dropwizardMetrics exclude module: 'slf4j-log4j12' exclude module:

Re: [PR] KAFKA-18356 Explicitly setting up instrumentation for inline mocking (Java 21+) [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18339: URL: https://github.com/apache/kafka/pull/18339#discussion_r1898949548 ## build.gradle: ## @@ -1026,6 +1037,12 @@ project(':share') { archivesName = "kafka-share" } + configurations { +mockitoAgent { + transitive = false

Re: [PR] KAFKA-18356 Explicitly setting up instrumentation for inline mocking (Java 21+) [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18339: URL: https://github.com/apache/kafka/pull/18339#discussion_r1898951583 ## build.gradle: ## @@ -1026,6 +1037,12 @@ project(':share') { archivesName = "kafka-share" } + configurations { +mockitoAgent { + transitive = false

Re: [PR] KAFKA-18339: Remove raw unversioned direct SASL protocol (KIP-896) [kafka]

2024-12-28 Thread via GitHub
chia7712 commented on code in PR #18295: URL: https://github.com/apache/kafka/pull/18295#discussion_r1898951531 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -1107,8 +1107,10 @@ private[kafka] class Processor( val header = RequestHeader.parse(buffer) i

[PR] KAFKA-18358: Replace Deprecated $buildDir variable in build.gradle [kafka]

2024-12-28 Thread via GitHub
m1a2st opened a new pull request, #18343: URL: https://github.com/apache/kafka/pull/18343 Jira: https://issues.apache.org/jira/browse/KAFKA-18358 We should replace `$buildDir` to `${layout.buildDirectory.get().asFile}`, because `$buildDir` is deprecated. see the [gradle document](htt

[jira] [Created] (KAFKA-18359) ix to Kraft or remove tests associate with Zk Broker config in LocalLeaderEndPointTest

2024-12-28 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-18359: - Summary: ix to Kraft or remove tests associate with Zk Broker config in LocalLeaderEndPointTest Key: KAFKA-18359 URL: https://issues.apache.org/jira/browse/KAFKA-18359 Proj

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-12-28 Thread via GitHub
chia7712 commented on code in PR #17373: URL: https://github.com/apache/kafka/pull/17373#discussion_r1899049780 ## build.gradle: ## @@ -1099,15 +1103,17 @@ project(':core') { implementation libs.dropwizardMetrics exclude module: 'slf4j-log4j12' exclude modul

[jira] [Updated] (KAFKA-18359) Fix to Kraft or remove tests associate with Zk Broker config in LocalLeaderEndPointTest, HighwatermarkPersistenceTest, IsrExpirationTest, ReplicaManagerQuotasTest, Offse

2024-12-28 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18359: -- Summary: Fix to Kraft or remove tests associate with Zk Broker config in LocalLeaderEndPointTest, High

[jira] [Updated] (KAFKA-18359) ix to Kraft or remove tests associate with Zk Broker config in LocalLeaderEndPointTest, HighwatermarkPersistenceTest, IsrExpirationTest, ReplicaManagerQuotasTest, Offset

2024-12-28 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18359: -- Summary: ix to Kraft or remove tests associate with Zk Broker config in LocalLeaderEndPointTest, Highw

[jira] [Created] (KAFKA-18360) Remove config in ZkConfigs

2024-12-28 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-18360: - Summary: Remove config in ZkConfigs Key: KAFKA-18360 URL: https://issues.apache.org/jira/browse/KAFKA-18360 Project: Kafka Issue Type: Sub-task Reporte

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-28 Thread via GitHub
ahuang98 commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899071006 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -926,29 +978,18 @@ private boolean handleVoteResponse( if (quorum.isLeader()) {

Re: [PR] MINOR: Enhance performance of ConsumerRecords by refactoring iterator initialization and iteration logic [kafka]

2024-12-28 Thread via GitHub
frankvicky closed pull request #16494: MINOR: Enhance performance of ConsumerRecords by refactoring iterator initialization and iteration logic URL: https://github.com/apache/kafka/pull/16494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-28 Thread via GitHub
ahuang98 commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899072269 ## raft/src/main/java/org/apache/kafka/raft/ProspectiveState.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-28 Thread via GitHub
ahuang98 commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899071006 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -926,29 +978,18 @@ private boolean handleVoteResponse( if (quorum.isLeader()) {

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-28 Thread via GitHub
ahuang98 commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899074255 ## raft/src/main/java/org/apache/kafka/raft/QuorumState.java: ## @@ -402,58 +417,100 @@ public void transitionToUnattached(int epoch) { } /** - * Grant

Re: [PR] MINOR: log4j2 upgrade follow-up [kafka]

2024-12-28 Thread via GitHub
frankvicky commented on PR #18290: URL: https://github.com/apache/kafka/pull/18290#issuecomment-2564633215 Hi @chia7712 I have tested log4j compatibility on my local machine. Explicit set `KAFKA_LOG4J_OPTS`: ![Screenshot from 2024-12-29 14-51-13](https://github.com/user-attachm

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-28 Thread via GitHub
ahuang98 commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899074463 ## raft/src/main/java/org/apache/kafka/raft/QuorumState.java: ## @@ -402,58 +417,100 @@ public void transitionToUnattached(int epoch) { } /** - * Grant

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-28 Thread via GitHub
ahuang98 commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899076157 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -957,13 +998,33 @@ private boolean handleVoteResponse( } } +private void ma

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-28 Thread via GitHub
ahuang98 commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899077542 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -957,13 +998,33 @@ private boolean handleVoteResponse( } } +private void ma

[PR] KAFKA-18356 Explicitly setting up instrumentation for inline mocking (Java 21+) [kafka]

2024-12-28 Thread via GitHub
m1a2st opened a new pull request, #18339: URL: https://github.com/apache/kafka/pull/18339 Jira: https://issues.apache.org/jira/browse/KAFKA-18356 Starting from Java 21, the [JDK restricts the ability of libraries to attach a Java agent to their own JVM](https://openjdk.org/jeps/451).

Re: [PR] MINOR: log4j2 upgrade follow-up [kafka]

2024-12-28 Thread via GitHub
FrankYang0529 commented on code in PR #18290: URL: https://github.com/apache/kafka/pull/18290#discussion_r1898913342 ## bin/kafka-run-class.sh: ## @@ -225,6 +225,18 @@ if [ -z "$KAFKA_LOG4J_OPTS" ]; then (( WINDOWS_OS_FORMAT )) && LOG4J_DIR=$(cygpath --path --mixed "${LOG4J_D

Re: [PR] KAFKA-18135: ShareConsumer HB UnsupportedVersion msg mixed with Consumer HB [kafka]

2024-12-28 Thread via GitHub
AndrewJSchofield commented on PR #18101: URL: https://github.com/apache/kafka/pull/18101#issuecomment-2564364250 Failing test is known as flaky and tracked by https://issues.apache.org/jira/browse/KAFKA-18298. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-18356 Explicitly setting up instrumentation for inline mocking (Java 21+) [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18339: URL: https://github.com/apache/kafka/pull/18339#discussion_r1898951583 ## build.gradle: ## @@ -1026,6 +1037,12 @@ project(':share') { archivesName = "kafka-share" } + configurations { +mockitoAgent { + transitive = false

Re: [PR] KAFKA-18356 Explicitly setting up instrumentation for inline mocking (Java 21+) [kafka]

2024-12-28 Thread via GitHub
m1a2st commented on code in PR #18339: URL: https://github.com/apache/kafka/pull/18339#discussion_r1898951947 ## build.gradle: ## @@ -1026,6 +1037,12 @@ project(':share') { archivesName = "kafka-share" } + configurations { +mockitoAgent { + transitive = false

[jira] [Commented] (KAFKA-18357) Support to dynamically configure the log level for JUL and logback

2024-12-28 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908624#comment-17908624 ] Ismael Juma commented on KAFKA-18357: - I don't think we should implement this oursel

Re: [PR] KAFKA-9366: Upgrade log4j to log4j2 [kafka]

2024-12-28 Thread via GitHub
ppkarwasz commented on code in PR #17373: URL: https://github.com/apache/kafka/pull/17373#discussion_r1898983229 ## build.gradle: ## @@ -1099,15 +1103,17 @@ project(':core') { implementation libs.dropwizardMetrics exclude module: 'slf4j-log4j12' exclude modu

[jira] [Created] (KAFKA-18358) Replace Deprecated $buildDir variable in build.gradle

2024-12-28 Thread Jira
黃竣陽 created KAFKA-18358: --- Summary: Replace Deprecated $buildDir variable in build.gradle Key: KAFKA-18358 URL: https://issues.apache.org/jira/browse/KAFKA-18358 Project: Kafka Issue Type: Improvement

Re: [PR] [WIP] KAFKA-18082: Add 0.11, 1.0, 1.1 and 2.0 to consumer upgrade e2e [kafka]

2024-12-28 Thread via GitHub
chia7712 commented on PR #18193: URL: https://github.com/apache/kafka/pull/18193#issuecomment-2564598755 @mjsax Apologies for bringing up this issue again. I believe that having clear and consistent rolling-upgrade rules can encourage users to adopt version 4.0, which is why I am persistent

Re: [PR] KAFKA-9941;WorkerSinkTask:When a record triggers a RetriableException and the retry is processed successfully, its offset does not commit. [kafka]

2024-12-28 Thread via GitHub
github-actions[bot] commented on PR #9167: URL: https://github.com/apache/kafka/pull/9167#issuecomment-2564600947 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-18277: fix e2e network_degrade_test [kafka]

2024-12-28 Thread via GitHub
github-actions[bot] commented on PR #18247: URL: https://github.com/apache/kafka/pull/18247#issuecomment-2564600944 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-9941;WorkerSinkTask:When a record triggers a RetriableException and the retry is processed successfully, its offset does not commit. [kafka]

2024-12-28 Thread via GitHub
github-actions[bot] closed pull request #9167: KAFKA-9941;WorkerSinkTask:When a record triggers a RetriableException and the retry is processed successfully, its offset does not commit. URL: https://github.com/apache/kafka/pull/9167 -- This is an automated message from the Apache Git Service

Re: [PR] KAFKA-10385 - Remove no print stat when on detailed stat mode on Consumer Perf [kafka]

2024-12-28 Thread via GitHub
github-actions[bot] closed pull request #9161: KAFKA-10385 - Remove no print stat when on detailed stat mode on Consumer Perf URL: https://github.com/apache/kafka/pull/9161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-18336: Improve jmh tests on ACL in AuthorizerBenchmark and StandardAuthorizerUpdateBenchmark [kafka]

2024-12-28 Thread via GitHub
github-actions[bot] commented on PR #18293: URL: https://github.com/apache/kafka/pull/18293#issuecomment-2564600935 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-10385 - Remove no print stat when on detailed stat mode on Consumer Perf [kafka]

2024-12-28 Thread via GitHub
github-actions[bot] commented on PR #9161: URL: https://github.com/apache/kafka/pull/9161#issuecomment-2564600936 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

[PR] KAFKA-18359: Set zkConnect to null in LocalLeaderEndPointTest, HighwatermarkPersistenceTest, IsrExpirationTest, ReplicaManagerQuotasTest, OffsetsForLeaderEpochTest [kafka]

2024-12-28 Thread via GitHub
FrankYang0529 opened a new pull request, #18344: URL: https://github.com/apache/kafka/pull/18344 Set zkConnect to `null` in `TestUtils.createBrokerConfigs`. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage a

[jira] [Updated] (KAFKA-18359) Set zkConnect to null in LocalLeaderEndPointTest, HighwatermarkPersistenceTest, IsrExpirationTest, ReplicaManagerQuotasTest, OffsetsForLeaderEpochTest

2024-12-28 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18359: -- Summary: Set zkConnect to null in LocalLeaderEndPointTest, HighwatermarkPersistenceTest, IsrExpiration

Re: [PR] KAFKA-18315: Fix to Kraft or remove tests associate with Zk Broker config in DynamicBrokerConfigTest, ReplicaManagerTest, DescribeTopicPartitionsRequestHandlerTest, KafkaConfigTest [kafka]

2024-12-28 Thread via GitHub
FrankYang0529 commented on code in PR #18269: URL: https://github.com/apache/kafka/pull/18269#discussion_r1899068553 ## core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala: ## @@ -450,54 +450,52 @@ class DynamicBrokerConfigTest { } @Test - def testPasswo

Re: [PR] KAFKA-17921: Support SASL_PLAINTEXT protocol with java.security.auth.login.config [kafka]

2024-12-28 Thread via GitHub
chia7712 commented on code in PR #17671: URL: https://github.com/apache/kafka/pull/17671#discussion_r1899068385 ## test-common/src/main/java/org/apache/kafka/common/test/JaasModule.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] KAFKA-18339: Remove raw unversioned direct SASL protocol (KIP-896) [kafka]

2024-12-28 Thread via GitHub
ijuma commented on code in PR #18295: URL: https://github.com/apache/kafka/pull/18295#discussion_r1899001868 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -1107,8 +1107,10 @@ private[kafka] class Processor( val header = RequestHeader.parse(buffer) if (

[PR] KAFKA-18339: Fix parseRequestHeader error handling [kafka]

2024-12-28 Thread via GitHub
ijuma opened a new pull request, #18340: URL: https://github.com/apache/kafka/pull/18340 A minor refactoring just before merging #18295 introduced a regression and no test failed. Throw the correct exception and add test to verify it. Also refactor the code slightly to make that possible.

[jira] [Commented] (KAFKA-17178) Update KTable.transformValues to new Processor API

2024-12-28 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908661#comment-17908661 ] A. Sophie Blee-Goldman commented on KAFKA-17178: This is essentially jus

Re: [PR] Removed erroneous quotes from CLASSPATH variable, fixes running on Windows with spaces in path (KAFKA-9710). [kafka]

2024-12-28 Thread via GitHub
rubin55 commented on PR #13057: URL: https://github.com/apache/kafka/pull/13057#issuecomment-2564513862 747 pull-requests.. jeez. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-28 Thread via GitHub
ahuang98 commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899044657 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2442,10 +2503,10 @@ private void maybeTransition( " and epoch " + epoch + " w

[PR] KAFKA-18026: KIP-1112, clean up graph node grace period resolution [kafka]

2024-12-28 Thread via GitHub
ableegoldman opened a new pull request, #18342: URL: https://github.com/apache/kafka/pull/18342 Minor followup to https://github.com/apache/kafka/pull/18195 that I split out into a separate PR since that one was getting a bit long. Should be rebased & reviewed after that one is merged.

[PR] MINOR: add broadcast/multicast to Kafka Streams docs [kafka]

2024-12-28 Thread via GitHub
mjsax opened a new pull request, #18341: URL: https://github.com/apache/kafka/pull/18341 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] MINOR: add broadcast/multicast to Kafka Streams docs [kafka]

2024-12-28 Thread via GitHub
mjsax commented on code in PR #18341: URL: https://github.com/apache/kafka/pull/18341#discussion_r1899011500 ## docs/streams/developer-guide/dsl-api.html: ## @@ -398,12 +421,11 @@ KStream stream = ...; // A filter that selects (keeps) only positive numbers -// J

Re: [PR] [WIP] KAFKA-18082: Add 0.11, 1.0, 1.1 and 2.0 to consumer upgrade e2e [kafka]

2024-12-28 Thread via GitHub
ijuma commented on PR #18193: URL: https://github.com/apache/kafka/pull/18193#issuecomment-2564488560 Yes, that would be simplest. That said, we should be clear that Connect is more of a server component (i.e. it doesn't run alongside customer applications) even though it communicates with

Re: [PR] MINOR: remove zkBroker from StreamsGroupHeartbeatRequest and StreamsGroupDescribeRequest [kafka]

2024-12-28 Thread via GitHub
chia7712 merged PR #18319: URL: https://github.com/apache/kafka/pull/18319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: log4j2 upgrade follow-up [kafka]

2024-12-28 Thread via GitHub
chia7712 commented on code in PR #18290: URL: https://github.com/apache/kafka/pull/18290#discussion_r1898896277 ## bin/kafka-run-class.sh: ## @@ -225,6 +225,18 @@ if [ -z "$KAFKA_LOG4J_OPTS" ]; then (( WINDOWS_OS_FORMAT )) && LOG4J_DIR=$(cygpath --path --mixed "${LOG4J_DIR}")

[jira] [Updated] (KAFKA-18356) Explicitly setting up instrumentation for inline mocking (Java 21+)

2024-12-28 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18356: Description: When I run test in Java 21, I find there are some warning logs, we should imporve mokito to resolve

[jira] [Updated] (KAFKA-18356) Explicitly setting up instrumentation for inline mocking (Java 21+)

2024-12-28 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18356: Description: When I run test in Java 21, I find there are some warning logs, we should imporve mokito to resolve

[jira] [Created] (KAFKA-18356) Explicitly setting up instrumentation for inline mocking (Java 21+)

2024-12-28 Thread Jira
黃竣陽 created KAFKA-18356: --- Summary: Explicitly setting up instrumentation for inline mocking (Java 21+) Key: KAFKA-18356 URL: https://issues.apache.org/jira/browse/KAFKA-18356 Project: Kafka Issue Type