ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898983229
##########
build.gradle:
##########
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude module: 'log4j'
- // Both Kafka and Zookeeper use slf4j. ZooKeeper moved from log4j to
logback in v3.8.0, but Kafka relies on reload4j.
+ // Both Kafka and Zookeeper use slf4j. ZooKeeper moved from log4j to
logback in v3.8.0.
// We are removing Zookeeper's dependency on logback so we have a
singular logging backend.
exclude module: 'logback-classic'
exclude module: 'logback-core'
}
// ZooKeeperMain depends on commons-cli but declares the dependency as
`provided`
implementation libs.commonsCli
-
- compileOnly libs.reload4j
+ implementation libs.log4j2Core
+ implementation libs.log4j2Api
+ implementation libs.log4j1Bridge2Api
+ implementation libs.jacksonDatabindYaml
Review Comment:
> 1. Your logging admin library.
I pushed the draft to Apache Logging
([`apache/logging-admin`](https://github.com/apache/logging-admin)) and I'll
start to actively work on it. Probably you can expect a release by end of
January/February.
In the meantime I can make a PR for Kafka, so that `Log4jController` fails
softly if Log4j Core is not present.
> 2. slf4j2 makes it possible to choose the logging library dynamically
instead of via classpath tricks.
Note that choosing the SLF4J implementation does not really tell you which
logging implementation is being used: except Logback, all the other SLF4J
implementation are bridges between logging APIs. If you use `slf4j-jdk14` you
don't know which JUL implementation is being used and if you use
`log4j-slf4j2-impl` you don't know which Log4j API implementation is being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
