FrankYang0529 commented on code in PR #18269:
URL: https://github.com/apache/kafka/pull/18269#discussion_r1899068553
##########
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##########
@@ -450,54 +450,52 @@ class DynamicBrokerConfigTest {
}
@Test
- def testPasswordConfigEncryption(): Unit = {
- val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect, port
= 8181)
+ def testPasswordConfigNotEncryption(): Unit = {
+ val props = TestUtils.createBrokerConfig(0, null, port = 8181)
Review Comment:
It looks like following test cases still use `MockZkConnect`. Could you also
update it? Thanks.
* testDynamicConfigInitializationWithoutConfigsInZK
* testUpdateRemoteLogManagerDynamicThreadPool
* testRemoteLogDynamicThreadPoolWithInvalidValues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
