ijuma commented on code in PR #18295:
URL: https://github.com/apache/kafka/pull/18295#discussion_r1898948973
##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -1107,8 +1107,10 @@ private[kafka] class Processor(
val header = RequestHeader.parse(buffer)
if (apiVersionManager.isApiEnabled(header.apiKey, header.apiVersion)) {
header
- } else {
+ } else if (header.isApiVersionDeprecated()) {
Review Comment:
No, I added a commit at the end that changes this incorrectly:
https://github.com/apache/kafka/pull/18295/commits/b381c07a595ad616aca2579fb34660f48ea60333
Thanks for catching that.
##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -1107,8 +1107,10 @@ private[kafka] class Processor(
val header = RequestHeader.parse(buffer)
if (apiVersionManager.isApiEnabled(header.apiKey, header.apiVersion)) {
header
- } else {
+ } else if (header.isApiVersionDeprecated()) {
Review Comment:
No, I added a commit at the end that changed this incorrectly:
https://github.com/apache/kafka/pull/18295/commits/b381c07a595ad616aca2579fb34660f48ea60333
Thanks for catching that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
