Re: [PR] KAFKA-16448: Add ProcessingExceptionHandler in Streams configuration [kafka]

2024-05-30 Thread via GitHub
cadonna commented on PR #16092: URL: https://github.com/apache/kafka/pull/16092#issuecomment-2138834558 > @cadonna I've rebased this PR so file changes are now clear. Do we need to squash commits manually or is it automatically done when merging ? Thanks! Squashing happens when mergin

Re: [PR] KAFKA-16821: Member Subscription Spec Interface [kafka]

2024-05-30 Thread via GitHub
rreddy-22 commented on code in PR #16068: URL: https://github.com/apache/kafka/pull/16068#discussion_r1620157517 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -277,13 +277,22 @@ public TargetAssignmentBuilder r

[jira] [Updated] (KAFKA-16814) KRaft broker cannot startup when `partition.metadata` is missing

2024-05-30 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-16814: -- Priority: Blocker (was: Major) > KRaft broker cannot startup when `partition.metadata` is missing > -

Re: [PR] KAFKA-16573: Specify node and store where serdes are needed [kafka]

2024-05-30 Thread via GitHub
cadonna commented on code in PR #15790: URL: https://github.com/apache/kafka/pull/15790#discussion_r1620256284 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java: ## @@ -58,8 +60,21 @@ public void addChild(final ProcessorNode child) { publi

Re: [PR] KAFKA-16790: Update RemoteLogManager configuration in broker server [kafka]

2024-05-30 Thread via GitHub
clolov commented on PR #16005: URL: https://github.com/apache/kafka/pull/16005#issuecomment-2139031992 Thanks for persevering with this @muralibasani! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16860; [1/2] Introduce group.version feature flag [kafka]

2024-05-30 Thread via GitHub
dajac commented on PR #16120: URL: https://github.com/apache/kafka/pull/16120#issuecomment-2139033773 @jolshan I rebased it on top of https://github.com/apache/kafka/pull/16130 and I fixed all the tests that I missed. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-16448: Add ProcessingExceptionHandler in Streams configuration [kafka]

2024-05-30 Thread via GitHub
cadonna merged PR #16092: URL: https://github.com/apache/kafka/pull/16092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16480: Bump ListOffsets version, IBP version and mark last version of ListOffsets as unstable [kafka]

2024-05-30 Thread via GitHub
clolov commented on PR #15673: URL: https://github.com/apache/kafka/pull/15673#issuecomment-2139051996 Heya @junrao, the delay is entirely my bad, I will aim to give an update either today or early tomorrow morning -- This is an automated message from the Apache Git Service. To respond to

[PR] KAFKA-16854: Add StopReplica v5 [kafka]

2024-05-30 Thread via GitHub
clolov opened a new pull request, #16131: URL: https://github.com/apache/kafka/pull/16131 ### Summary Add StopReplica v5 for KIP-950 and put it behind an unstable flag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Assigned] (KAFKA-16851) Add remote.log.disable.policy

2024-05-30 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov reassigned KAFKA-16851: - Assignee: Christo Lolov > Add remote.log.disable.policy > -

[jira] [Commented] (KAFKA-16862) Refactor ConsumerTaskTest to be deterministic and avoid tight loops

2024-05-30 Thread Anuj Garg (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850651#comment-17850651 ] Anuj Garg commented on KAFKA-16862: --- I would like to work on this task. > Refactor Co

Re: [PR] KAFKA-16821: Member Subscription Spec Interface [kafka]

2024-05-30 Thread via GitHub
dajac commented on code in PR #16068: URL: https://github.com/apache/kafka/pull/16068#discussion_r1620268966 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupSpec.java: ## @@ -39,4 +41,20 @@ public interface GroupSpec { * False, o

Re: [PR] Enable KRaft for BaseAdminIntegrationTest and SaslSslAdminIntegrationTest [kafka]

2024-05-30 Thread via GitHub
mimaison commented on PR #15175: URL: https://github.com/apache/kafka/pull/15175#issuecomment-2139133566 Hi @CalvinConfluent, Thanks for the clarification. The issue is that this causes a compatibility change. For example with the following code: ```java DescribeTopicsOptions op

Re: [PR] KAFKA-16854: Add StopReplica v5 [kafka]

2024-05-30 Thread via GitHub
dajac commented on PR #16131: URL: https://github.com/apache/kafka/pull/16131#issuecomment-2139141199 Hey @clolov -- I wonder if it is worth doing the ZK related changes for this KIP. It looks like it won't be in 3.8 and we won't support ZK in 4.0. -- This is an automated message from the

Re: [PR] Enable KRaft for BaseAdminIntegrationTest and SaslSslAdminIntegrationTest [kafka]

2024-05-30 Thread via GitHub
mimaison commented on PR #15175: URL: https://github.com/apache/kafka/pull/15175#issuecomment-2139143354 I created https://issues.apache.org/jira/browse/KAFKA-16865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Created] (KAFKA-16865) Admin.describeTopics behavior change after KIP-966

2024-05-30 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-16865: -- Summary: Admin.describeTopics behavior change after KIP-966 Key: KAFKA-16865 URL: https://issues.apache.org/jira/browse/KAFKA-16865 Project: Kafka Issue

[jira] [Updated] (KAFKA-16865) Admin.describeTopics behavior change after KIP-966

2024-05-30 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-16865: --- Affects Version/s: 3.8.0 > Admin.describeTopics behavior change after KIP-966 >

Re: [PR] KAFKA-16854: Add StopReplica v5 [kafka]

2024-05-30 Thread via GitHub
clolov commented on PR #16131: URL: https://github.com/apache/kafka/pull/16131#issuecomment-2139175572 I think myself, @showuon, @satishd, @jeqo, @ivanyu and a few others would like to have disablement available both for ZK and KRaft as part of the effort to mark tiered storage as generally

Re: [PR] MINOR: Remove KafkaConfig dependency in KafkaRequestHandler [kafka]

2024-05-30 Thread via GitHub
mimaison commented on PR #16108: URL: https://github.com/apache/kafka/pull/16108#issuecomment-2139185031 Thanks for the reviews! Test failures are not related, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] MINOR: Remove KafkaConfig dependency in KafkaRequestHandler [kafka]

2024-05-30 Thread via GitHub
mimaison merged PR #16108: URL: https://github.com/apache/kafka/pull/16108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-05-30 Thread via GitHub
cadonna commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1620418184 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java: ## @@ -288,7 +301,31 @@ private void forwardInternal(final ProcessorNo

Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-05-30 Thread via GitHub
kamalcph commented on PR #15165: URL: https://github.com/apache/kafka/pull/15165#issuecomment-2139233455 Reviewing the patch, I'll provide my comments by today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-16854: Add StopReplica v5 [kafka]

2024-05-30 Thread via GitHub
dajac commented on PR #16131: URL: https://github.com/apache/kafka/pull/16131#issuecomment-2139263581 I think the question is how are we going to bring it to ZK if 3.8 is the last version supporting it. -- This is an automated message from the Apache Git Service. To respond to the message

[PR] KAFKA-16851: Add remote.log.disable.policy [kafka]

2024-05-30 Thread via GitHub
clolov opened a new pull request, #16132: URL: https://github.com/apache/kafka/pull/16132 ### Summary Add a (for now internal-only) remote.log.disable.policy on a topic-level only as part of KIP-950 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Enable KRaft for BaseAdminIntegrationTest and SaslSslAdminIntegrationTest [kafka]

2024-05-30 Thread via GitHub
tinaselenge commented on PR #15175: URL: https://github.com/apache/kafka/pull/15175#issuecomment-2139323605 Thanks @mimaison raising the issue. > On the other hand, the DescribeTopicPartitions API always includes authorizedOperations all the time on Kraft. Is there a reason why we wa

Re: [PR] KAFKA-8206: Allow client to rebootstrap [kafka]

2024-05-30 Thread via GitHub
ivanyu commented on code in PR #13277: URL: https://github.com/apache/kafka/pull/13277#discussion_r1620514653 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -304,6 +306,12 @@ public synchronized void bootstrap(List addresses) { this.needFullUpda

Re: [PR] KAFKA-16824: Utils.getHost and Utils.getPort do not catch a lot of invalid host and ports. [kafka]

2024-05-30 Thread via GitHub
showuon commented on code in PR #16048: URL: https://github.com/apache/kafka/pull/16048#discussion_r1620515156 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -94,7 +94,7 @@ private Utils() {} // This matches URIs of formats: host:port and protoco

Re: [PR] KAFKA-16860; [1/2] Introduce group.version feature flag [kafka]

2024-05-30 Thread via GitHub
dajac commented on PR #16120: URL: https://github.com/apache/kafka/pull/16120#issuecomment-2139365026 Apparently, I have to fix a few others. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Assigned] (KAFKA-16865) Admin.describeTopics behavior change after KIP-966

2024-05-30 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-16865: - Assignee: Gantigmaa Selenge > Admin.describeTopics behavior change after KIP-96

Re: [PR] KAFKA-8206: Allow client to rebootstrap [kafka]

2024-05-30 Thread via GitHub
ivanyu commented on code in PR #13277: URL: https://github.com/apache/kafka/pull/13277#discussion_r1620547544 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -307,7 +307,8 @@ class KafkaRaftManager[T]( time, discoverBrokerVersions, apiVersions, -

Re: [PR] KAFKA-8206: Allow client to rebootstrap [kafka]

2024-05-30 Thread via GitHub
ivanyu commented on code in PR #13277: URL: https://github.com/apache/kafka/pull/13277#discussion_r1620545307 ## clients/src/main/java/org/apache/kafka/clients/MetadataRecoveryStrategy.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-8206: Allow client to rebootstrap [kafka]

2024-05-30 Thread via GitHub
ivanyu commented on code in PR #13277: URL: https://github.com/apache/kafka/pull/13277#discussion_r1620547544 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -307,7 +307,8 @@ class KafkaRaftManager[T]( time, discoverBrokerVersions, apiVersions, -

Re: [PR] KAFKA-16824: Utils.getHost and Utils.getPort do not catch a lot of invalid host and ports. [kafka]

2024-05-30 Thread via GitHub
frankvicky commented on code in PR #16048: URL: https://github.com/apache/kafka/pull/16048#discussion_r1620545943 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -94,7 +94,7 @@ private Utils() {} // This matches URIs of formats: host:port and prot

Re: [PR] KAFKA-8206: Allow client to rebootstrap [kafka]

2024-05-30 Thread via GitHub
ivanyu commented on code in PR #13277: URL: https://github.com/apache/kafka/pull/13277#discussion_r1620549218 ## clients/src/main/java/org/apache/kafka/clients/MetadataRecoveryStrategy.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-8206: Allow client to rebootstrap [kafka]

2024-05-30 Thread via GitHub
ivanyu commented on code in PR #13277: URL: https://github.com/apache/kafka/pull/13277#discussion_r1620553331 ## clients/src/main/java/org/apache/kafka/clients/MetadataRecoveryStrategy.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-16639: AsyncKafkaConsumer#close dose not send heartbeat to leave group. [kafka]

2024-05-30 Thread via GitHub
frankvicky commented on code in PR #16017: URL: https://github.com/apache/kafka/pull/16017#discussion_r1620555264 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -208,7 +209,11 @@ public NetworkClientDelegate.PollResult po

Re: [PR] KAFKA-16252; Dynamic KRaft network manager and channel [kafka]

2024-05-30 Thread via GitHub
showuon commented on code in PR #15986: URL: https://github.com/apache/kafka/pull/15986#discussion_r1620562119 ## raft/src/main/java/org/apache/kafka/raft/RequestManager.java: ## @@ -17,108 +17,296 @@ package org.apache.kafka.raft; import java.util.ArrayList; +import java.ut

Re: [PR] KAFKA-16639: AsyncKafkaConsumer#close dose not send heartbeat to leave group. [kafka]

2024-05-30 Thread via GitHub
frankvicky commented on PR #16017: URL: https://github.com/apache/kafka/pull/16017#issuecomment-2139394050 Hi @lianetm, thanks for your comments. I have made some changes based on them, please take a look. 😺 -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] MINOR:Improve ConsumerRebalanceListener doc [kafka]

2024-05-30 Thread via GitHub
TaiJuWu commented on PR #16083: URL: https://github.com/apache/kafka/pull/16083#issuecomment-2139394200 Hi @AndrewJSchofield @lianetm Thanks for your review and I address your comments, please review again. -- This is an automated message from the Apache Git Service. To respond to the m

[PR] MINOR: Refactor DynamicConfig [kafka]

2024-05-30 Thread via GitHub
mimaison opened a new pull request, #16133: URL: https://github.com/apache/kafka/pull/16133 - Remove direct dependency on KafkaConfig (still indirect via DynamicBrokerConfig) - Make DynamicConfig.Broker consistent with other dynamic configurations ### Committer Checklist (excluded

[PR] KAFKA-16715: Create KafkaShareConsumer interfaces [kafka]

2024-05-30 Thread via GitHub
AndrewJSchofield opened a new pull request, #16134: URL: https://github.com/apache/kafka/pull/16134 This PR introduces ShareConsumer and KafkaShareConsumer. It is focused entirely on the minimal additions required to introduce the external programming interfaces. ### Committer Checkl

Re: [PR] KAFKA-8206: Allow client to rebootstrap [kafka]

2024-05-30 Thread via GitHub
ivanyu commented on code in PR #13277: URL: https://github.com/apache/kafka/pull/13277#discussion_r1620581608 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -135,6 +136,7 @@ object KafkaConfig { .define(ServerConfigs.REQUEST_TIMEOUT_MS_CONFIG, INT, ServerCo

Re: [PR] KAFKA-8206: Allow client to rebootstrap [kafka]

2024-05-30 Thread via GitHub
ivanyu commented on code in PR #13277: URL: https://github.com/apache/kafka/pull/13277#discussion_r1620593527 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminMetadataManager.java: ## @@ -287,4 +293,12 @@ public void update(Cluster cluster, long now) {

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-05-30 Thread via GitHub
muralibasani commented on code in PR #16094: URL: https://github.com/apache/kafka/pull/16094#discussion_r1619077543 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -452,21 +460,68 @@ object StorageTool extends Logging { stream.println("All of the log directori

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-05-30 Thread via GitHub
muralibasani commented on code in PR #16094: URL: https://github.com/apache/kafka/pull/16094#discussion_r1619077543 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -452,21 +460,68 @@ object StorageTool extends Logging { stream.println("All of the log directori

Re: [PR] KAFKA-16252; Dynamic KRaft network manager and channel [kafka]

2024-05-30 Thread via GitHub
showuon commented on code in PR #15986: URL: https://github.com/apache/kafka/pull/15986#discussion_r1620608088 ## raft/src/main/java/org/apache/kafka/raft/RequestManager.java: ## @@ -17,108 +17,296 @@ package org.apache.kafka.raft; import java.util.ArrayList; +import java.ut

Re: [PR] KAFKA-16715: Create KafkaShareConsumer interfaces [kafka]

2024-05-30 Thread via GitHub
AndrewJSchofield commented on PR #16134: URL: https://github.com/apache/kafka/pull/16134#issuecomment-2139446089 The build will not succeed until https://github.com/apache/kafka/pull/16022 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, p

[PR] KAFKA-16802 : Moving java versions inside java block [kafka]

2024-05-30 Thread via GitHub
muralibasani opened a new pull request, #16135: URL: https://github.com/apache/kafka/pull/16135 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* Resolves : htt

Re: [PR] KAFKA-16802 : Moving java versions inside java block [kafka]

2024-05-30 Thread via GitHub
muralibasani commented on PR #16135: URL: https://github.com/apache/kafka/pull/16135#issuecomment-2139463381 @gharris1727 would you like to take a look ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Reopened] (KAFKA-13295) Long restoration times for new tasks can lead to transaction timeouts

2024-05-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reopened KAFKA-13295: --- Assignee: (was: Sagar Rao) > Long restoration times for new tasks can lead to transact

[jira] [Updated] (KAFKA-13295) Long restoration times for new tasks can lead to transaction timeouts

2024-05-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13295: -- Fix Version/s: (was: 3.4.0) > Long restoration times for new tasks can lead to transaction

Re: [PR] MINOR:Improve ConsumerRebalanceListener doc [kafka]

2024-05-30 Thread via GitHub
AndrewJSchofield commented on code in PR #16083: URL: https://github.com/apache/kafka/pull/16083#discussion_r1620630034 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java: ## @@ -28,37 +28,37 @@ * This is applicable when the consumer is h

[jira] [Commented] (KAFKA-13295) Long restoration times for new tasks can lead to transaction timeouts

2024-05-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850702#comment-17850702 ] Bruno Cadonna commented on KAFKA-13295: --- I re-opened the issue because we did not

[jira] [Assigned] (KAFKA-13295) Long restoration times for new tasks can lead to transaction timeouts

2024-05-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-13295: - Assignee: Bruno Cadonna > Long restoration times for new tasks can lead to transaction

[PR] Add IncludeTopicAuthorizedOperations option for DescribeTopicPartitionsRequest [kafka]

2024-05-30 Thread via GitHub
tinaselenge opened a new pull request, #16136: URL: https://github.com/apache/kafka/pull/16136 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] MINOR: make public the consumer group migration policy config [kafka]

2024-05-30 Thread via GitHub
chia7712 commented on PR #16128: URL: https://github.com/apache/kafka/pull/16128#issuecomment-2139527090 @dongnuo123 Could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [DO NOT MERGE] PoC for ProcessingExceptionHandler [kafka]

2024-05-30 Thread via GitHub
cadonna opened a new pull request, #16137: URL: https://github.com/apache/kafka/pull/16137 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

Re: [PR] KAFKA-8206: Allow client to rebootstrap [kafka]

2024-05-30 Thread via GitHub
ivanyu commented on code in PR #13277: URL: https://github.com/apache/kafka/pull/13277#discussion_r1620696831 ## clients/src/main/java/org/apache/kafka/clients/NetworkClient.java: ## @@ -1123,6 +1133,17 @@ public long maybeUpdate(long now) { // Beware that the behav

Re: [PR] KAFKA-16833: Fixing PartitionInfo and Cluster equals and hashCode [kafka]

2024-05-30 Thread via GitHub
chia7712 commented on code in PR #16062: URL: https://github.com/apache/kafka/pull/16062#discussion_r1620696237 ## clients/src/test/java/org/apache/kafka/common/ClusterTest.java: ## @@ -89,4 +92,74 @@ public void testReturnUnmodifiableCollections() { new PartitionIn

[jira] [Comment Edited] (KAFKA-15305) The background thread should try to process the remaining task until the shutdown timer is expired

2024-05-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850505#comment-17850505 ] Chia-Ping Tsai edited comment on KAFKA-15305 at 5/30/24 1:17 PM: -

[jira] [Comment Edited] (KAFKA-15305) The background thread should try to process the remaining task until the shutdown timer is expired

2024-05-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850505#comment-17850505 ] Chia-Ping Tsai edited comment on KAFKA-15305 at 5/30/24 1:17 PM: -

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-05-30 Thread via GitHub
cadonna commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1620709873 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java: ## @@ -288,7 +301,31 @@ private void forwardInternal(final ProcessorNo

Re: [PR] KAFKA-16629: Add broker-related tests to ConfigCommandIntegrationTest [kafka]

2024-05-30 Thread via GitHub
chia7712 commented on code in PR #15840: URL: https://github.com/apache/kafka/pull/15840#discussion_r1620707500 ## core/src/main/scala/kafka/admin/ConfigCommand.scala: ## @@ -210,15 +210,19 @@ object ConfigCommand extends Logging { } } - def createPasswordEncoder(enco

Re: [PR] MINOR: migrate ListConsumerGroupTest to use ClusterTestExtensions [kafka]

2024-05-30 Thread via GitHub
chia7712 merged PR #15821: URL: https://github.com/apache/kafka/pull/15821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: migrate DescribeConsumerGroupTest to use ClusterTestExtensions [kafka]

2024-05-30 Thread via GitHub
chia7712 commented on PR #15908: URL: https://github.com/apache/kafka/pull/15908#issuecomment-2139564485 @FrankYang0529 please fix the conflicts, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16860; [1/2] Introduce group.version feature flag [kafka]

2024-05-30 Thread via GitHub
dajac commented on PR #16120: URL: https://github.com/apache/kafka/pull/16120#issuecomment-2139569531 Ok. I have fixed all the tests, hopefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-16865: Add IncludeTopicAuthorizedOperations option for DescribeTopicPartitionsRequest [kafka]

2024-05-30 Thread via GitHub
AndrewJSchofield commented on code in PR #16136: URL: https://github.com/apache/kafka/pull/16136#discussion_r1620732915 ## clients/src/main/resources/common/message/DescribeTopicPartitionsRequest.json: ## @@ -30,6 +30,8 @@ }, { "name": "ResponsePartitionLimit", "type":

Re: [PR] KAFKA-16821: Member Subscription Spec Interface [kafka]

2024-05-30 Thread via GitHub
dajac commented on code in PR #16068: URL: https://github.com/apache/kafka/pull/16068#discussion_r1620735975 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -293,14 +295,22 @@ public TargetAssignmentBuilder remov

Re: [PR] KAFKA-15853: Move configDef out of core [kafka]

2024-05-30 Thread via GitHub
chia7712 commented on PR #16116: URL: https://github.com/apache/kafka/pull/16116#issuecomment-2139580085 @OmniaGM Please fix the conflicts, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16308 [2/N]: Allow unstable feature versions and rename unstable metadata config [kafka]

2024-05-30 Thread via GitHub
dajac commented on code in PR #16130: URL: https://github.com/apache/kafka/pull/16130#discussion_r1620747107 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -449,8 +449,8 @@ object KafkaConfig { /** Internal Configurations **/ // This indicates whether

Re: [PR] KAFKA-16851: Add remote.log.disable.policy [kafka]

2024-05-30 Thread via GitHub
chia7712 commented on PR #16132: URL: https://github.com/apache/kafka/pull/16132#issuecomment-2139596382 @clolov Could you please fix the conflicts? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-05-30 Thread via GitHub
chia7712 merged PR #15779: URL: https://github.com/apache/kafka/pull/15779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-16598) Mirgrate `ResetConsumerGroupOffsetTest` to new test infra

2024-05-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16598. Fix Version/s: 3.8.0 Resolution: Fixed > Mirgrate `ResetConsumerGroupOffsetTest` to

Re: [PR] KAFKA-16105: Reassignment fix [kafka]

2024-05-30 Thread via GitHub
kamalcph commented on code in PR #15165: URL: https://github.com/apache/kafka/pull/15165#discussion_r1620748127 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java: ## @@ -254,6 +259,61 @@ public void testCanProcessRecord() throws

[PR] KAFKA-16856 : Adding new exception [kafka]

2024-05-30 Thread via GitHub
muralibasani opened a new pull request, #16138: URL: https://github.com/apache/kafka/pull/16138 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* Resolves : htt

[jira] [Commented] (KAFKA-16856) Zookeeper - Add new exception

2024-05-30 Thread Muralidhar Basani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850728#comment-17850728 ] Muralidhar Basani commented on KAFKA-16856: --- [~christo_lolov] I tried to creat

Re: [PR] KAFKA-16865: Add IncludeTopicAuthorizedOperations option for DescribeTopicPartitionsRequest [kafka]

2024-05-30 Thread via GitHub
tinaselenge commented on code in PR #16136: URL: https://github.com/apache/kafka/pull/16136#discussion_r1620819925 ## clients/src/main/resources/common/message/DescribeTopicPartitionsRequest.json: ## @@ -30,6 +30,8 @@ }, { "name": "ResponsePartitionLimit", "type": "int

[PR] MINOR: Enable transaction verification with new group coordinator in TransactionsTest [kafka]

2024-05-30 Thread via GitHub
dajac opened a new pull request, #16139: URL: https://github.com/apache/kafka/pull/16139 While working on https://github.com/apache/kafka/pull/16120, I noticed that the transaction verification feature is disabled in `TransactionsTest` when the new group coordinator is enabled. We did this

[PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

2024-05-30 Thread via GitHub
brenden20 opened a new pull request, #16140: URL: https://github.com/apache/kafka/pull/16140 Completely migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder and removed all usages of spy objects and replaced with mocks. Removed testEnsureMetadataUpdateOnPoll() since it was doing

Re: [PR] MINOR: Add more unit tests to LogSegments [kafka]

2024-05-30 Thread via GitHub
brandboat commented on code in PR #16085: URL: https://github.com/apache/kafka/pull/16085#discussion_r1620878806 ## core/src/test/scala/unit/kafka/log/LogSegmentTest.scala: ## @@ -632,6 +632,15 @@ class LogSegmentTest { Utils.delete(tempDir) } + @Test + def testGetFi

Re: [PR] KAFKA-16764: New consumer should throw InvalidTopicException on poll when invalid topic in metadata [kafka]

2024-05-30 Thread via GitHub
appchemist commented on code in PR #15961: URL: https://github.com/apache/kafka/pull/15961#discussion_r1620884853 ## clients/src/main/java/org/apache/kafka/clients/ClientUtils.java: ## @@ -172,7 +173,37 @@ public static NetworkClient createNetworkClient(AbstractConfig config,

Re: [PR] KAFKA-15045: (KIP-924 pt. 15) More TaskAssigmentUtils implementation [kafka]

2024-05-30 Thread via GitHub
apourchet commented on code in PR #16129: URL: https://github.com/apache/kafka/pull/16129#discussion_r1620937108 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java: ## @@ -278,7 +278,7 @@ public void processOptimizedAssignmen

Re: [PR] KAFKA-16844: Add ByteBuffer support for Connect ByteArrayConverter [kafka]

2024-05-30 Thread via GitHub
C0urante merged PR #16101: URL: https://github.com/apache/kafka/pull/16101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-16844) ByteArrayConverter can't convert ByteBuffer

2024-05-30 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-16844. --- Fix Version/s: 3.8.0 Resolution: Fixed > ByteArrayConverter can't convert ByteBuffer

Re: [PR] KAFKA-16837, KAFKA-16838: Discard task configs for deleted connectors, and compare raw task configs before publishing them [kafka]

2024-05-30 Thread via GitHub
C0urante commented on code in PR #16122: URL: https://github.com/apache/kafka/pull/16122#discussion_r1620958108 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -1039,16 +1039,16 @@ public static List> reverseTransform(String connName

Re: [PR] KAFKA-16254: Allow MM2 to fully disable offset sync feature [kafka]

2024-05-30 Thread via GitHub
mimaison commented on code in PR #15999: URL: https://github.com/apache/kafka/pull/15999#discussion_r1620924489 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConfig.java: ## @@ -252,7 +252,13 @@ private static ConfigDef defineCheckpointConfig(Co

[PR] Revert "KAFKA-16448: Add ProcessingExceptionHandler in Streams configuration (#16092)" [kafka]

2024-05-30 Thread via GitHub
cadonna opened a new pull request, #16141: URL: https://github.com/apache/kafka/pull/16141 We decided not to release KIP-1033 with AK 3.8 This reverts commit 3f70c46874e1dd9591443392f51ff1efc9fdc40e. *More detailed description of your change, if necessary. The PR title and P

Re: [PR] Revert "KAFKA-16448: Add ProcessingExceptionHandler in Streams configuration (#16092)" [kafka]

2024-05-30 Thread via GitHub
cadonna merged PR #16141: URL: https://github.com/apache/kafka/pull/16141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[PR] Revert "KAFKA-16448: Add ProcessingExceptionHandler interface and implementations (#16090)" [kafka]

2024-05-30 Thread via GitHub
cadonna opened a new pull request, #16142: URL: https://github.com/apache/kafka/pull/16142 This reverts commit 8d11d9579503426edfaeae791ec4bb212da37ad2. We decided to not release KIP-1033 with AK 3.8 *More detailed description of your change, if necessary. The PR title and PR

Re: [PR] KAFKA-16308 [2/N]: Allow unstable feature versions and rename unstable metadata config [kafka]

2024-05-30 Thread via GitHub
jolshan commented on code in PR #16130: URL: https://github.com/apache/kafka/pull/16130#discussion_r1621005757 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -449,8 +449,8 @@ object KafkaConfig { /** Internal Configurations **/ // This indicates wheth

[jira] [Commented] (KAFKA-15305) The background thread should try to process the remaining task until the shutdown timer is expired

2024-05-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850778#comment-17850778 ] Lianet Magrans commented on KAFKA-15305: Agree with this missing bit, but I wond

[jira] [Commented] (KAFKA-16639) AsyncKafkaConsumer#close does not send heartbeat to leave group

2024-05-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850779#comment-17850779 ] Lianet Magrans commented on KAFKA-16639: Hey [~chia7712] , totally agree. The PR

Re: [PR] KAFKA-16860; [1/2] Introduce group.version feature flag [kafka]

2024-05-30 Thread via GitHub
jolshan commented on code in PR #16120: URL: https://github.com/apache/kafka/pull/16120#discussion_r1621009962 ## server-common/src/main/java/org/apache/kafka/server/common/GroupVersion.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-30 Thread via GitHub
junrao merged PR #15625: URL: https://github.com/apache/kafka/pull/15625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[PR] KAFKA-14919 sync topic configs test [kafka]

2024-05-30 Thread via GitHub
anton-liauchuk opened a new pull request, #16143: URL: https://github.com/apache/kafka/pull/16143 KAFKA-14919 sync topic configs test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-14919 sync topic configs test [kafka]

2024-05-30 Thread via GitHub
anton-liauchuk commented on PR #16143: URL: https://github.com/apache/kafka/pull/16143#issuecomment-2140109909 @gharris1727 Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (KAFKA-14919) MM2 ForwardingAdmin tests should not conflate admin operations

2024-05-30 Thread Anton Liauchuk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850787#comment-17850787 ] Anton Liauchuk commented on KAFKA-14919: [~gharris1727] please take a look [http

[PR] Re-add EventAccumulator.poll(long, TimeUnit) [kafka]

2024-05-30 Thread via GitHub
jeffkbkim opened a new pull request, #16144: URL: https://github.com/apache/kafka/pull/16144 We have revamped the thread idle ratio metric in https://github.com/apache/kafka/pull/15835. https://github.com/apache/kafka/pull/15835#discussion_r1588068337 describes a case where the metric lose

[jira] [Assigned] (KAFKA-16664) Re-add EventAccumulator.take(timeout)

2024-05-30 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim reassigned KAFKA-16664: Assignee: Jeff Kim > Re-add EventAccumulator.take(timeout) >

[jira] [Commented] (KAFKA-16664) Re-add EventAccumulator.take(timeout)

2024-05-30 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850789#comment-17850789 ] Jeff Kim commented on KAFKA-16664: -- [~phong260702] The removal was in a separate commit

  1   2   3   >